All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: avoid mvneta warning when setting pause parameters
Date: Thu, 28 Oct 2021 16:14:03 +0100	[thread overview]
Message-ID: <YXq+O3lJ0hvusG7s@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211028080607.6226a83a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

On Thu, Oct 28, 2021 at 08:06:07AM -0700, Jakub Kicinski wrote:
> On Thu, 28 Oct 2021 15:55:34 +0100 Russell King (Oracle) wrote:
> > mvneta does not support asymetric pause modes, and it flags this by the
> > lack of AsymPause in the supported field. When setting pause modes, we
> > check that pause->rx_pause == pause->tx_pause, but only when pause
> > autoneg is enabled. When pause autoneg is disabled, we still allow
> > pause->rx_pause != pause->tx_pause, which is incorrect when the MAC
> > does not support asymetric pause, and causes mvneta to issue a warning.
> > 
> > Fix this by removing the test for pause->autoneg, so we always check
> > that pause->rx_pause == pause->tx_pause for network devices that do not
> > support AsymPause.
> 
> Fixes..?

If people care...

Fixes: 9525ae83959b ("phylink: add phylink infrastructure")

but since no one reported the issue, I'd be tempted not to backport
the patch until there's a need to do so. Especially as it's going
to have conflicts.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2021-10-28 15:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 14:55 [PATCH net] net: phylink: avoid mvneta warning when setting pause parameters Russell King (Oracle)
2021-10-28 15:06 ` Jakub Kicinski
2021-10-28 15:14   ` Russell King (Oracle) [this message]
2021-10-29 12:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXq+O3lJ0hvusG7s@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.