From: "Jörn Engel" <joern@purestorage.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
davem@davemloft.net, Caleb Sander <csander@purestorage.com>,
netdev@vger.kernel.org, sassmann@redhat.com,
Tony Brelinski <tony.brelinski@intel.com>
Subject: Re: [PATCH net-next 1/4] i40e: avoid spin loop in i40e_asq_send_command()
Date: Thu, 28 Oct 2021 07:44:03 -0700 [thread overview]
Message-ID: <YXq3M5XvOkpMgiOg@cork> (raw)
In-Reply-To: <20211028072607.4db76c84@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, Oct 28, 2021 at 07:26:07AM -0700, Jakub Kicinski wrote:
>
> The status of the command is re-checked after the loop, sleeping too
> long should not cause timeouts here.
Fair point. usleep_range() is likely the correct answer in this case.
Jörn
--
It is the mark of an educated mind to be able to entertain a thought
without accepting it.
-- Aristotle
next prev parent reply other threads:[~2021-10-28 14:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 17:55 [PATCH net-next 0/4][pull request] 40GbE Intel Wired LAN Driver Updates 2021-10-25 Tony Nguyen
2021-10-25 17:55 ` [PATCH net-next 1/4] i40e: avoid spin loop in i40e_asq_send_command() Tony Nguyen
2021-10-27 16:01 ` Jakub Kicinski
2021-10-28 11:49 ` Jörn Engel
2021-10-28 14:26 ` Jakub Kicinski
2021-10-28 14:44 ` Jörn Engel [this message]
2021-11-01 17:38 ` [PATCH v2] " Caleb Sander
2021-11-01 17:38 ` [Intel-wired-lan] " Caleb Sander
2021-10-25 17:55 ` [PATCH net-next 2/4] intel: Simplify bool conversion Tony Nguyen
2021-10-25 17:55 ` [PATCH net-next 3/4] igb: unbreak I2C bit-banging on i350 Tony Nguyen
2021-10-27 16:30 ` Jakub Kicinski
2021-10-28 15:25 ` Nguyen, Anthony L
2021-10-28 15:32 ` Jakub Kicinski
2021-10-25 17:55 ` [PATCH net-next 4/4] net: ixgbevf: Remove redundant initialization of variable ret_val Tony Nguyen
2021-10-27 15:51 ` [PATCH net-next 0/4][pull request] 40GbE Intel Wired LAN Driver Updates 2021-10-25 Nguyen, Anthony L
2021-10-27 15:59 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YXq3M5XvOkpMgiOg@cork \
--to=joern@purestorage.com \
--cc=anthony.l.nguyen@intel.com \
--cc=csander@purestorage.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=tony.brelinski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.