From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6890EC433FE for ; Thu, 28 Oct 2021 15:36:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E36B610C7 for ; Thu, 28 Oct 2021 15:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbhJ1Pif (ORCPT ); Thu, 28 Oct 2021 11:38:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbhJ1Pid (ORCPT ); Thu, 28 Oct 2021 11:38:33 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64878C061570; Thu, 28 Oct 2021 08:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=obEVRh2SUyKsH6wuRZ+MmeBmZXXQKS44Jmrm2Q2wynI=; b=U/Fj/4zSFAfu3ihra5R0kzvttB XGcVAR8aLmLHPrjVzDXTsP7lZZEKYxdFievSQRbR5RMKbt8Yu/ZRuc8yYbAUBEzr/7oTN79aMIKXK rPEXXE09QDGjMZ1BM9zhfBnfKmg8nY00Zqzrm9m6lIDjIyymDCD0q0pwEEukI8ghiWm2zZy/HuIZT boGw9j9RAMlBkz00H0+8QIGhaKxLDDPF2XJildRKicdgzYTY7PXIMkiix1AsCt8eMN4ajOM5gGuEI JCbxWGa6C6y5Y2qPSHILdWzOXHAlaZaxtDy5TB7jIv/SkQFgurik7tg5FNImCmARI0g4Gu3MR5p9r gDq03WsA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55356) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mg7RQ-0007ix-SD; Thu, 28 Oct 2021 16:35:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mg7RM-0000Rz-JC; Thu, 28 Oct 2021 16:35:40 +0100 Date: Thu, 28 Oct 2021 16:35:40 +0100 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Lukas Bulwahn , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Linux ARM , OpenBMC Maillist , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Message-ID: References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > in ./arch/arm/kernel/bios32.c. > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > PCI_HOST_ITE8152 > > Referencing files: arch/arm/kernel/bios32.c > > > > Remove this obsolete ifndef. > > > > Signed-off-by: Lukas Bulwahn > > Reviewed-by: Arnd Bergmann > > I wonder if we should just remove this function and use the > (non-empty) default version instead. > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > introduced that generic version, and I suspect the arm version > was left out by mistake, but it's not clear from that patch. That was because PCI_HOST_ITE8152 needed something different from the "do nothing" default (setting the PCI latency timer to default to 64 as the new generic code did.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44D78C433EF for ; Thu, 28 Oct 2021 15:36:49 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFCBE610C8 for ; Thu, 28 Oct 2021 15:36:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AFCBE610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Hg8mv1b2Gz2yLm for ; Fri, 29 Oct 2021 02:36:47 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.a=rsa-sha256 header.s=pandora-2019 header.b=U/Fj/4zS; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=armlinux.org.uk (client-ip=2001:4d48:ad52:32c8:5054:ff:fe00:142; helo=pandora.armlinux.org.uk; envelope-from=linux+openbmc=lists.ozlabs.org@armlinux.org.uk; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; secure) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.a=rsa-sha256 header.s=pandora-2019 header.b=U/Fj/4zS; dkim-atps=neutral Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hg8m76KRKz2xrC for ; Fri, 29 Oct 2021 02:36:06 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=obEVRh2SUyKsH6wuRZ+MmeBmZXXQKS44Jmrm2Q2wynI=; b=U/Fj/4zSFAfu3ihra5R0kzvttB XGcVAR8aLmLHPrjVzDXTsP7lZZEKYxdFievSQRbR5RMKbt8Yu/ZRuc8yYbAUBEzr/7oTN79aMIKXK rPEXXE09QDGjMZ1BM9zhfBnfKmg8nY00Zqzrm9m6lIDjIyymDCD0q0pwEEukI8ghiWm2zZy/HuIZT boGw9j9RAMlBkz00H0+8QIGhaKxLDDPF2XJildRKicdgzYTY7PXIMkiix1AsCt8eMN4ajOM5gGuEI JCbxWGa6C6y5Y2qPSHILdWzOXHAlaZaxtDy5TB7jIv/SkQFgurik7tg5FNImCmARI0g4Gu3MR5p9r gDq03WsA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55356) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mg7RQ-0007ix-SD; Thu, 28 Oct 2021 16:35:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mg7RM-0000Rz-JC; Thu, 28 Oct 2021 16:35:40 +0100 Date: Thu, 28 Oct 2021 16:35:40 +0100 From: "Russell King (Oracle)" To: Arnd Bergmann Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Message-ID: References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linus Walleij , kernel-janitors@vger.kernel.org, Tomer Maimon , Dinh Nguyen , Avi Fishman , Shawn Guo , Sascha Hauer , OpenBMC Maillist , Sekhar Nori , Linux Kernel Mailing List , Tali Perry , Krzysztof Halasa , Pengutronix Kernel Team , Patrick Venture , Lukas Bulwahn , Imre Kaloz , Fabio Estevam , Bartosz Golaszewski , Linux ARM , Benjamin Fair Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > in ./arch/arm/kernel/bios32.c. > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > PCI_HOST_ITE8152 > > Referencing files: arch/arm/kernel/bios32.c > > > > Remove this obsolete ifndef. > > > > Signed-off-by: Lukas Bulwahn > > Reviewed-by: Arnd Bergmann > > I wonder if we should just remove this function and use the > (non-empty) default version instead. > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > introduced that generic version, and I suspect the arm version > was left out by mistake, but it's not clear from that patch. That was because PCI_HOST_ITE8152 needed something different from the "do nothing" default (setting the PCI latency timer to default to 64 as the new generic code did.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559A9C433F5 for ; Thu, 28 Oct 2021 15:37:28 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E31B60462 for ; Thu, 28 Oct 2021 15:37:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1E31B60462 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q+2rGaUEYVfms5KEPb06JbWZWyidYkafSibR7kufzow=; b=ZzRJO8GcgcItOU dATYr+Lx9MMfnxxC7iUGnUC1ZDo6SLg5OYeqAX9ub50AazzmbfZmeRZQGEc8ENLHgow8gSCxPXMup cYKFLa3ZlW31BmO2oLdb75VFLoEjknp+pVeOuY/BqoHgB8QoH4lLHYKNmdJBe6KwLDK3E1j6tWNtS bfirr2Pnql+apNZSK/SMwDtQNPKwweryvx1J3+PUB+nFYzdf57jxmMguwOJkRedv+VdrtN4ao8BpK J2qRPaAbGXuyGIt0n6xSC1MbdkppXz2RE6r3ZNz7blJMY+LN6UQA3Hm8WqyQJsq9iFzP7jHsqFBWH ilwbOpG264GDXgjAz2Tw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg7Ro-008QFb-Qy; Thu, 28 Oct 2021 15:36:09 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mg7Rl-008QEg-5o for linux-arm-kernel@lists.infradead.org; Thu, 28 Oct 2021 15:36:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=obEVRh2SUyKsH6wuRZ+MmeBmZXXQKS44Jmrm2Q2wynI=; b=U/Fj/4zSFAfu3ihra5R0kzvttB XGcVAR8aLmLHPrjVzDXTsP7lZZEKYxdFievSQRbR5RMKbt8Yu/ZRuc8yYbAUBEzr/7oTN79aMIKXK rPEXXE09QDGjMZ1BM9zhfBnfKmg8nY00Zqzrm9m6lIDjIyymDCD0q0pwEEukI8ghiWm2zZy/HuIZT boGw9j9RAMlBkz00H0+8QIGhaKxLDDPF2XJildRKicdgzYTY7PXIMkiix1AsCt8eMN4ajOM5gGuEI JCbxWGa6C6y5Y2qPSHILdWzOXHAlaZaxtDy5TB7jIv/SkQFgurik7tg5FNImCmARI0g4Gu3MR5p9r gDq03WsA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55356) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mg7RQ-0007ix-SD; Thu, 28 Oct 2021 16:35:44 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mg7RM-0000Rz-JC; Thu, 28 Oct 2021 16:35:40 +0100 Date: Thu, 28 Oct 2021 16:35:40 +0100 From: "Russell King (Oracle)" To: Arnd Bergmann Cc: Lukas Bulwahn , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sekhar Nori , Bartosz Golaszewski , Linus Walleij , Imre Kaloz , Krzysztof Halasa , Avi Fishman , Tomer Maimon , Tali Perry , Patrick Venture , Nancy Yuen , Benjamin Fair , Dinh Nguyen , Linux ARM , OpenBMC Maillist , kernel-janitors@vger.kernel.org, Linux Kernel Mailing List Subject: Re: [PATCH 04/13] arm: drop an obsolete ifdef with the removed config PCI_HOST_ITE8152 Message-ID: References: <20211028141938.3530-1-lukas.bulwahn@gmail.com> <20211028141938.3530-5-lukas.bulwahn@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211028_083605_241236_1592ECD6 X-CRM114-Status: GOOD ( 15.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 04:46:38PM +0200, Arnd Bergmann wrote: > On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn wrote: > > > > Commit 6da5238fa384 ("ARM: 8993/1: remove it8152 PCI controller driver") > > removes the config PCI_HOST_ITE8152, but left a dangling obsolete ifndef > > in ./arch/arm/kernel/bios32.c. > > > > Hence, ./scripts/checkkconfigsymbols.py warns: > > > > PCI_HOST_ITE8152 > > Referencing files: arch/arm/kernel/bios32.c > > > > Remove this obsolete ifndef. > > > > Signed-off-by: Lukas Bulwahn > > Reviewed-by: Arnd Bergmann > > I wonder if we should just remove this function and use the > (non-empty) default version instead. > > 96c5590058d7 ("PCI: Pull PCI 'latency timer' setup up into the core") > introduced that generic version, and I suspect the arm version > was left out by mistake, but it's not clear from that patch. That was because PCI_HOST_ITE8152 needed something different from the "do nothing" default (setting the PCI latency timer to default to 64 as the new generic code did.) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel