All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
	Mark Gross <markgross@kernel.org>,
	Andy Shevchenko <andy@infradead.org>,
	Wolfram Sang <wsa@the-dreams.de>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Daniel Scally <djrscally@gmail.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Len Brown <lenb@kernel.org>,
	linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Kate Hsuan <hpa@redhat.com>,
	linux-media@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v4 04/11] regulator: Introduce tps68470-regulator driver
Date: Thu, 28 Oct 2021 17:23:45 +0100	[thread overview]
Message-ID: <YXrOkeudAzQZezKM@sirena.org.uk> (raw)
In-Reply-To: <20211025094119.82967-5-hdegoede@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On Mon, Oct 25, 2021 at 11:41:12AM +0200, Hans de Goede wrote:
> The TPS68470 PMIC provides Clocks, GPIOs and Regulators. At present in
> the kernel the Regulators and Clocks are controlled by an OpRegion
> driver designed to work with power control methods defined in ACPI, but
> some platforms lack those methods, meaning drivers need to be able to
> consume the resources of these chips through the usual frameworks.

This looks good to me, if you fix the issues Andy raised I think it's
good to go.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-10-28 16:23 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25  9:41 [PATCH v4 00/11] Add support for X86/ACPI camera sensor/PMIC setup with clk and regulator platform data Hans de Goede
2021-10-25  9:41 ` [PATCH v4 01/11] ACPI: delay enumeration of devices with a _DEP pointing to an INT3472 device Hans de Goede
2021-10-27 18:52   ` Rafael J. Wysocki
2021-11-01 11:16     ` Hans de Goede
2021-10-25  9:41 ` [PATCH v4 02/11] i2c: acpi: Use acpi_dev_ready_for_enumeration() helper Hans de Goede
2021-10-27 18:53   ` Rafael J. Wysocki
2021-10-25  9:41 ` [PATCH v4 03/11] platform_data: Add linux/platform_data/tps68470.h file Hans de Goede
2021-10-25  9:41 ` [PATCH v4 04/11] regulator: Introduce tps68470-regulator driver Hans de Goede
2021-10-25 11:11   ` Andy Shevchenko
2021-11-01 10:20     ` Hans de Goede
2021-10-26 12:53   ` kernel test robot
2021-10-26 12:53     ` kernel test robot
2021-10-27  7:41   ` kernel test robot
2021-10-27  7:41     ` kernel test robot
2021-10-28 16:23   ` Mark Brown [this message]
2021-11-09 12:14   ` Sakari Ailus
2021-11-09 12:29     ` Andy Shevchenko
2021-11-11 15:13     ` Hans de Goede
2021-10-25  9:41 ` [PATCH v4 05/11] clk: Introduce clk-tps68470 driver Hans de Goede
2021-10-25 11:24   ` Andy Shevchenko
2021-11-01 10:27     ` Hans de Goede
2021-11-01 10:42       ` Andy Shevchenko
2021-11-01 11:00         ` Hans de Goede
2021-11-01 11:11           ` Andy Shevchenko
2021-10-27 10:23   ` kernel test robot
2021-10-27 10:23     ` kernel test robot
2021-10-25  9:41 ` [PATCH v4 06/11] platform/x86: int3472: Enable I2c daisy chain Hans de Goede
2021-10-25  9:41 ` [PATCH v4 07/11] platform/x86: int3472: Split into 2 drivers Hans de Goede
2021-10-25  9:41 ` [PATCH v4 08/11] platform/x86: int3472: Add get_sensor_adev_and_name() helper Hans de Goede
2021-10-25 11:31   ` Andy Shevchenko
2021-11-01 10:31     ` Hans de Goede
2021-11-01 10:44       ` Andy Shevchenko
2021-11-01 10:46         ` Andy Shevchenko
2021-11-01 10:49           ` Hans de Goede
2021-11-01 10:51             ` Andy Shevchenko
2021-11-01 10:48         ` Hans de Goede
2021-10-25  9:41 ` [PATCH v4 09/11] platform/x86: int3472: Pass tps68470_clk_platform_data to the tps68470-regulator MFD-cell Hans de Goede
2021-10-25 11:33   ` Andy Shevchenko
2021-10-25  9:41 ` [PATCH v4 10/11] platform/x86: int3472: Pass tps68470_regulator_platform_data " Hans de Goede
2021-10-25 11:38   ` Andy Shevchenko
2021-11-01 11:31     ` Hans de Goede
2021-11-01 14:25       ` Andy Shevchenko
2021-10-25  9:41 ` [PATCH v4 11/11] platform/x86: int3472: Deal with probe ordering issues Hans de Goede
2021-10-25 11:40   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YXrOkeudAzQZezKM@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=andy@infradead.org \
    --cc=djrscally@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=hpa@redhat.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=lenb@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mturquette@baylibre.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sboyd@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.