Re: [PATCH] arch/x86/boot/compressed: Remove unneeded whitespaces before tabs

From: Borislav Petkov <bp@alien8.de>
To: Elyes HAOUAS <ehaouas@noos.fr>
Cc: x86@kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arch/x86/boot/compressed: Remove unneeded whitespaces before tabs
Date: Fri, 29 Oct 2021 15:27:14 +0200	[thread overview]
Message-ID: <YXv2slNHl9g0TU87@zn.tnic> (raw)
In-Reply-To: <20211029123952.5207-1-ehaouas@noos.fr>

Hi,

On Fri, Oct 29, 2021 at 02:39:53PM +0200, Elyes HAOUAS wrote:
> Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
> ---
> 
> diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile
> index 431bf7f846c3..e6fae0b6cce8 100644
> --- a/arch/x86/boot/compressed/Makefile
> +++ b/arch/x86/boot/compressed/Makefile
> @@ -139,8 +139,8 @@ suffix-$(CONFIG_KERNEL_GZIP)	:= gz
>  suffix-$(CONFIG_KERNEL_BZIP2)	:= bz2
>  suffix-$(CONFIG_KERNEL_LZMA)	:= lzma
>  suffix-$(CONFIG_KERNEL_XZ)	:= xz
> -suffix-$(CONFIG_KERNEL_LZO) 	:= lzo
> -suffix-$(CONFIG_KERNEL_LZ4) 	:= lz4
> +suffix-$(CONFIG_KERNEL_LZO)	:= lzo
> +suffix-$(CONFIG_KERNEL_LZ4)	:= lz4
>  suffix-$(CONFIG_KERNEL_ZSTD)	:= zst
>  
>  quiet_cmd_mkpiggy = MKPIGGY $@
> diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S
> index 112b2375d021..d97d255b1103 100644
> --- a/arch/x86/boot/compressed/vmlinux.lds.S
> +++ b/arch/x86/boot/compressed/vmlinux.lds.S
> @@ -31,7 +31,7 @@ SECTIONS
>  		*(.rodata..compressed)
>  	}
>  	.text :	{
> -		_text = .; 	/* Text */
> +		_text = .;	/* Text */
>  		*(.text)
>  		*(.text.*)
>  		_etext = . ;
> -- 

a couple of things:

1. When sending patches, always run them through checkpatch before that
- some of the warnings make sense:

./scripts/checkpatch.pl /tmp/ehaouas.01
WARNING: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 18 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/tmp/ehaouas.01 has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

2. When submitting patches, always make sure you CC lkml like I've done.

3. I took your whitespace cleanup patch because you seemed new and I
thought you'd like to get your feet wet.

But, that doesn't mean that I would like to see more whitespace
cleanup patches. They get in the way when one does git archeology and
tries to find which patch changed which line. IOW, if you want to
learn more about hacking the kernel, I'd suggest you start reading
Documentation/process/ on how the collaboration process looks like.

Then, you can start testing the kernel on your machines and see if all
works.

If there's a bug, you can try to report it - that's also explained
there.

And then you can do some further reading on how to get involved by
searching the net:

https://duckduckgo.com/?q=getting+involved+with+kernel+development&ia=web

Doing those things is a lot more beneficial than doing whitespace
cleanup patches.

If you have questions along the way, feel free to ask them.

HTH.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette