From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E920CC433EF for ; Fri, 29 Oct 2021 18:06:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF327610E8 for ; Fri, 29 Oct 2021 18:06:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbhJ2SJA (ORCPT ); Fri, 29 Oct 2021 14:09:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:35642 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbhJ2SI5 (ORCPT ); Fri, 29 Oct 2021 14:08:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1518860FC3; Fri, 29 Oct 2021 18:06:26 +0000 (UTC) Date: Fri, 29 Oct 2021 19:06:23 +0100 From: Catalin Marinas To: Suzuki K Poulose Cc: Arnd Bergmann , Will Deacon , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > On 29/10/2021 12:30, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > It's now used in a coresight driver that can be a loadable module: > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > Reviewed-by: Suzuki K Poulose > Tested-by: Suzuki K Poulose > > Will, Catalin, Mathieu, > > Do you have a preference on how this fix can be pulled in ? This may > be safe to go via coresight tree if it is not too late. Otherwise, > it could go via the arm64 tree. I think Will already closed/tagged the arm64 tree for the upcoming merging window, though he could take it as a fix afterwards. If it doesn't conflict with the arm64 for-next/core, it's fine by me to go through the coresight tree. > > Signed-off-by: Arnd Bergmann > > --- > > Not sure if we actually want this to be exported, this is my local > > workaround for the randconfig build bot. > > --- > > arch/arm64/kernel/cpufeature.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index ecbdff795f5e..beccbcfa7391 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > return false; > > } > > +EXPORT_SYMBOL(this_cpu_has_cap); EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more specialised than cpus_have_const_cap(). With that: Acked-by: Catalin Marinas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ABCCC433EF for ; Fri, 29 Oct 2021 19:28:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFF3960D07 for ; Fri, 29 Oct 2021 19:28:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EFF3960D07 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TTwBfTFvETY7S51pAXSefnfu3PR0KPprdpqHkZ0w4fE=; b=dY4fp3SF0w9ByB Gb6yxD3+1p5GqZRd1GAzOjt0TiG/Sy9qqcFJi6f1t0zyeeOVoingQ6HSzjJWYMa4sCMbiT+KgJFQP wzj+kUTllYFnRr5EE+77jSX4KFG1Tbwd6/IX4yMV7OBZ64KQ3NqKyrI0A+eQULeA4o9SLKKVe7QjR 1D25KY9xBNbAogZWYRMA6vPRL6FlbqM/bOUdJigHKRz8KqoZrldcSSEWXAw2IhNFzg9gqIw5cvyYB uDpzFv97m/IdzocHE4YKoe+DrJLprvw9jHxmgtd+42wrpO7Q+AVg0SGq5KVDAdJV25WCQCGkkRYxZ EaNKiDesij9MT7yPkzbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgXW1-00BywR-7G; Fri, 29 Oct 2021 19:26:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgWGr-00Big8-EX for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 18:06:30 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1518860FC3; Fri, 29 Oct 2021 18:06:26 +0000 (UTC) Date: Fri, 29 Oct 2021 19:06:23 +0100 From: Catalin Marinas To: Suzuki K Poulose Cc: Arnd Bergmann , Will Deacon , Mathieu Poirier , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap Message-ID: References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_110629_556404_3FFEB976 X-CRM114-Status: GOOD ( 22.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > On 29/10/2021 12:30, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > It's now used in a coresight driver that can be a loadable module: > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > Reviewed-by: Suzuki K Poulose > Tested-by: Suzuki K Poulose > > Will, Catalin, Mathieu, > > Do you have a preference on how this fix can be pulled in ? This may > be safe to go via coresight tree if it is not too late. Otherwise, > it could go via the arm64 tree. I think Will already closed/tagged the arm64 tree for the upcoming merging window, though he could take it as a fix afterwards. If it doesn't conflict with the arm64 for-next/core, it's fine by me to go through the coresight tree. > > Signed-off-by: Arnd Bergmann > > --- > > Not sure if we actually want this to be exported, this is my local > > workaround for the randconfig build bot. > > --- > > arch/arm64/kernel/cpufeature.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index ecbdff795f5e..beccbcfa7391 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > return false; > > } > > +EXPORT_SYMBOL(this_cpu_has_cap); EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more specialised than cpus_have_const_cap(). With that: Acked-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel