All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Wildt <patrick@blueri.se>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: sbabic@denx.de, festevam@gmail.com, u-boot@lists.denx.de,
	uboot-imx@nxp.com, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH V3 2/5] imx: imx8mq_phanbell: switch to binman
Date: Thu, 11 Nov 2021 15:45:44 +0100	[thread overview]
Message-ID: <YY0smNQuCLNjGjPW@lx2k.blueri.se> (raw)
In-Reply-To: <20211022024220.23584-3-peng.fan@oss.nxp.com>

On Fri, Oct 22, 2021 at 10:42:17AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Switch to binman to pack images

Reviewed-by: Patrick Wildt <patrick@blueri.se>

> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/dts/imx8mq-phanbell-u-boot.dtsi  |  2 ++
>  arch/arm/mach-imx/imx8m/Kconfig           |  7 ++++---
>  board/google/imx8mq_phanbell/Kconfig      |  2 +-
>  board/google/imx8mq_phanbell/imximage.cfg | 11 +++++++++++
>  configs/imx8mq_phanbell_defconfig         |  2 +-
>  5 files changed, 19 insertions(+), 5 deletions(-)
>  create mode 100644 board/google/imx8mq_phanbell/imximage.cfg
> 
> diff --git a/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi b/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi
> index 4712cf6a44..a65a942ee7 100644
> --- a/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi
> +++ b/arch/arm/dts/imx8mq-phanbell-u-boot.dtsi
> @@ -1,5 +1,7 @@
>  // SPDX-License-Identifier: (GPL-2.0 OR MIT)
>  
> +#include "imx8mq-u-boot.dtsi"
> +
>  &reg_usdhc2_vmmc {
>  	u-boot,off-on-delay-us = <20000>;
>  };
> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
> index c556e712b7..b453e5a7da 100644
> --- a/arch/arm/mach-imx/imx8m/Kconfig
> +++ b/arch/arm/mach-imx/imx8m/Kconfig
> @@ -41,9 +41,10 @@ config TARGET_IMX8MQ_EVK
>  	select IMX8M_LPDDR4
>  
>  config TARGET_IMX8MQ_PHANBELL
> -        bool "imx8mq_phanbell"
> -        select IMX8MQ
> -        select IMX8M_LPDDR4
> +	bool "imx8mq_phanbell"
> +	select BINMAN
> +	select IMX8MQ
> +	select IMX8M_LPDDR4
>  
>  config TARGET_IMX8MM_EVK
>  	bool "imx8mm LPDDR4 EVK board"
> diff --git a/board/google/imx8mq_phanbell/Kconfig b/board/google/imx8mq_phanbell/Kconfig
> index 54cfb99952..e59b03cb17 100644
> --- a/board/google/imx8mq_phanbell/Kconfig
> +++ b/board/google/imx8mq_phanbell/Kconfig
> @@ -10,6 +10,6 @@ config SYS_CONFIG_NAME
>  	default "imx8mq_phanbell"
>  
>  config IMX_CONFIG
> -	default "arch/arm/mach-imx/imx8m/imximage.cfg"
> +	default "board/google/imx8mq_phanbell/imximage.cfg"
>  
>  endif
> diff --git a/board/google/imx8mq_phanbell/imximage.cfg b/board/google/imx8mq_phanbell/imximage.cfg
> new file mode 100644
> index 0000000000..74f12b30d2
> --- /dev/null
> +++ b/board/google/imx8mq_phanbell/imximage.cfg
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * Copyright 2021 NXP
> + */
> +
> +#define __ASSEMBLY__
> +
> +FIT
> +BOOT_FROM	sd
> +SIGNED_HDMI	signed_hdmi.bin
> +LOADER		mkimage.flash.mkimage	0x7e1000
> diff --git a/configs/imx8mq_phanbell_defconfig b/configs/imx8mq_phanbell_defconfig
> index 911c3391db..a8eab85b4a 100644
> --- a/configs/imx8mq_phanbell_defconfig
> +++ b/configs/imx8mq_phanbell_defconfig
> @@ -18,7 +18,7 @@ CONFIG_SYS_LOAD_ADDR=0x40480000
>  CONFIG_FIT=y
>  CONFIG_FIT_EXTERNAL_OFFSET=0x3000
>  CONFIG_SPL_LOAD_FIT=y
> -CONFIG_SPL_FIT_GENERATOR="arch/arm/mach-imx/mkimage_fit_atf.sh"
> +# CONFIG_USE_SPL_FIT_GENERATOR is not set
>  CONFIG_SD_BOOT=y
>  CONFIG_BOARD_EARLY_INIT_F=y
>  CONFIG_SPL_BOARD_INIT=y
> -- 
> 2.30.0
> 

  reply	other threads:[~2021-11-11 14:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22  2:42 [PATCH V3 0/5] imx8mq: switch to binman Peng Fan (OSS)
2021-10-22  2:42 ` [PATCH V3 1/5] imx: imx8mq_evk: " Peng Fan (OSS)
2021-11-11 14:41   ` Patrick Wildt
2021-11-22  8:58     ` Peng Fan (OSS)
2021-11-11 17:24   ` Heiko Thiery
2021-11-22  8:59     ` Peng Fan (OSS)
2022-01-08  2:08   ` Tom Rini
2021-10-22  2:42 ` [PATCH V3 2/5] imx: imx8mq_phanbell: " Peng Fan (OSS)
2021-11-11 14:45   ` Patrick Wildt [this message]
2022-01-08  2:08   ` Tom Rini
2021-10-22  2:42 ` [PATCH V3 3/5] imx: pico-imx8mq: switch to use binman Peng Fan (OSS)
2021-11-11 14:46   ` Patrick Wildt
2022-01-08  2:08   ` Tom Rini
2021-10-22  2:42 ` [PATCH V3 4/5] imx: imx8mq use common imximage.cfg Peng Fan (OSS)
2021-11-11 14:46   ` Patrick Wildt
2021-11-11 17:21   ` Heiko Thiery
2021-11-22  8:56     ` Peng Fan (OSS)
2022-01-08  2:08   ` Tom Rini
2021-10-22  2:42 ` [PATCH V3 5/5] doc: imx8mq_evk: update doc after using binman Peng Fan (OSS)
2021-11-11 14:47   ` Patrick Wildt
2022-01-08  2:08   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YY0smNQuCLNjGjPW@lx2k.blueri.se \
    --to=patrick@blueri.se \
    --cc=festevam@gmail.com \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.