From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21FD5C433FE for ; Fri, 12 Nov 2021 19:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0585261057 for ; Fri, 12 Nov 2021 19:38:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232555AbhKLTlr (ORCPT ); Fri, 12 Nov 2021 14:41:47 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:46910 "EHLO mail-oi1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230101AbhKLTlq (ORCPT ); Fri, 12 Nov 2021 14:41:46 -0500 Received: by mail-oi1-f176.google.com with SMTP id s139so19714934oie.13; Fri, 12 Nov 2021 11:38:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qAZHfyWnmCfvgr8D21qxD2guTWMUKbQ6N/3+eAIuaOs=; b=728Yq4T9xyYY5jlbzwoLctix/Nw5lPn+Lm4qFzMGHMaXVnGks0q3btWI3j9iOCCk/8 GVrTh40T3WwQpQBtaxZQBTm2568loEVX2gFswf7wbPKyybYJmJM/tL5BQXlnZxXpP8MH Us/YPysX3cX3IAneGDIjpHxtlKcyJ56re1sCGrQGdQVlLwfprvfFvXy7o/Q//xyTurC6 pQzl8k8b56HZbx22pKhg4nHAor/tI8HYXr9YqBXvFOMou8TrmCf5Y18mYlI8XZXczROr 7EJX1QDJmXb96QwFjnejFaiANz06pSuh+wn5GTVI6OgX0nBa/UvvoHVR8ygiAq3nQbGF Oo/w== X-Gm-Message-State: AOAM533pNXl90dN2bU+pjjs0nu4m9w7bIirta0h32SzwnnmdjBtNICgy Qe0j0wyLsR1wAHQKDwAUVA== X-Google-Smtp-Source: ABdhPJwaYFhUy+7cFhoLxnliRVH2YXrCxGg4o8dXc1XtfE0fFoDJbIfDC41E6PUkLRkqvnn2hdql/A== X-Received: by 2002:a05:6808:120e:: with SMTP id a14mr15682125oil.63.1636745935365; Fri, 12 Nov 2021 11:38:55 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e28sm1559665oiy.10.2021.11.12.11.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 11:38:54 -0800 (PST) Received: (nullmailer pid 3239457 invoked by uid 1000); Fri, 12 Nov 2021 19:38:53 -0000 Date: Fri, 12 Nov 2021 13:38:53 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Lee Jones , Wim Van Sebroeck , Guenter Roeck , Florian Fainelli , Justin Chen , bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 2/2] dt-bindings: mfd: add Broadcom's Timer-Watchdog block Message-ID: References: <20211102160615.14672-1-zajec5@gmail.com> <20211102160615.14672-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20211102160615.14672-2-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 02, 2021 at 05:06:15PM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > It's a block implementing few time related functions depending on a > (SoC specific) variant. At this point there is ready binding for a > watchdog only. Work on remaining subblocks (e.g. "reg" based reboot) is > in progress. > > Signed-off-by: Rafał Miłecki > --- > V2: Update $id, description, compatible, example & commit message > --- > .../devicetree/bindings/mfd/brcm,twd.yaml | 62 +++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/brcm,twd.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/brcm,twd.yaml b/Documentation/devicetree/bindings/mfd/brcm,twd.yaml > new file mode 100644 > index 000000000000..ed167055be06 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/brcm,twd.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/brcm,twd.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Broadcom's Timer-Watchdog (aka TWD) > + > +maintainers: > + - Rafał Miłecki > + > +description: | > + Broadcom has a Timer-Watchdog block used in multiple SoCs (e.g., BCM4908, > + BCM63xx, BCM7038). There are few variants available (they differ slightly in > + registers layout). This block consists of: timers, watchdog and optionally a > + software reset handler. > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,bcm4908-twd > + - brcm,bcm7038-twd > + - const: brcm,twd I don't think you need this given you don't expect to have a driver for this other than syscon driver. > + - const: simple-mfd > + - const: syscon > + > + reg: > + maxItems: 1 > + > + ranges: true > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + '^watchdog@[a-f0-9]+$': > + $ref: /schemas/watchdog/brcm,bcm7038-wdt.yaml > + > +additionalProperties: false > + > +required: > + - reg > + > +examples: > + - | > + timer-mfd@ff800400 { > + compatible = "brcm,bcm4908-twd", "brcm,twd", "simple-mfd", "syscon"; > + reg = <0xff800400 0x4c>; > + ranges = <0x00000000 0xff800400 0x4c>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + watchdog@28 { > + compatible = "brcm,bcm7038-wdt"; > + reg = <0x28 0x8>; > + }; > + }; > -- > 2.31.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6986AC433EF for ; Fri, 12 Nov 2021 19:40:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C4EA60EE9 for ; Fri, 12 Nov 2021 19:40:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2C4EA60EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bp8yHyealg6NjUI2qyksvg2+SWCfkIuIXi6BHcx5+KE=; b=clq/W5MCoi3BzU Wh+uEqVpjBeBaTQ53OYnMMqsdm2EBastaWcaZH91AImnfkZMrtKyx+pEc4d9ODq/eHkjJNIf28gpU TGf9BnRFGX0UB6uGA2ZDOQH0ujsCRCQNrzbYUwaOuY/0tEh4fw5+PnbDhtoW21u4W74SGQMUdIa41 lSmVKZkQ5KD3AykNzewUb6Xe8m794gemopiBGX7FFB92mSQgQ0g4lHj0pZgUwHxp4lq6nU1uHlUjh h7F38b/vK/onGLIayr2ies/I6Xe2lenawJZh3sTUJ/mVdBDSS6Vclg7q6PbwVYYvi/VZ1qmjdbF3p ZarsRo+XeJpMYNsfQ9JA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlcO5-00BU5X-9x; Fri, 12 Nov 2021 19:39:01 +0000 Received: from mail-oi1-f178.google.com ([209.85.167.178]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlcO0-00BU58-Dm for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 19:38:57 +0000 Received: by mail-oi1-f178.google.com with SMTP id t19so19869149oij.1 for ; Fri, 12 Nov 2021 11:38:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=qAZHfyWnmCfvgr8D21qxD2guTWMUKbQ6N/3+eAIuaOs=; b=CYisiP8GOZHgTSuLSZxLt+HNortbhKKl/P5SRsQSXCl8FRSgcDs3l/cvzK93IatsnV oC0FQagbTWg9KMol0atiim651AGYxK7+T0GXZLPu84H1gb6UHpmEL7Acyux3K3OobD47 HyyWh9DG2wFvisSGHUSmy3bV8TqjEu0K38JFevR6ZTkXJqvyWHNRfZMLXGDuBE3MPSrZ 7X32l66Ta767S51r9lN9G9QOay4MQpQq2uptpfUR57eTxn2+oWAHPktF931sBakGXhTh 8dFIEGXZQqRCkSFh1M565C4ZnZQ9PPYw5bnAj74xf5PQv4rhb+rLuEdyM/jmmh1SZ3Y1 uQ+w== X-Gm-Message-State: AOAM531najGCsWpZxSVvs7GA/UzOJdxOYrVedpuwNzFl6OgcGLBmzMuJ vUxGgxcND06rmRUoHA1I4w== X-Google-Smtp-Source: ABdhPJwaYFhUy+7cFhoLxnliRVH2YXrCxGg4o8dXc1XtfE0fFoDJbIfDC41E6PUkLRkqvnn2hdql/A== X-Received: by 2002:a05:6808:120e:: with SMTP id a14mr15682125oil.63.1636745935365; Fri, 12 Nov 2021 11:38:55 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e28sm1559665oiy.10.2021.11.12.11.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 11:38:54 -0800 (PST) Received: (nullmailer pid 3239457 invoked by uid 1000); Fri, 12 Nov 2021 19:38:53 -0000 Date: Fri, 12 Nov 2021 13:38:53 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Lee Jones , Wim Van Sebroeck , Guenter Roeck , Florian Fainelli , Justin Chen , bcm-kernel-feedback-list@broadcom.com, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 2/2] dt-bindings: mfd: add Broadcom's Timer-Watchdog block Message-ID: References: <20211102160615.14672-1-zajec5@gmail.com> <20211102160615.14672-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211102160615.14672-2-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211112_113856_512490_F056EC43 X-CRM114-Status: GOOD ( 20.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBOb3YgMDIsIDIwMjEgYXQgMDU6MDY6MTVQTSArMDEwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBJ dCdzIGEgYmxvY2sgaW1wbGVtZW50aW5nIGZldyB0aW1lIHJlbGF0ZWQgZnVuY3Rpb25zIGRlcGVu ZGluZyBvbiBhCj4gKFNvQyBzcGVjaWZpYykgdmFyaWFudC4gQXQgdGhpcyBwb2ludCB0aGVyZSBp cyByZWFkeSBiaW5kaW5nIGZvciBhCj4gd2F0Y2hkb2cgb25seS4gV29yayBvbiByZW1haW5pbmcg c3ViYmxvY2tzIChlLmcuICJyZWciIGJhc2VkIHJlYm9vdCkgaXMKPiBpbiBwcm9ncmVzcy4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBSYWZhxYIgTWnFgmVja2kgPHJhZmFsQG1pbGVja2kucGw+Cj4gLS0t Cj4gVjI6IFVwZGF0ZSAkaWQsIGRlc2NyaXB0aW9uLCBjb21wYXRpYmxlLCBleGFtcGxlICYgY29t bWl0IG1lc3NhZ2UKPiAtLS0KPiAgLi4uL2RldmljZXRyZWUvYmluZGluZ3MvbWZkL2JyY20sdHdk LnlhbWwgICAgIHwgNjIgKysrKysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgNjIg aW5zZXJ0aW9ucygrKQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0 cmVlL2JpbmRpbmdzL21mZC9icmNtLHR3ZC55YW1sCj4gCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYnJjbSx0d2QueWFtbCBiL0RvY3VtZW50YXRp b24vZGV2aWNldHJlZS9iaW5kaW5ncy9tZmQvYnJjbSx0d2QueWFtbAo+IG5ldyBmaWxlIG1vZGUg MTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwLi5lZDE2NzA1NWJlMDYKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9icmNtLHR3ZC55 YW1sCj4gQEAgLTAsMCArMSw2MiBAQAo+ICsjIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwt Mi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlCj4gKyVZQU1MIDEuMgo+ICstLS0KPiArJGlkOiBodHRw Oi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9tZmQvYnJjbSx0d2QueWFtbCMKPiArJHNjaGVtYTog aHR0cDovL2RldmljZXRyZWUub3JnL21ldGEtc2NoZW1hcy9jb3JlLnlhbWwjCj4gKwo+ICt0aXRs ZTogQnJvYWRjb20ncyBUaW1lci1XYXRjaGRvZyAoYWthIFRXRCkKPiArCj4gK21haW50YWluZXJz Ogo+ICsgIC0gUmFmYcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+ICsKPiArZGVzY3Jp cHRpb246IHwKPiArICBCcm9hZGNvbSBoYXMgYSBUaW1lci1XYXRjaGRvZyBibG9jayB1c2VkIGlu IG11bHRpcGxlIFNvQ3MgKGUuZy4sIEJDTTQ5MDgsCj4gKyAgQkNNNjN4eCwgQkNNNzAzOCkuIFRo ZXJlIGFyZSBmZXcgdmFyaWFudHMgYXZhaWxhYmxlICh0aGV5IGRpZmZlciBzbGlnaHRseSBpbgo+ ICsgIHJlZ2lzdGVycyBsYXlvdXQpLiBUaGlzIGJsb2NrIGNvbnNpc3RzIG9mOiB0aW1lcnMsIHdh dGNoZG9nIGFuZCBvcHRpb25hbGx5IGEKPiArICBzb2Z0d2FyZSByZXNldCBoYW5kbGVyLgo+ICsK PiArcHJvcGVydGllczoKPiArICBjb21wYXRpYmxlOgo+ICsgICAgaXRlbXM6Cj4gKyAgICAgIC0g ZW51bToKPiArICAgICAgICAtIGJyY20sYmNtNDkwOC10d2QKPiArICAgICAgICAtIGJyY20sYmNt NzAzOC10d2QKPiArICAgICAgLSBjb25zdDogYnJjbSx0d2QKCkkgZG9uJ3QgdGhpbmsgeW91IG5l ZWQgdGhpcyBnaXZlbiB5b3UgZG9uJ3QgZXhwZWN0IHRvIGhhdmUgYSBkcml2ZXIgZm9yIAp0aGlz IG90aGVyIHRoYW4gc3lzY29uIGRyaXZlci4KCj4gKyAgICAgIC0gY29uc3Q6IHNpbXBsZS1tZmQK PiArICAgICAgLSBjb25zdDogc3lzY29uCj4gKwo+ICsgIHJlZzoKPiArICAgIG1heEl0ZW1zOiAx Cj4gKwo+ICsgIHJhbmdlczogdHJ1ZQo+ICsKPiArICAiI2FkZHJlc3MtY2VsbHMiOgo+ICsgICAg Y29uc3Q6IDEKPiArCj4gKyAgIiNzaXplLWNlbGxzIjoKPiArICAgIGNvbnN0OiAxCj4gKwo+ICtw YXR0ZXJuUHJvcGVydGllczoKPiArICAnXndhdGNoZG9nQFthLWYwLTldKyQnOgo+ICsgICAgJHJl ZjogL3NjaGVtYXMvd2F0Y2hkb2cvYnJjbSxiY203MDM4LXdkdC55YW1sCj4gKwo+ICthZGRpdGlv bmFsUHJvcGVydGllczogZmFsc2UKPiArCj4gK3JlcXVpcmVkOgo+ICsgIC0gcmVnCj4gKwo+ICtl eGFtcGxlczoKPiArICAtIHwKPiArICAgIHRpbWVyLW1mZEBmZjgwMDQwMCB7Cj4gKyAgICAgICAg Y29tcGF0aWJsZSA9ICJicmNtLGJjbTQ5MDgtdHdkIiwgImJyY20sdHdkIiwgInNpbXBsZS1tZmQi LCAic3lzY29uIjsKPiArICAgICAgICByZWcgPSA8MHhmZjgwMDQwMCAweDRjPjsKPiArICAgICAg ICByYW5nZXMgPSA8MHgwMDAwMDAwMCAweGZmODAwNDAwIDB4NGM+Owo+ICsKPiArICAgICAgICAj YWRkcmVzcy1jZWxscyA9IDwxPjsKPiArICAgICAgICAjc2l6ZS1jZWxscyA9IDwxPjsKPiArCj4g KyAgICAgICAgd2F0Y2hkb2dAMjggewo+ICsgICAgICAgICAgICBjb21wYXRpYmxlID0gImJyY20s YmNtNzAzOC13ZHQiOwo+ICsgICAgICAgICAgICByZWcgPSA8MHgyOCAweDg+Owo+ICsgICAgICAg IH07Cj4gKyAgICB9Owo+IC0tIAo+IDIuMzEuMQo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=