From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF7F468 for ; Mon, 1 Nov 2021 16:21:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Jb2ieF+UJCAXaI4awu80SUFZWF1CkD+S/ZJK/qbpHthY8oUap767smt5XzxZrVboica49v Gc/NLA+cN/NPFJyzzwDixs9cL1vW5tpevJ1qXmdcl2xVTclP6wi6hIsKzEOnYopmlUHAik 6/rk9NCN9qyolMzY00bExSCWPb1mljU= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-314-zQgG6L0cPpy5-FmDIwf7GA-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: zQgG6L0cPpy5-FmDIwf7GA-1 Received: by mail-qt1-f200.google.com with SMTP id z17-20020a05622a029100b002a824f0a71bso12383889qtw.17 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=o08QTO3Pak/b5U5ujzptRsNuX5RfvZpkqPGE50AfhBHhpjIqeHgAFBh/rTo8+Ec46e bzE7NDMBfpickDMXe/A+4XLf8N3wfF8UDYZTfRZEloIyaF27JA+mvDpLjWA6yItJ0DJc aDYJnBoJGStUDI+VaaL2b4D7MNsZYubgVVkOsG2lxlYZDDBqXr72RlnKFjWcVvN7AgmG 2++GvlrOTaUlxWQ+9V83pzbA6VbvNhIxkfj0Fcue1TWP8nwU2I56DAU1FbAl/hBVfEat TBGvXtfO8ragMPPKwFRQAqCia98FFKpR1/coMM9DNHh01XPxXyNKd3wRNioty8YdFgxi kKNQ== X-Gm-Message-State: AOAM5331lhYOz7i2Q2R2+XsNP0dkBTwuImqKnDAGHYwe12wavi4lCTjs nLGPY8hZVjFWjnUdlyPXBz6Oh4pzhcAt1WvvcoCVAuuyUQtxU+efbc6jjjbSHZbNpBrfNHqzki4 I8CKGQMyfVL61eMc= X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472033qtb.183.1635783688230; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Cc: Christoph Hellwig , Ira Weiny , device-mapper development , linux-xfs , Linux NVDIMM , linux-s390 , linux-fsdevel , linux-erofs@lists.ozlabs.org, linux-ext4 , virtualization@lists.linux-foundation.org Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 675B3C433EF for ; Mon, 1 Nov 2021 16:21:35 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FD1361165 for ; Mon, 1 Nov 2021 16:21:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FD1361165 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id E27D780C6D; Mon, 1 Nov 2021 16:21:34 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id c8Bt4GGwFnHv; Mon, 1 Nov 2021 16:21:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id A7DC180C43; Mon, 1 Nov 2021 16:21:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 813AFC001E; Mon, 1 Nov 2021 16:21:33 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id 91DEEC000E for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 7382A80C7E for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NvlJu4MXAbAN for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id DA99080C43 for ; Mon, 1 Nov 2021 16:21:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783690; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=g4IfObkWcAJ4mvs2ONiuidAZEUQaazQjSNNGt8XybxZMaR43u+xuMeCJYHlhIKnnq77A5w MEX43WJiPTdk3PwDDLmghGTPtNAolYml7lStetlnKRDPVXEFQ8UY+YVQ1LYQskZpB3oGgJ 0d10ClBng5lXnwOVzd3jOk460xZ2GP8= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-604-TcJVN5j3P3G6fgj8qYJNxw-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: TcJVN5j3P3G6fgj8qYJNxw-1 Received: by mail-qv1-f71.google.com with SMTP id z8-20020a0cd788000000b00384d92a0f11so16739476qvi.17 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=BwjIv2bz4+m8CgKS6f0rOl5F15+SSNHcwAiKfFH5P//Guwlu2WZ86FxllvG5pjYcG6 FCW4l5gvzaconWOJM3OBP8vGpV6A0dsUBMntXmei+AykiW/FqzN17ZpCArAzieQeneRD E3HH5VF2R+pMyfhqZ4ZjPZcI602uIK3a+jGNnPIWU6UnH+JtQ99Dow71c7btWg9MdZZS JrX+6vpHMSVPuG0mz3xt7odWgAc9z/LSVe1babJGaYIyWUW7f2remhsDOYxaPDaKToss gLg+lIN3catcCt932vokSV2cNt8LYoVGg3fkRXtQHEFpKnjhAXmq64zR6dUsFijGc5SW 75FA== X-Gm-Message-State: AOAM531d/bJg1yxGe20smI+TA6HtGIsf4DyblaahVfVwJUbWp9bKL6Xx K1lPNvwD3pNucUmK8fTci8nJaHBEnd+nv8tae/Bnd3KlWaj7UE132M5bYSzCAgpobKiIhRSsQtt 7Lusq/naAd+h/UkF0tdlxlKnK2v7eweHyQsnJK97C X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472041qtb.183.1635783688259; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Linux NVDIMM , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95132C433F5 for ; Mon, 1 Nov 2021 16:21:38 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D92136113D for ; Mon, 1 Nov 2021 16:21:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D92136113D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HjdZm3YQ8z2yJP for ; Tue, 2 Nov 2021 03:21:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=redhat.com (client-ip=170.10.133.124; helo=us-smtp-delivery-124.mimecast.com; envelope-from=snitzer@redhat.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Jb2ieF+U; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HjdZh2Q35z2xRn for ; Tue, 2 Nov 2021 03:21:32 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Jb2ieF+UJCAXaI4awu80SUFZWF1CkD+S/ZJK/qbpHthY8oUap767smt5XzxZrVboica49v Gc/NLA+cN/NPFJyzzwDixs9cL1vW5tpevJ1qXmdcl2xVTclP6wi6hIsKzEOnYopmlUHAik 6/rk9NCN9qyolMzY00bExSCWPb1mljU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635783689; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Jb2ieF+UJCAXaI4awu80SUFZWF1CkD+S/ZJK/qbpHthY8oUap767smt5XzxZrVboica49v Gc/NLA+cN/NPFJyzzwDixs9cL1vW5tpevJ1qXmdcl2xVTclP6wi6hIsKzEOnYopmlUHAik 6/rk9NCN9qyolMzY00bExSCWPb1mljU= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-316-j19-GSIJN0GraIHtYWhPlg-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: j19-GSIJN0GraIHtYWhPlg-1 Received: by mail-qv1-f72.google.com with SMTP id jo4-20020a056214500400b003a5cb094fb8so6090430qvb.22 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=uWYbMxA05mPQyY6FMlGAnRvZ2QlPTvP540VhHgyY3MdevtkUgyc9nXXjKhFlgal2TD abyFG6k5PfxHjQdDbmHtKL8A70mfoAMKAI8arwxv2X+l80qkcaZPXyrvQ0OSkPsMWAwz /CJTtsKNHFWGZCXov9A5q9D0iv8OvKbldpbn+yFP8FNvwa66vrnUcZ1s31/dbKk5f1bb n+HHREl5DnJvFCa0GzZEY49uVXnBx+F7TK5vqgipdfBF4GzEz84fenpU5eBHrbiATr6T tKHLX6BSR+zxdUyvl0Dz4ULjOL7bcM8di+pXriVBuamsO+LIrDLTU1SDhXbjyxRWImVi kkkA== X-Gm-Message-State: AOAM532pvVJsnEjc4zU2Gq4xg1WtrzcZH7KmhhVrOqKiMQF35v4U7hfT EEq3tSWbGEe3wcMwA92/Te7Vl8UmkewfMmUHp+wZCrue+KMgLGu7XT5k/y4pFzznUBjDI6EXf53 q5adNtJXK2+NKS3R85dHFw7Q= X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472029qtb.183.1635783688228; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Subject: Re: [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=snitzer@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux NVDIMM , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23500C433F5 for ; Mon, 1 Nov 2021 16:26:59 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A90361184 for ; Mon, 1 Nov 2021 16:26:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7A90361184 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635784017; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9/4Hh52HiMnJWzdRvNzCM1gMyWMXGRWBnmHLpa8a5O0=; b=VfekPdVSSQyGQQRLPb8IYPNPOFkH9jOwO/v5BoiwxkUooYu2pbAIpDTWb0y4poIY0h4t7G 2eEN8eR3kKbDPXOT66iOEWdqeMBRavX76K+zRGeaqVofUm3P7MrDSeA/6vsj1mZKqZN/wv XOrRXbyx9WW0dAz98jzyTroIpOvB2+U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-M_eKmUKvP4O_0WKcXlIiVw-1; Mon, 01 Nov 2021 12:26:53 -0400 X-MC-Unique: M_eKmUKvP4O_0WKcXlIiVw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E9D110A8E03; Mon, 1 Nov 2021 16:26:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EFA1678323; Mon, 1 Nov 2021 16:26:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8E9681809C81; Mon, 1 Nov 2021 16:26:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1A1GLY5T003541 for ; Mon, 1 Nov 2021 12:21:35 -0400 Received: by smtp.corp.redhat.com (Postfix) id CB5782166B26; Mon, 1 Nov 2021 16:21:34 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C66122166B25 for ; Mon, 1 Nov 2021 16:21:32 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E7A5C899EE2 for ; Mon, 1 Nov 2021 16:21:31 +0000 (UTC) Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-ApK0ggzUMSS7rA9QWDunSg-1; Mon, 01 Nov 2021 12:21:28 -0400 X-MC-Unique: ApK0ggzUMSS7rA9QWDunSg-1 Received: by mail-qv1-f72.google.com with SMTP id o15-20020a0cc38f000000b0038455e36f89so16749636qvi.6 for ; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E9idZ9g7Qiy202IHm24WOcqzjkMEWV4Amwu/3bidfKY=; b=Q62Tt60SmjrzlzVy5mZ7lzmOP86xrp4mdc1RXXATEBFz5id0sJlWeB9myTcKmsDxPP KAdTQ1EYhyq2+MMXN7Dx3Du1InbMjcAPize1cAWuTzCK80B4TN0o6qZI0Y18NDxnnrWh eyjuHCFndt13UR4mF3/Pn0YO4iPRpEOgie3ipAW3FrWj/CVq1eJKEZcQtvska2b0V07Z pQyBLnDVQ6h3CQkyPCuXMGOnhrDDWUbjR0A51I6tYb7vJpDy9GImO3qOyFUGYG3KhF/e ieDSC+ekCUdGwICnnWaIJHEko3HHjpEe+g1rA/+TGdRK7nouiJ7Ll0WbedpjD/L1+w4/ 2JIQ== X-Gm-Message-State: AOAM531hhR6koe4llalciPEFKIsFNe8BIw47P7OrtDpYMOV7QFG/XSxc hkKr6jPx5EDIxahb3KI60YJKe+u2mshBZefJsEyM9m/aiYJqmuVtbgBbtslOxyr+d/2SsqgtjVW BqfArf3tSgJM7Yg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472032qtb.183.1635783688230; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXhGf8N2V91WU2Co6WJDyYs4GGgkn9JXnS/oEwWuG4J0RZNo7zMUQJUBh2KgjI9ZclpX5QJg== X-Received: by 2002:ac8:7d04:: with SMTP id g4mr30472009qtb.183.1635783688071; Mon, 01 Nov 2021 09:21:28 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id bj3sm2670847qkb.75.2021.11.01.09.21.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 09:21:27 -0700 (PDT) Date: Mon, 1 Nov 2021 12:21:26 -0400 From: Mike Snitzer To: Dan Williams Message-ID: References: <20211018044054.1779424-1-hch@lst.de> <20211018044054.1779424-11-hch@lst.de> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: dm-devel@redhat.com Cc: Linux NVDIMM , linux-s390 , linux-erofs@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-xfs , device-mapper development , linux-fsdevel , linux-ext4 , Ira Weiny , Christoph Hellwig Subject: Re: [dm-devel] [PATCH 10/11] dm-stripe: add a stripe_dax_pgoff helper X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Oct 27 2021 at 9:41P -0400, Dan Williams wrote: > On Sun, Oct 17, 2021 at 9:41 PM Christoph Hellwig wrote: > > > > Add a helper to perform the entire remapping for DAX accesses. This > > helper open codes bdev_dax_pgoff given that the alignment checks have > > already been done by the submitting file system and don't need to be > > repeated. > > Again, looks good. Kind of embarrassing when the open-coded version is > less LOC than using the helper. > > Mike, ack? Acked-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel