From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 540EFC4332F for ; Tue, 2 Nov 2021 07:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40DB160F70 for ; Tue, 2 Nov 2021 07:56:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231361AbhKBH64 (ORCPT ); Tue, 2 Nov 2021 03:58:56 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:52976 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230508AbhKBH6y (ORCPT ); Tue, 2 Nov 2021 03:58:54 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id B46FE21956; Tue, 2 Nov 2021 07:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1635839778; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6ap4olzBTfLejakCPItyAX9e8bDmpSosfrrPGCanr3k=; b=WwJzLSQXjGdAyznGGV6SpWmdhW49bQlRnvPytZ6fgxedhPeRJVVTgMy0Ih0O5QwjOYpS6a 96PQR55FMHbwdMZIMobPll5efDcxRY2ZviZSkiefrXc10IHo417/75YCqs3hplKbT1wpnR lqnAN+Chyaj0oXodeKoyvl4MpccGfbE= Received: from suse.cz (unknown [10.100.224.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A7312A3B88; Tue, 2 Nov 2021 07:56:17 +0000 (UTC) Date: Tue, 2 Nov 2021 08:56:14 +0100 From: Petr Mladek To: Yafang Shao Cc: Steven Rostedt , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Peter Zijlstra , Al Viro , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , David Miller , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin Lau , Song Liu , Yonghong Song , john fastabend , KP Singh , dennis.dalessandro@cornelisnetworks.com, mike.marciniszyn@cornelisnetworks.com, dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, netdev , bpf , "linux-perf-use." , linux-fsdevel@vger.kernel.org, Linux MM , LKML , kernel test robot , kbuild test robot Subject: Re: [PATCH v7 00/11] extend task comm from 16 to 24 Message-ID: References: <20211101060419.4682-1-laoar.shao@gmail.com> <20211101211845.20ff5b2e@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue 2021-11-02 09:26:35, Yafang Shao wrote: > On Tue, Nov 2, 2021 at 9:18 AM Steven Rostedt wrote: > > On Tue, 2 Nov 2021 09:09:50 +0800 > > Yafang Shao wrote: > > > Now we only care about kthread, so we can put the pointer into a > > > kthread specific struct. > > > For example in the struct kthread, or in kthread->data (which may > > > conflict with workqueue). > > > > No, add a new field to the structure. "full_name" or something like that. > > I'm guessing it should be NULL if the name fits in TASK_COMM_LEN and > > allocated if the name had to be truncated. > > > > Do not overload data with this. That will just make things confusing. > > There's not that many kthreads, where an addition of an 8 byte pointer is > > going to cause issues. > > Sure, I will add a new field named "full_name", which only be > allocated if the kthread's comm is truncated. The plan looks good to me. One more thing. It should obsolete the workqueue-specific solution. It would be great to clean up the workqueue code as the next step. Best Regards, Petr