From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 893A92C85 for ; Tue, 2 Nov 2021 16:04:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10156"; a="212057341" X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="212057341" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:49:40 -0700 X-IronPort-AV: E=Sophos;i="5.87,203,1631602800"; d="scan'208";a="583627869" Received: from smile.fi.intel.com ([10.237.72.184]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2021 08:49:35 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1mhw2I-0033Ff-15; Tue, 02 Nov 2021 17:49:18 +0200 Date: Tue, 2 Nov 2021 17:49:17 +0200 From: Andy Shevchenko To: Dan Carpenter Cc: Tsuchiya Yuto , Hans de Goede , Patrik Gfeller , Mauro Carvalho Chehab , Sakari Ailus , Greg Kroah-Hartman , Hans Verkuil , Kaixu Xia , Laurent Pinchart , Yang Li , Tomi Valkeinen , Alex Dewar , Aline Santana Cordeiro , Arnd Bergmann , Alan , Peter Zijlstra , Ingo Molnar , Linux Media Mailing List , linux-staging@lists.linux.dev, Linux Kernel Mailing List Subject: Re: [BUG/RFC PATCH 3/5] [BUG][RFC] media: atomisp: pci: add NULL check for asd obtained from atomisp_video_pipe Message-ID: References: <20211017162337.44860-1-kitakar@gmail.com> <20211017162337.44860-4-kitakar@gmail.com> <20211102130245.GE2794@kadam> <20211102150523.GJ2794@kadam> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211102150523.GJ2794@kadam> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Tue, Nov 02, 2021 at 06:05:23PM +0300, Dan Carpenter wrote: > On Tue, Nov 02, 2021 at 04:45:20PM +0200, Andy Shevchenko wrote: > > On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko > > wrote: > > > On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter wrote: > > > > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote: ... > > > > Run your patches through scripts/checkpatch.pl. > > > > > > While it's good advice, we are dealing with quite a bad code under > > > staging, so the requirements may be relaxed. > > > > To be more clear: the goal now is getting it _working_. That's why > > this kind of noise is not important _for now_. > > If it's a new driver, then we accept all sorts of garbage, that's true. It was in kernel for a while, but never worked (hence anyhow tested) up to the recent effort made by Tsuchiya. In any case, as I said, we shall run checkpatch in the future when we have something working. -- With Best Regards, Andy Shevchenko