From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netfilter-devel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [nft PATCH] tests: shell: Fix bogus testsuite failure with 250Hz
Date: Tue, 2 Nov 2021 21:21:09 +0100 [thread overview]
Message-ID: <YYGdtUX8YbEScUHE@salvia> (raw)
In-Reply-To: <20211102200753.25311-1-phil@nwl.cc>
On Tue, Nov 02, 2021 at 09:07:53PM +0100, Phil Sutter wrote:
> Previous fix for HZ=100 was not sufficient, a kernel with HZ=250 rounds
> the 10ms to 8ms it seems. Do as Lukas suggests and accept the occasional
> input/output asymmetry instead of continuing the hide'n'seek game.
>
> Fixes: c9c5b5f621c37 ("tests: shell: Fix bogus testsuite failure with 100Hz")
> Suggested-by: Lukas Wunner <lukas@wunner.de>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
ACK
> ---
> tests/shell/testcases/sets/0031set_timeout_size_0 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/shell/testcases/sets/0031set_timeout_size_0 b/tests/shell/testcases/sets/0031set_timeout_size_0
> index 796640d64670a..9a4a27f6c4512 100755
> --- a/tests/shell/testcases/sets/0031set_timeout_size_0
> +++ b/tests/shell/testcases/sets/0031set_timeout_size_0
> @@ -8,5 +8,5 @@ add rule x test set update ip daddr timeout 100ms @y"
>
> set -e
> $NFT -f - <<< "$RULESET"
> -$NFT list chain x test | grep -q 'update @y { ip saddr timeout 1d2h3m4s10ms }'
> +$NFT list chain x test | grep -q 'update @y { ip saddr timeout 1d2h3m4s\(10\|8\)ms }'
> $NFT list chain x test | grep -q 'update @y { ip daddr timeout 100ms }'
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-11-02 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 20:07 [nft PATCH] tests: shell: Fix bogus testsuite failure with 250Hz Phil Sutter
2021-11-02 20:21 ` Pablo Neira Ayuso [this message]
2021-11-03 7:57 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYGdtUX8YbEScUHE@salvia \
--to=pablo@netfilter.org \
--cc=lukas@wunner.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.