From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C8E0C433F5 for ; Tue, 2 Nov 2021 20:57:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 719DE60D43 for ; Tue, 2 Nov 2021 20:57:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230409AbhKBVA2 (ORCPT ); Tue, 2 Nov 2021 17:00:28 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:42795 "EHLO mail-ot1-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230061AbhKBVA2 (ORCPT ); Tue, 2 Nov 2021 17:00:28 -0400 Received: by mail-ot1-f49.google.com with SMTP id v19-20020a9d69d3000000b00555a7318f31so605842oto.9; Tue, 02 Nov 2021 13:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=66ck82izyu4qoaKeTAXAblgBu0F6EcIPcvB7IIzWoYw=; b=X6d/oFq5G94E87VgE25KSFEuyqSUNXXCnvVsKGcLFR8/TOTKQD8RiplC6evGIopOOD c/e9fjWIG0HhZhIl6V1WO9GK0dVQGsLq7dAQnKlr1WtD8JmM188BKZlpcdCTZTSIsrle pDBKhxp9nI0+bQSdXID7T9SnBmkD0QSMUVvAxTdoff47UXL3TQ8vT2UF2IvIuGevruLy 0aG7pYs2vXtl32Upi6BkLNlVFoJPWY4kKBtbS6KtMUsA/ValfIhYKF2pqxknZQ98v8f0 zDLYWbowAWNLob6TNd3FJcmAaebYK2fD5VxO+SkBvfoSsoDwYnLTJfZSH1xV1WDo/hmP xiGQ== X-Gm-Message-State: AOAM533NKpc5I+/dp9oXdbDtMPyz/twpkyNPrU0onPDwGnhaAqdJxH5N 1SpaMi9z/MgO81i76UwV8Q== X-Google-Smtp-Source: ABdhPJx8mAcZMxugS0NdsFzh+dnyXo5rNadhHimq6L2KWur3IT+B/oKSvO/RZy+PAImlwBBIRLciGg== X-Received: by 2002:a9d:2ac1:: with SMTP id e59mr28481258otb.80.1635886672840; Tue, 02 Nov 2021 13:57:52 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id j19sm20502oot.25.2021.11.02.13.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 13:57:52 -0700 (PDT) Received: (nullmailer pid 3463519 invoked by uid 1000); Tue, 02 Nov 2021 20:57:51 -0000 Date: Tue, 2 Nov 2021 15:57:51 -0500 From: Rob Herring To: Kunihiko Hayashi Cc: Linus Walleij , Masami Hiramatsu , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: pinctrl: uniphier: Add child node definitions to describe pin mux and configuration Message-ID: References: <1635385599-17778-1-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1635385599-17778-1-git-send-email-hayashi.kunihiko@socionext.com> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Oct 28, 2021 at 10:46:39AM +0900, Kunihiko Hayashi wrote: > In arch/arm/boot/dts/uniphier-pinctrl.dtsi, there are child nodes of > pinctrl that defines pinmux and pincfg, however, there are no rules about > that in dt-bindings. > > 'make dtbs_check' results an error with the following message: > > pinctrl: 'ain1', 'ain2', 'ainiec1', 'aout', 'aout1', 'aout2', ... > ... 'usb2', 'usb3' do not match any of the regexes: 'pinctrl-[0-9]+' > > To avoid this issue, add the rules of pinmux and pincfg in each child node > and grandchild node. > > Signed-off-by: Kunihiko Hayashi > --- > Changes since v1: > - Replace additionalProperties with unevaluatedProperties > - Add additionalProperties for child and grandchild nodes > > .../pinctrl/socionext,uniphier-pinctrl.yaml | 50 +++++++++++++++++++++- > 1 file changed, 49 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > index a804d9bc1602..7e504e003181 100644 > --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > @@ -26,10 +26,58 @@ properties: > - socionext,uniphier-pxs3-pinctrl > - socionext,uniphier-nx1-pinctrl > > +additionalProperties: > + type: object > + > +patternProperties: > + "^.*$": > + if: > + type: object > + then: > + allOf: All of the above should be: additionalProperties: type: object allOf: ... > + - $ref: pincfg-node.yaml# > + - $ref: pinmux-node.yaml# > + > + properties: > + phandle: true > + function: true > + groups: true > + pins: true > + bias-pull-up: true > + bias-pull-down: true > + bias-pull-pin-default: true > + drive-strength: true > + > + additionalProperties: > + type: object > + > + patternProperties: > + "^.*$": > + if: > + type: object > + then: > + allOf: > + - $ref: pincfg-node.yaml# > + - $ref: pinmux-node.yaml# > + > + properties: > + phandle: true > + function: true > + groups: true > + pins: true > + bias-pull-up: true > + bias-pull-down: true > + bias-pull-pin-default: true > + drive-strength: true > + > + unevaluatedProperties: false > + > + unevaluatedProperties: false > + > required: > - compatible > > -additionalProperties: false > +unevaluatedProperties: false Drop +unevaluatedProperties. > > examples: > - | > -- > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA18C433F5 for ; Tue, 2 Nov 2021 20:59:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7113A60EE3 for ; Tue, 2 Nov 2021 20:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7113A60EE3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AIL/SK5tepmuZC62csjxW4UJ65L+js+MGuoqeBh8+co=; b=vve7YtBJsSi+8d UORy8WioQpPD0Zmmq2494XsPDT7PfpZJgA1+ZQjVj9Gnkfgz1GZoDfO+RHN+SvnMzq7l76SPjq9SK 88ZNYEpkhWqNwLJOZ0H6+pyy7BzMPSDoCFWkTU4SWBdH6F2LV1ZZNBAtvFI60GljCgFcp/tW1krp/ pSfePoASVToUfhQ5devgY4PZFY02EFd0cNNwb68c01BAbtVP5TYrtghYyevva0KYp/gH+371p1Wa5 W33lBD9D+Ah6sz+8VHS0XpXdBYUNNRlRZl2bDPFxBPaFy5VzBwyLNhVkCBUBGgnwmZRork+pnkWBG fyRXM2I+M5iHYO8f1JtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi0r4-002zd3-1m; Tue, 02 Nov 2021 20:58:02 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mi0r0-002zbn-2P for linux-arm-kernel@lists.infradead.org; Tue, 02 Nov 2021 20:57:59 +0000 Received: by mail-ot1-f52.google.com with SMTP id n13-20020a9d710d000000b005558709b70fso605314otj.10 for ; Tue, 02 Nov 2021 13:57:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=66ck82izyu4qoaKeTAXAblgBu0F6EcIPcvB7IIzWoYw=; b=q6RPmB+uKhIHP0niq4hjq28T3D87RuLY2cTbYAV2d/INP5XvTeI/n7YLwvg8YtwMGJ ARAwRIWuyTVaVxBEWI4hhtX3Thn7LVLSATcvzcx9Sk2WAU4R3IXWAzOKc5K+ULV1AEpy LVeY19JYHnY6zPBzhpWCQgr6B6QMa8ktxRtJcw7NcJRbCEUpIdDCtMfppJexqocunT8Z ICVf3Wb8tCFX890BKacsN4fMlmdZ15k2ntKY++oUu0xjnFglSeOj3gwWFxNyk3E7YSv0 rtQnng+gaesz8xG/hWhO/inithfi5MaaKJyIbGo9o74PN/Qk1vKkgaUJmJjuYNGSO4K/ u/ug== X-Gm-Message-State: AOAM532xscf0Gbjs6Vjj975xboVApdYN7LXPuVmbhSmTvl4ShXCklOqT AbDrB/IlQloLFObwCsjiEw== X-Google-Smtp-Source: ABdhPJx8mAcZMxugS0NdsFzh+dnyXo5rNadhHimq6L2KWur3IT+B/oKSvO/RZy+PAImlwBBIRLciGg== X-Received: by 2002:a9d:2ac1:: with SMTP id e59mr28481258otb.80.1635886672840; Tue, 02 Nov 2021 13:57:52 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id j19sm20502oot.25.2021.11.02.13.57.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Nov 2021 13:57:52 -0700 (PDT) Received: (nullmailer pid 3463519 invoked by uid 1000); Tue, 02 Nov 2021 20:57:51 -0000 Date: Tue, 2 Nov 2021 15:57:51 -0500 From: Rob Herring To: Kunihiko Hayashi Cc: Linus Walleij , Masami Hiramatsu , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] dt-bindings: pinctrl: uniphier: Add child node definitions to describe pin mux and configuration Message-ID: References: <1635385599-17778-1-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1635385599-17778-1-git-send-email-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211102_135758_137885_98680136 X-CRM114-Status: GOOD ( 21.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 28, 2021 at 10:46:39AM +0900, Kunihiko Hayashi wrote: > In arch/arm/boot/dts/uniphier-pinctrl.dtsi, there are child nodes of > pinctrl that defines pinmux and pincfg, however, there are no rules about > that in dt-bindings. > > 'make dtbs_check' results an error with the following message: > > pinctrl: 'ain1', 'ain2', 'ainiec1', 'aout', 'aout1', 'aout2', ... > ... 'usb2', 'usb3' do not match any of the regexes: 'pinctrl-[0-9]+' > > To avoid this issue, add the rules of pinmux and pincfg in each child node > and grandchild node. > > Signed-off-by: Kunihiko Hayashi > --- > Changes since v1: > - Replace additionalProperties with unevaluatedProperties > - Add additionalProperties for child and grandchild nodes > > .../pinctrl/socionext,uniphier-pinctrl.yaml | 50 +++++++++++++++++++++- > 1 file changed, 49 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > index a804d9bc1602..7e504e003181 100644 > --- a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml > @@ -26,10 +26,58 @@ properties: > - socionext,uniphier-pxs3-pinctrl > - socionext,uniphier-nx1-pinctrl > > +additionalProperties: > + type: object > + > +patternProperties: > + "^.*$": > + if: > + type: object > + then: > + allOf: All of the above should be: additionalProperties: type: object allOf: ... > + - $ref: pincfg-node.yaml# > + - $ref: pinmux-node.yaml# > + > + properties: > + phandle: true > + function: true > + groups: true > + pins: true > + bias-pull-up: true > + bias-pull-down: true > + bias-pull-pin-default: true > + drive-strength: true > + > + additionalProperties: > + type: object > + > + patternProperties: > + "^.*$": > + if: > + type: object > + then: > + allOf: > + - $ref: pincfg-node.yaml# > + - $ref: pinmux-node.yaml# > + > + properties: > + phandle: true > + function: true > + groups: true > + pins: true > + bias-pull-up: true > + bias-pull-down: true > + bias-pull-pin-default: true > + drive-strength: true > + > + unevaluatedProperties: false > + > + unevaluatedProperties: false > + > required: > - compatible > > -additionalProperties: false > +unevaluatedProperties: false Drop +unevaluatedProperties. > > examples: > - | > -- > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel