[PATCHv2 net 0/5] kselftests/net: add missed tests to Makefile

[PATCHv2 net 0/5] kselftests/net: add missed tests to Makefile

[Hangbin Liu]

When generating the selftest to another folder, some tests are missing
as they are not added in Makefile. e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

These pathset add them separately to make the Fixes tags less. It would
also make the stable tree or downstream backport easier.

If you think there is no need to add the Fixes tag for this minor issue.
I can repost a new patch and merge all the fixes together.

Thanks

v2: move toeplitz.sh/toeplitz_client.sh under TEST_PROGS_EXTENDED.

Hangbin Liu (5):
  kselftests/net: add missed icmp.sh test to Makefile
  kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile
  kselftests/net: add missed SRv6 tests
  kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile
  kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile

 tools/testing/selftests/net/Makefile | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

-- 
2.31.1

[PATCHv2 net 1/5] kselftests/net: add missed icmp.sh test to Makefile

[Hangbin Liu]

When generating the selftests to another folder, the icmp.sh test will
miss as it is not in Makefile, e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

Fixes: 7e9838b7915e ("selftests/net: Add icmp.sh for testing ICMP dummy address responses")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 492b273743b4..9b1c2dfe1253 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -12,7 +12,7 @@ TEST_PROGS += udpgro_bench.sh udpgro.sh test_vxlan_under_vrf.sh reuseport_addr_a
 TEST_PROGS += test_vxlan_fdb_changelink.sh so_txtime.sh ipv6_flowlabel.sh
 TEST_PROGS += tcp_fastopen_backup_key.sh fcnal-test.sh l2tp.sh traceroute.sh
 TEST_PROGS += fin_ack_lat.sh fib_nexthop_multiprefix.sh fib_nexthops.sh
-TEST_PROGS += altnames.sh icmp_redirect.sh ip6_gre_headroom.sh
+TEST_PROGS += altnames.sh icmp.sh icmp_redirect.sh ip6_gre_headroom.sh
 TEST_PROGS += route_localnet.sh
 TEST_PROGS += reuseaddr_ports_exhausted.sh
 TEST_PROGS += txtimestamp.sh
-- 
2.31.1

[PATCHv2 net 2/5] kselftests/net: add missed setup_loopback.sh/setup_veth.sh to Makefile

[Hangbin Liu]

When generating the selftests to another folder, the include file
setup_loopback.sh/setup_veth.sh for gro.sh/gre_gro.sh are missing as
they are not in Makefile, e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

Fixes: 7d1575014a63 ("selftests/net: GRO coalesce test")
Fixes: 9af771d2ec04 ("selftests/net: allow GRO coalesce test on veth")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 9b1c2dfe1253..63ee01c1437b 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -28,7 +28,7 @@ TEST_PROGS += veth.sh
 TEST_PROGS += ioam6.sh
 TEST_PROGS += gro.sh
 TEST_PROGS += gre_gso.sh
-TEST_PROGS_EXTENDED := in_netns.sh
+TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
 TEST_GEN_FILES =  socket nettest
 TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
 TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
-- 
2.31.1

[PATCHv2 net 3/5] kselftests/net: add missed SRv6 tests

[Hangbin Liu]

When generating the selftests to another folder, the SRv6 tests are
missing as they are not in Makefile, e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

Fixes: 03a0b567a03d ("selftests: seg6: add selftest for SRv6 End.DT46 Behavior")
Fixes: 2195444e09b4 ("selftests: add selftest for the SRv6 End.DT4 behavior")
Fixes: 2bc035538e16 ("selftests: add selftest for the SRv6 End.DT6 (VRF) behavior")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/Makefile | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 63ee01c1437b..8a6264da5276 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -28,6 +28,9 @@ TEST_PROGS += veth.sh
 TEST_PROGS += ioam6.sh
 TEST_PROGS += gro.sh
 TEST_PROGS += gre_gso.sh
+TEST_PROGS += srv6_end_dt46_l3vpn_test.sh
+TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
+TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
 TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
 TEST_GEN_FILES =  socket nettest
 TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
-- 
2.31.1

[PATCHv2 net 4/5] kselftests/net: add missed vrf_strict_mode_test.sh test to Makefile

[Hangbin Liu]

When generating the selftests to another folder, the
vrf_strict_mode_test.sh test will miss as it is not in Makefile, e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

Fixes: 8735e6eaa438 ("selftests: add selftest for the VRF strict mode")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 8a6264da5276..7328bede35f0 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -31,6 +31,7 @@ TEST_PROGS += gre_gso.sh
 TEST_PROGS += srv6_end_dt46_l3vpn_test.sh
 TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
 TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
+TEST_PROGS += vrf_strict_mode_test.sh
 TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
 TEST_GEN_FILES =  socket nettest
 TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
-- 
2.31.1

[PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile

[Hangbin Liu]

When generating the selftests to another folder, the toeplitz.sh
and toeplitz_client.sh are missing as they are not in Makefile, e.g.

  make -C tools/testing/selftests/ install \
      TARGETS="net" INSTALL_PATH=/tmp/kselftests

Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
and are not intended to be run from kselftests.

Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v2: move the tests under TEST_PROGS_EXTENDED as Willem suggested.
---
 tools/testing/selftests/net/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 7328bede35f0..6a953ec793ce 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -33,6 +33,7 @@ TEST_PROGS += srv6_end_dt4_l3vpn_test.sh
 TEST_PROGS += srv6_end_dt6_l3vpn_test.sh
 TEST_PROGS += vrf_strict_mode_test.sh
 TEST_PROGS_EXTENDED := in_netns.sh setup_loopback.sh setup_veth.sh
+TEST_PROGS_EXTENDED += toeplitz_client.sh toeplitz.sh
 TEST_GEN_FILES =  socket nettest
 TEST_GEN_FILES += psock_fanout psock_tpacket msg_zerocopy reuseport_addr_any
 TEST_GEN_FILES += tcp_mmap tcp_inq psock_snd txring_overwrite
-- 
2.31.1

Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile

[Willem de Bruijn]

On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
>
> When generating the selftests to another folder, the toeplitz.sh
> and toeplitz_client.sh are missing as they are not in Makefile, e.g.
>
>   make -C tools/testing/selftests/ install \
>       TARGETS="net" INSTALL_PATH=/tmp/kselftests
>
> Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
> and are not intended to be run from kselftests.
>
> Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Willem de Bruijn <willemb@google.com>

The same might apply to the icmp and vrf tests? I am not familiar with those.

Re: [PATCHv2 net 0/5] kselftests/net: add missed tests to Makefile

[Jakub Kicinski]

On Tue,  2 Nov 2021 09:36:31 +0800 Hangbin Liu wrote:
> When generating the selftest to another folder, some tests are missing
> as they are not added in Makefile. e.g.
> 
>   make -C tools/testing/selftests/ install \
>       TARGETS="net" INSTALL_PATH=/tmp/kselftests
> 
> These pathset add them separately to make the Fixes tags less. It would
> also make the stable tree or downstream backport easier.
> 
> If you think there is no need to add the Fixes tag for this minor issue.
> I can repost a new patch and merge all the fixes together.

Thanks! Could you rebase on latest net/master and resend? 
We just forwarded the net tree for the next merge window.

Re: [PATCHv2 net 5/5] kselftests/net: add missed toeplitz.sh/toeplitz_client.sh to Makefile

[Hangbin Liu]

On Tue, Nov 02, 2021 at 11:09:43AM -0400, Willem de Bruijn wrote:
> On Mon, Nov 1, 2021 at 9:37 PM Hangbin Liu <liuhangbin@gmail.com> wrote:
> >
> > When generating the selftests to another folder, the toeplitz.sh
> > and toeplitz_client.sh are missing as they are not in Makefile, e.g.
> >
> >   make -C tools/testing/selftests/ install \
> >       TARGETS="net" INSTALL_PATH=/tmp/kselftests
> >
> > Making them under TEST_PROGS_EXTENDED as they test NIC hardware features
> > and are not intended to be run from kselftests.
> >
> > Fixes: 5ebfb4cc3048 ("selftests/net: toeplitz test")
> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> 
> Reviewed-by: Willem de Bruijn <willemb@google.com>

Thanks for the review.
> 
> The same might apply to the icmp and vrf tests? I am not familiar with those.

icmp and vrf are running for selftests. They should be added to TEST_PROGS.

Thanks
Hangbin