All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: phillip.wood@dunelm.org.uk,
	Phillip Wood via GitGitGadget <gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	Jonas Kittner <jonas.kittner@ruhr-uni-bochum.de>
Subject: Re: [PATCH] rebase -i: fix rewording with --committer-date-is-author-date
Date: Wed, 3 Nov 2021 22:03:26 -0400	[thread overview]
Message-ID: <YYM/bm7cHpJeJoGT@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqk0hp6sno.fsf@gitster.g>

On Wed, Nov 03, 2021 at 10:44:11AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I'm happy enough with it. I don't know what the plan is for the -rc
> > period, though. AFAICT the bug is in v2.33.1, so it's not technically a
> > v2.34-rc problem. It could wait for the next maint release.
> 
> Hmph, if it was in v2.33.0 then it is not, but if it was introduced
> between v2.33.0 and v2.33.1, then it is a problem for the current
> cycle, no?

I guess it depends how you consider the cycle. It's in v2.33.1 but not
v2.33.0, so yes, anybody going from v2.33.0 to v2.34.0 will see it as a
regression. I don't have any problem with fixing it for v2.34.0, and I
think the fix Phillip provided is minimally invasive. I just didn't
consider it quite the same as a bug that had never been in a released
version at all (and I know you are often hesitant to throw too much into
the -rc part of the cycle).

-Peff

  reply	other threads:[~2021-11-04  2:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-02 20:10 [PATCH] rebase -i: fix rewording with --committer-date-is-author-date Phillip Wood via GitGitGadget
2021-11-02 21:05 ` Eric Sunshine
2021-11-02 21:29   ` Phillip Wood
2021-11-02 21:30 ` [PATCH v2] " Phillip Wood via GitGitGadget
2021-11-02 22:32 ` [PATCH] " Jeff King
2021-11-03 11:23   ` Phillip Wood
2021-11-03 11:42     ` Jeff King
2021-11-03 17:44       ` Junio C Hamano
2021-11-04  2:03         ` Jeff King [this message]
2021-11-04  6:27           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYM/bm7cHpJeJoGT@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    --cc=jonas.kittner@ruhr-uni-bochum.de \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.