All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] tests/kms_cursor_legacy: Fix build warning
Date: Thu, 4 Nov 2021 10:58:53 +0200	[thread overview]
Message-ID: <YYOgzZ29rDGXaF1K@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20211104072544.GA9460@zkempczy-mobl2>

On Thu, Nov 04, 2021 at 08:25:44AM +0100, Zbigniew Kempczyński wrote:
> On Thu, Nov 04, 2021 at 08:48:48AM +0200, Petri Latvala wrote:
> > ../tests/kms_cursor_legacy.c: In function ‘flip_vs_cursor_busy_crc’:
> > ../tests/kms_cursor_legacy.c:1337:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
> >  1337 |  uint64_t ahnd = get_reloc_ahnd(display->drm_fd, 0);
> >        |  ^~~~~~~~
> > 
> > Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> > Cc: Mark Yacoub <markyacoub@chromium.org>
> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >  tests/kms_cursor_legacy.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c
> > index e48cdf6c..cd2f8498 100644
> > --- a/tests/kms_cursor_legacy.c
> > +++ b/tests/kms_cursor_legacy.c
> > @@ -1333,8 +1333,10 @@ static void flip_vs_cursor_busy_crc(igt_display_t *display, bool atomic)
> >  	igt_pipe_t *pipe_connected = &display->pipes[pipe];
> >  	igt_plane_t *plane_primary = igt_pipe_get_plane_type(pipe_connected, DRM_PLANE_TYPE_PRIMARY);
> >  	igt_crc_t crcs[2], test_crc;
> > +	uint64_t ahnd;
> > +
> >  	igt_require_intel(display->drm_fd);
> > -	uint64_t ahnd = get_reloc_ahnd(display->drm_fd, 0);
> > +	ahnd = get_reloc_ahnd(display->drm_fd, 0);
> 
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>

And merged, thanks.


-- 
Petri Latvala

  reply	other threads:[~2021-11-04  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  6:48 [igt-dev] [PATCH i-g-t 1/1] tests/kms_cursor_legacy: Fix build warning Petri Latvala
2021-11-04  7:25 ` Zbigniew Kempczyński
2021-11-04  8:58   ` Petri Latvala [this message]
2021-11-04  7:51 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2021-11-04  8:52 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYOgzZ29rDGXaF1K@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.