From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42B5FC433EF for ; Fri, 5 Nov 2021 15:37:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1AD9761250 for ; Fri, 5 Nov 2021 15:37:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233537AbhKEPjh (ORCPT ); Fri, 5 Nov 2021 11:39:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233464AbhKEPjg (ORCPT ); Fri, 5 Nov 2021 11:39:36 -0400 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B975C061205 for ; Fri, 5 Nov 2021 08:36:56 -0700 (PDT) Received: by mail-pl1-x62e.google.com with SMTP id o14so11322217plg.5 for ; Fri, 05 Nov 2021 08:36:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=byGIoYkr0QhWpJdm4ULxfBziUavg2KJpzYT4Nf5tt3s=; b=ET3VcrdlIP9HQjIDJYvleAng264LiCDGiockoUj9mbSqEWzbMx4qIQqWOTpsiVOMoe 1h2RLIl/OmPIwSOfCYZVSooUajDezEagxfrmhvnSAX1xfHGuq/m77W/pZRoFHyKMSlt5 yghjjy59VBDJDhvOJe9UqC78t4dhwZS9Gyxc6r4vGnDdtp5dvtrNEPZ9Ntd9zPYISgBq AzttVafq5l13ol9SzSy7qAv3CfpcPU1NRHg9G6aPGFcGz262CLVN9y0Je8jmJoSbbieX BzSEdjHVz15M4iIto1KnnO6AtzngJaBOluJrVaLxSk/P/QHyY3SeXcFmHNfkNCyYwVx6 3llw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=byGIoYkr0QhWpJdm4ULxfBziUavg2KJpzYT4Nf5tt3s=; b=l80zeJTcCJ2n+17g51+QmYsKr3dGYMyWk+JQhNczHmVt2Qa5lwJIARoFxyEcAYRt2J 7M34GPzLe4QLfI1jdGVSimgvUeQl2jnFZay9Nwv+ztjiN/RvJPknxnpVEGLuLThCDMhT B9aDKUHMrzAeppSvk1uyT5pmkQd7m+55i0wdz77fejyl5GHnVn7TdbKw2hwcwjTEX2Ja jPsO8PgJgAU4B3W6kIPOvhMCOJO6Qg5l6Wr5oXwW4QynyFJWqPRlWSn6qgtm3nVRbEpt pWKunTePr5lOODV/Nk8c2uPphxwQlBgWmdLKQ3c6u7OxlV8RIeUbdlohNmm50Xppz26B fBOw== X-Gm-Message-State: AOAM532Bwf3dE8vxxXXouKaNoQJ19tvtJmTuDPinsdfmrw/yOAnBsxh1 TanMv9m70RV0BivD9eF0TW+4BA== X-Google-Smtp-Source: ABdhPJyjTdlXsCOkbpOSgeDygiSkroH08OzEE8JdWsTeAhXCHJdw3tjx8Y7g2DtY2QJHapZWTB8UIg== X-Received: by 2002:a17:902:aa08:b0:13f:eb2e:8ce8 with SMTP id be8-20020a170902aa0800b0013feb2e8ce8mr52619170plb.0.1636126615651; Fri, 05 Nov 2021 08:36:55 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id w192sm2422905pfd.21.2021.11.05.08.36.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Nov 2021 08:36:54 -0700 (PDT) Date: Fri, 5 Nov 2021 15:36:51 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection Message-ID: References: <20211103070310.43380-1-likexu@tencent.com> <20211103070310.43380-2-likexu@tencent.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Nov 05, 2021, Sean Christopherson wrote: > On Wed, Nov 03, 2021, Like Xu wrote: > I would also say land this memcpy() above kvm_ops_static_call_update(), then the > enabling patch can do the static call updates in kvm_ops_static_call_update() > instead of adding another helper. Ugh, kvm_ops_static_call_update() is defined in kvm_host.h. That's completely unnecessary, it should have exactly one caller, kvm_arch_hardware_setup(). As a prep match, move kvm_ops_static_call_update() to x86.c, then it can reference the pmu ops.