From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC9BC433F5 for ; Mon, 8 Nov 2021 17:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1C4361074 for ; Mon, 8 Nov 2021 17:25:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239911AbhKHR1p (ORCPT ); Mon, 8 Nov 2021 12:27:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbhKHR1n (ORCPT ); Mon, 8 Nov 2021 12:27:43 -0500 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CBDCC061570 for ; Mon, 8 Nov 2021 09:24:59 -0800 (PST) Received: by mail-pj1-x102a.google.com with SMTP id w33-20020a17090a6ba400b001a722a06212so294699pjj.0 for ; Mon, 08 Nov 2021 09:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4EbD7aqTQKxclsPLCjVFRazOOf7SVm4FlHdT4M8Q2OE=; b=UJm8tlekg3RcDJN6+qUt+cpMTkF4V/Hj+tnGbZFokcB4SAQcj3P6+RI/2cLOYGqTC5 bCzuHg8QbDSjgI2zeVkvP9HVJWKs17hjbDs9+kt0rALTnmBPHce6tq8pHh7CDN2piT9n 9OwAqtKhOEBQvAw8eMCmPOqKEU9O2fvB7caD2N3d38GnhYlW+XChRzNd4HPEClxkA/QP nk8aRKuAysvXR6jYDvC11oc2qJr3ATPSy/IO3dfxS0tPhk2CCWjL7HbpwRoVsycH2a+Z 9DOSeKbufz52wK6GOc5E7tNdBvICz0zV+AsyvDO045LarEbbiHRc/0guA0a45WahOxso Eheg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4EbD7aqTQKxclsPLCjVFRazOOf7SVm4FlHdT4M8Q2OE=; b=Sah0Dsvgieimx7AZB+/9RBjxO0ixHKsmTx0vtUbAQcDHvjjVRyAkcNbYQXiYohchjT v/BiDVCGhMi1OGf5KldzLjc1gMiMm8zW9xreKtg11sB/JtscHyxchpSIagDKJzO7DZLs yD0hEHJeuYy2g4DPDTMgyRYw86Ue5xbhbce0F9nOcjRPMSiUiVjp8JOeZ+RLoBMnbk1Z NDoFIiANGSz4sOxgYMcGRLd/6hCMpXltLJgVLT67Wqp/K+akJuUpWJkbB9TrvClfPDiu WAxwJwUuFASWadDGPDdAzEbi3cglqYgXmohG3zYVh6cCA+362soHg5l2JF8zFtX6nspM Spqg== X-Gm-Message-State: AOAM532eVadAU9uheDtKMDOOdqeFt42O/7bJ/Yx1P2bdDeIca4e7oEu6 7eHWVdfWwnahtquNZPK+FRilQw== X-Google-Smtp-Source: ABdhPJzzJsPhO6l9Wzpus0ydSjqjfOxWycpAvNYAImmWhmgSVDVbcAmYrgi+e+A2wwKWC+cYPJFipg== X-Received: by 2002:a17:902:e547:b0:141:ddbc:a8d6 with SMTP id n7-20020a170902e54700b00141ddbca8d6mr812890plf.27.1636392298669; Mon, 08 Nov 2021 09:24:58 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id v22sm16321575pff.93.2021.11.08.09.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 09:24:58 -0800 (PST) Date: Mon, 8 Nov 2021 17:24:54 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Alexander Graf , Paolo Bonzini Subject: Re: [PATCH v3 1/3] KVM: nVMX: Handle dynamic MSR intercept toggling Message-ID: References: <20210924204907.1111817-1-seanjc@google.com> <20210924204907.1111817-2-seanjc@google.com> <87k0hioasv.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k0hioasv.fsf@vitty.brq.redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 08, 2021, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > @@ -6749,7 +6686,9 @@ static fastpath_t vmx_vcpu_run(struct kvm_vcpu *vcpu) > > * If the L02 MSR bitmap does not intercept the MSR, then we need to > > * save it. > > */ > > - if (unlikely(!msr_write_intercepted(vcpu, MSR_IA32_SPEC_CTRL))) > > + if (unlikely(cpu_has_vmx_msr_bitmap() && > > + vmx_test_msr_bitmap_write(vmx->loaded_vmcs->msr_bitmap, > > + MSR_IA32_SPEC_CTRL))) Ugh, I inverted the check, '1' == intercept. IIRC, I open coded the intercept check because SPEC_CTRL is really the only case where should be reading _only_ the current VMCS's MSR bitmap. I'll spin a new version of the series and test with SPEC_CTRL disabled in a VM, and maybe revist my reasoning for this. Thanks! > > vmx->spec_ctrl = native_read_msr(MSR_IA32_SPEC_CTRL); > > I smoke-tested this patch by running (unrelated) selftests when I tried > to put in into my 'Enlightened MSR Bitmap v4' series and my dmesg got > flooded with: > > [ 87.210214] unchecked MSR access error: RDMSR from 0x48 at rIP: 0xffffffffc04e0284 (native_read_msr+0x4/0x30 [kvm_intel]) > [ 87.210325] Call Trace: > [ 87.210355] vmx_vcpu_run+0xcc7/0x12b0 [kvm_intel] > [ 87.210405] ? vmx_prepare_switch_to_guest+0x138/0x1f0 [kvm_intel] > [ 87.210466] vcpu_enter_guest+0x98c/0x1380 [kvm] > [ 87.210631] ? vmx_vcpu_put+0x2e/0x1f0 [kvm_intel] > [ 87.210678] ? vmx_vcpu_load+0x21/0x60 [kvm_intel] > [ 87.210729] kvm_arch_vcpu_ioctl_run+0xdf/0x580 [kvm] > [ 87.210844] kvm_vcpu_ioctl+0x274/0x660 [kvm] > [ 87.210950] __x64_sys_ioctl+0x83/0xb0 > [ 87.210996] do_syscall_64+0x3b/0x90 > [ 87.211039] entry_SYSCALL_64_after_hwframe+0x44/0xae > [ 87.211093] RIP: 0033:0x7f6ef7f9a307 > [ 87.211134] Code: 44 00 00 48 8b 05 69 1b 2d 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 39 1b 2d 00 f7 d8 64 89 01 48 > [ 87.211293] RSP: 002b:00007ffcacfb3b18 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 > [ 87.211367] RAX: ffffffffffffffda RBX: 0000000000a2f300 RCX: 00007f6ef7f9a307 > [ 87.211434] RDX: 0000000000000000 RSI: 000000000000ae80 RDI: 0000000000000007 > [ 87.211500] RBP: 0000000000000000 R08: 000000000040e769 R09: 0000000000000000 > [ 87.211559] R10: 0000000000a2f001 R11: 0000000000000246 R12: 0000000000a2d010 > [ 87.211622] R13: 0000000000a2d010 R14: 0000000000402a15 R15: 00000000ffff0ff0 > [ 87.212520] Call Trace: > [ 87.212597] vmx_vcpu_run+0xcc7/0x12b0 [kvm_intel] > [ 87.212683] ? vmx_prepare_switch_to_guest+0x138/0x1f0 [kvm_intel] > [ 87.212789] vcpu_enter_guest+0x98c/0x1380 [kvm] > [ 87.213059] ? vmx_vcpu_put+0x2e/0x1f0 [kvm_intel] > [ 87.213141] ? schedule+0x44/0xa0 > [ 87.213200] kvm_arch_vcpu_ioctl_run+0xdf/0x580 [kvm] > [ 87.213428] kvm_vcpu_ioctl+0x274/0x660 [kvm] > [ 87.213633] __x64_sys_ioctl+0x83/0xb0 > [ 87.213705] do_syscall_64+0x3b/0x90 > [ 87.213766] entry_SYSCALL_64_after_hwframe+0x44/0xae > ... > > this was an old 'E5-2603 v3' CPU. Any idea what's wrong?