From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH 0/9] arm64: dts: renesas: Thermal binding validation
Date: Tue, 9 Nov 2021 10:09:46 +0100 [thread overview]
Message-ID: <YYo62jdzSTxqCMtk@oden.dyn.berto.se> (raw)
In-Reply-To: <YYo0syH9m/CYlB2d@oden.dyn.berto.se>
On 2021-11-09 09:43:33 +0100, Niklas Söderlund wrote:
> > > linux/arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dt.yaml:
> > > thermal-zones: sensor3-thermal:cooling-maps:map0:contribution:0:0:
> > > 1024 is greater than the maximum of 100
> > > From schema: Documentation/devicetree/bindings/thermal/thermal-zones.yaml
> > >
> > > This validation error appears to be pervasive across all of these
> > > bindings, but changing that will be more invasive and require someone to
> > > perform dedicated testing with the thermal drivers to ensure that the
> > > updates to the ranges do not cause unexpected side effects.
> >
> > Niklas?
>
> I will have a look. The thermal driver is the one driver where I have
> automated CI test running.
So the core of the issue is that the definition of the property changed
in the txt to yaml conversion. The original definition was,
Optional property:
- contribution: The cooling contribution to the thermal zone of the
Type: unsigned referred cooling device at the referred trip point.
Size: one cell The contribution is a ratio of the sum
of all cooling contributions within a thermal zone.
While the new binding states,
contribution:
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 100
description:
The percentage contribution of the cooling devices at the
specific trip temperature referenced in this map
to this thermal zone
Looking at the real world usage of this only 2 out of 17 platforms sets
a contribution value less or equal to 100. I will send a patch to fix
the bindings.
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2021-11-09 9:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 22:40 [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Kieran Bingham
2021-11-04 22:40 ` [PATCH 1/9] arm64: dts: renesas: r8a774a1: Fix thermal bindings Kieran Bingham
2021-11-04 22:40 ` [PATCH 2/9] arm64: dts: renesas: r8a774b1: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 3/9] arm64: dts: renesas: r8a774e1: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 4/9] arm64: dts: renesas: r8a77951: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 5/9] arm64: dts: renesas: r8a77960: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 6/9] arm64: dts: renesas: r8a77961: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 7/9] arm64: dts: renesas: r8a77965: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 8/9] arm64: dts: renesas: r8a77980: " Kieran Bingham
2021-11-04 22:40 ` [PATCH 9/9] arm64: dts: renesas: r8a779a0: " Kieran Bingham
2021-11-09 8:29 ` [PATCH 0/9] arm64: dts: renesas: Thermal binding validation Geert Uytterhoeven
2021-11-09 8:43 ` Niklas Söderlund
2021-11-09 9:09 ` Niklas Söderlund [this message]
2021-11-30 16:45 ` Geert Uytterhoeven
2021-11-30 16:49 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYo62jdzSTxqCMtk@oden.dyn.berto.se \
--to=niklas.soderlund+renesas@ragnatech.se \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.