All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Zhaolong Zhang <zhangzl2013@126.com>
Cc: Tony Luck <tony.luck@intel.com>,
	x86@kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Paul E . McKenney" <paulmck@kernel.org>
Subject: Re: [PATCH] x86/mce: Get rid of cpu_missing
Date: Tue, 9 Nov 2021 10:15:11 +0100	[thread overview]
Message-ID: <YYo8H34W8xPafdnH@zn.tnic> (raw)
In-Reply-To: <20211109083547.3546963-1-zhangzl2013@126.com>

On Tue, Nov 09, 2021 at 04:35:47PM +0800, Zhaolong Zhang wrote:
> Drop cpu_missing since we have more capable mce_missing_cpus.

Who is "we"?

Also, you need to try harder with that commit message - mce_missing_cpus
is a cpumask and I don't see how a cpumask can be "more capable"...

Some more hints on a possible way to structure a commit message - those
are just hints - not necessarily rules - but it should help you get an
idea:

Problem is A.

It happens because of B.

Fix it by doing C.

(Potentially do D).

For more detailed info, see
Documentation/process/submitting-patches.rst, Section "2) Describe your
changes".

Also, to the tone, from Documentation/process/submitting-patches.rst:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Also, do not talk about what your patch does - that should hopefully be
visible in the diff itself. Rather, talk about *why* you're doing what
you're doing.

Also, please use passive voice in your commit message: no "we" or "I", etc,
and describe your changes in imperative mood.

Bottom line is: personal pronouns are ambiguous in text, especially with
so many parties/companies/etc developing the kernel so let's avoid them
please.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette

  reply	other threads:[~2021-11-09  9:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-04  7:44 [PATCH] x86/mce: correct cpu_missing reporting in mce_timed_out Zhaolong Zhang
2021-11-04  9:13 ` Borislav Petkov
2021-11-04 15:47   ` Luck, Tony
2021-11-04 18:02     ` Borislav Petkov
2021-11-05  2:19       ` Zhaolong Zhang
2021-11-08  8:28         ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Zhaolong Zhang
2021-11-08  9:31           ` Borislav Petkov
2021-11-08 10:13             ` Zhaolong Zhang
2021-11-08 10:31               ` Borislav Petkov
2021-11-08 12:47                 ` Zhaolong Zhang
2021-11-09  8:31                   ` Zhaolong Zhang
2021-11-09  8:35                     ` [PATCH] x86/mce: Get rid of cpu_missing Zhaolong Zhang
2021-11-09  9:15                       ` Borislav Petkov [this message]
2021-11-09 14:19                         ` Zhaolong Zhang
2021-11-09  9:07                     ` [PATCH] x86/mce: drop cpu_missing since we have more capable mce_missing_cpus Borislav Petkov
2021-11-09 16:06                       ` Luck, Tony
2021-11-09 19:48                         ` Borislav Petkov
2021-11-09 19:50                           ` Luck, Tony
2021-11-09 20:21                             ` Borislav Petkov
2021-11-09 20:44                               ` Luck, Tony
2021-11-09 21:30                                 ` Borislav Petkov
2021-12-20 20:43                                   ` [PATCH] x86/mce: Remove the tolerance level control Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YYo8H34W8xPafdnH@zn.tnic \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    --cc=zhangzl2013@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.