From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAFAFC433EF for ; Thu, 25 Nov 2021 14:32:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355786AbhKYOgE (ORCPT ); Thu, 25 Nov 2021 09:36:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:48214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352655AbhKYOeC (ORCPT ); Thu, 25 Nov 2021 09:34:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FB7761041; Thu, 25 Nov 2021 14:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637850650; bh=0xFa/kwdXuhHGsjEJDOWGKhXNOfWoCQ4zX3oRmtXPxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i+pjcraC1g8STD7bshWvHBCH/nHgvcuDoiDHv5VWbW7Ei8uCUs9qaRx40KWQywqgX X/gAyXOaVJRDMwOMCvAgP88/3DBrZgO5GiepBqGbyoZmLEvuhkkDHaOukDFhCpcc1s COsh0Tf+dI/4Q3UFVTslcCOwc/DA8kLGtvZmgzTIBlD3XwPP17VPkB6XIvaR1YaO0O TcuUUGnKGEvJjCCWUA9WSspuqItCFf1Ia42z6THHPxgA2M3xLO7WYbEplOye464lC5 Dgir5e2OKcNTJXmoOuBipFPrlJrUPDYbBCwNPbVBbAEDOmcuspaj9RYvlYTTKToX5H e+YqGFjWSUFWQ== Date: Thu, 25 Nov 2021 14:30:45 +0000 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 3/5] arm64: Make the unwind loop in unwind() similar to other architectures Message-ID: References: <8b861784d85a21a9bf08598938c11aff1b1249b9> <20211123193723.12112-1-madvenka@linux.microsoft.com> <20211123193723.12112-4-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N9fRGPaMmAWIuANF" Content-Disposition: inline In-Reply-To: <20211123193723.12112-4-madvenka@linux.microsoft.com> X-Cookie: This bag is recyclable. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --N9fRGPaMmAWIuANF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 23, 2021 at 01:37:21PM -0600, madvenka@linux.microsoft.com wrote: > unwind_start(&frame, fp, pc); > while (unwind_continue(tsk, &frame, fn, data)) > unwind_next(tsk, &frame); Other architectures seem to call their unwind_next() unwind_next_frame() instead, and use a function unwind_done() rather than unwind_continue(). I appreciate that's actually a change carried through from one of the earlier patches but might be worth considering. I don't really *mind* that, though if there's any work on pulling more code out of the architecture into the generic code it'll need revisiting in at least some of the architectures. Reviwed-by: Mark Brown --N9fRGPaMmAWIuANF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGfnhQACgkQJNaLcl1U h9ANJwf9F7OP5Y+O3J9bKoFwrSqLplZJrP0ez14Osw/lJI/amq5E68KgqEuqQ1jK tvKaaL4x0akbB8U3gCZxif9mvy5TZTrnDxhusoRYQOX7FDGh6wsEynMTwQNBftGh poSLi2vL4QfFo0ZsLrSvPNrN6zItHsvsDV7RAhogTNGu9N62v2Va7+cv22Oi0gXl XfBjiCR7A4teQnsKmh8DJfw5ELOrsP2VfxU4iea8olOfPK51GgryEc2c911QrluX Yq2720KDeM+lVbWOQaLXe9evEbg7utUR6sPHQw3w33HEUKDczFksLsH+8xBbltCq WRM50262xBv0AiT5fVOpE2/9+lsRcQ== =3X6L -----END PGP SIGNATURE----- --N9fRGPaMmAWIuANF-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B00EC433F5 for ; Thu, 25 Nov 2021 14:32:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PNWZGXxxCRe8oFSa1bGGZxLoOwSzFgYlbJLVc+Rk9Z4=; b=iQUYgYWOg7YNqbUt1sz9bOsD8S DcIJNL1TvWLpxMpoHmJrnBifVHLPsfm5K/X7EgRRh+Zuscp6ypXjYL40YmGiLm+2EUvrUerMe/3KG z6+w4BYi6rUVJfGg+aXuyKYwjR3CHcNrWDgJnO9qe5vSaCVp0/KIwFtokAgThThVWGpQlb0Y8S5O4 JsEIsIuqOf9777fMS/spkfFdVKFD+HSG4bOXsiZOcN6gWR672pOZkmPfS1h/w6ixycjZ9eYRaXAl8 7EdmBUAkwLZ+vIdJ1AZ2tVG6Uef2diL+TSSt7QZTLdNOXuFZdRJB4yTnhYkVBu4zh33gGNYWaAJ8l C+jS5M7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFm3-007pMN-DR; Thu, 25 Nov 2021 14:30:55 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqFlz-007pLo-38 for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 14:30:52 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5FB7761041; Thu, 25 Nov 2021 14:30:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1637850650; bh=0xFa/kwdXuhHGsjEJDOWGKhXNOfWoCQ4zX3oRmtXPxo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i+pjcraC1g8STD7bshWvHBCH/nHgvcuDoiDHv5VWbW7Ei8uCUs9qaRx40KWQywqgX X/gAyXOaVJRDMwOMCvAgP88/3DBrZgO5GiepBqGbyoZmLEvuhkkDHaOukDFhCpcc1s COsh0Tf+dI/4Q3UFVTslcCOwc/DA8kLGtvZmgzTIBlD3XwPP17VPkB6XIvaR1YaO0O TcuUUGnKGEvJjCCWUA9WSspuqItCFf1Ia42z6THHPxgA2M3xLO7WYbEplOye464lC5 Dgir5e2OKcNTJXmoOuBipFPrlJrUPDYbBCwNPbVBbAEDOmcuspaj9RYvlYTTKToX5H e+YqGFjWSUFWQ== Date: Thu, 25 Nov 2021 14:30:45 +0000 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v11 3/5] arm64: Make the unwind loop in unwind() similar to other architectures Message-ID: References: <8b861784d85a21a9bf08598938c11aff1b1249b9> <20211123193723.12112-1-madvenka@linux.microsoft.com> <20211123193723.12112-4-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20211123193723.12112-4-madvenka@linux.microsoft.com> X-Cookie: This bag is recyclable. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_063051_179207_4BB11839 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8175545601097940792==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8175545601097940792== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="N9fRGPaMmAWIuANF" Content-Disposition: inline --N9fRGPaMmAWIuANF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 23, 2021 at 01:37:21PM -0600, madvenka@linux.microsoft.com wrote: > unwind_start(&frame, fp, pc); > while (unwind_continue(tsk, &frame, fn, data)) > unwind_next(tsk, &frame); Other architectures seem to call their unwind_next() unwind_next_frame() instead, and use a function unwind_done() rather than unwind_continue(). I appreciate that's actually a change carried through from one of the earlier patches but might be worth considering. I don't really *mind* that, though if there's any work on pulling more code out of the architecture into the generic code it'll need revisiting in at least some of the architectures. Reviwed-by: Mark Brown --N9fRGPaMmAWIuANF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmGfnhQACgkQJNaLcl1U h9ANJwf9F7OP5Y+O3J9bKoFwrSqLplZJrP0ez14Osw/lJI/amq5E68KgqEuqQ1jK tvKaaL4x0akbB8U3gCZxif9mvy5TZTrnDxhusoRYQOX7FDGh6wsEynMTwQNBftGh poSLi2vL4QfFo0ZsLrSvPNrN6zItHsvsDV7RAhogTNGu9N62v2Va7+cv22Oi0gXl XfBjiCR7A4teQnsKmh8DJfw5ELOrsP2VfxU4iea8olOfPK51GgryEc2c911QrluX Yq2720KDeM+lVbWOQaLXe9evEbg7utUR6sPHQw3w33HEUKDczFksLsH+8xBbltCq WRM50262xBv0AiT5fVOpE2/9+lsRcQ== =3X6L -----END PGP SIGNATURE----- --N9fRGPaMmAWIuANF-- --===============8175545601097940792== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8175545601097940792==--