All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: tstark@linux.microsoft.com, virtio-comment@lists.oasis-open.org,
	grahamwo@microsoft.com, benhill@microsoft.com,
	tstark@microsoft.com, pankaj.gupta.linux@gmail.com
Subject: Re: [virtio-comment] [PATCH v5 1/1] virtio-pmem: Support describing pmem as shared memory region
Date: Tue, 23 Nov 2021 16:42:38 +0000	[thread overview]
Message-ID: <YZ0Z/ks4ZoHHZRJK@stefanha-x1.localdomain> (raw)
In-Reply-To: <87sfw37ymd.fsf@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

On Thu, Nov 11, 2021 at 11:52:42AM +0100, Cornelia Huck wrote:
> On Wed, Nov 10 2021, tstark@linux.microsoft.com wrote:
> 
> > From: Taylor Stark <tstark@microsoft.com>
> >
> > Update the virtio-pmem spec to add support for describing the pmem region as a
> > shared memory window. This is required to support virtio-pmem in Hyper-V, since
> > Hyper-V only allows PCI devices to operate on memory ranges defined via BARs.
> > When using the virtio PCI transport, shared memory regions are described via
> > PCI BARs.
> >
> > Signed-off-by: Taylor Stark <tstark@microsoft.com>
> > ---
> >  conformance.tex | 14 ++++++++++++--
> >  virtio-pmem.tex | 40 +++++++++++++++++++++++++++++++++-------
> >  2 files changed, 45 insertions(+), 9 deletions(-)
> 
> This looks good to me now.

I noticed the patch uses "guest absolute address" instead of "physical
address". This terminology was fixed in the original pmem patch and I
guess the shared memory patch wasn't updated. Please don't use "guest".

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-11-23 16:42 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 18:55 [virtio-comment] [PATCH v5 0/1] virtio-pmem: Support describing pmem as shared memory region tstark
2021-11-10 18:55 ` [virtio-comment] [PATCH v5 1/1] " tstark
2021-11-11 10:52   ` Cornelia Huck
2021-11-11 18:17     ` Taylor Stark
2021-11-23 16:42     ` Stefan Hajnoczi [this message]
2021-11-23 16:49       ` Cornelia Huck
2021-11-24 15:36         ` Stefan Hajnoczi
2021-11-16  0:31   ` [virtio-comment] " Pankaj Gupta
2021-11-18 17:37   ` [virtio-comment] " Halil Pasic
2021-11-21  8:08     ` Taylor Stark
2021-11-22 11:58       ` Cornelia Huck
2021-11-22 19:56         ` Halil Pasic
2021-11-23 11:10           ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ0Z/ks4ZoHHZRJK@stefanha-x1.localdomain \
    --to=stefanha@redhat.com \
    --cc=benhill@microsoft.com \
    --cc=cohuck@redhat.com \
    --cc=grahamwo@microsoft.com \
    --cc=pankaj.gupta.linux@gmail.com \
    --cc=tstark@linux.microsoft.com \
    --cc=tstark@microsoft.com \
    --cc=virtio-comment@lists.oasis-open.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.