From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20C28C433EF for ; Wed, 24 Nov 2021 07:13:13 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id A47073C65EF for ; Wed, 24 Nov 2021 08:13:10 +0100 (CET) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 44F793C2485 for ; Wed, 24 Nov 2021 08:13:01 +0100 (CET) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id B3DFF60070E for ; Wed, 24 Nov 2021 08:13:00 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 837CC21959; Wed, 24 Nov 2021 07:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1637737979; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WtCIK14yHhTi2d0PvahcpIm0ebhHgfd8JfMAjVEBccs=; b=k/uYe3JuV4767liSKpVTXaM43sPZcRJbr5RkB+ssTCrcWw3H/jZZ5e5sbpnsobdGAhDw37 gEI1td2c9uxIkcADvZC62K9Ov3jE4WhFAScT9+DwAaYXHccvgtEbA4L7yobpG/BRl6nqGW Bye+PQb43Bcne598qpSXIHFwSxvfgD4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1637737979; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WtCIK14yHhTi2d0PvahcpIm0ebhHgfd8JfMAjVEBccs=; b=CQaiN+zHVn2+htnyiU7QCN5vF0RLJW8akjSgWNNJ6Hy53WCWiLXZn9utfb/ylmzcoc/4av Q6/KYc/UDRBueBAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5984213240; Wed, 24 Nov 2021 07:12:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VALhE/vlnWG5DAAAMHmgww (envelope-from ); Wed, 24 Nov 2021 07:12:59 +0000 Date: Wed, 24 Nov 2021 08:12:57 +0100 From: Petr Vorel To: Richard Palethorpe Message-ID: References: <20211123124348.31073-1-rpalethorpe@suse.com> <20211123124348.31073-2-rpalethorpe@suse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211123124348.31073-2-rpalethorpe@suse.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 1/3] tools/sparse: Add static check X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi Richie, > This was adapted from Sparse's inbuilt check_duplicates (-Wdecl). The > original check appears to print a warning whenever a symbol is > non-static, but has no prototype. It appears to work because library > symbols are usually declared first in a header file and then again > with their definition in a source file. > The LTP version also checks for the various library prefixes, but > should otherwise be the same. LGTM, thanks! Kind regards, Petr -- Mailing list info: https://lists.linux.it/listinfo/ltp