All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: HDMI isn't probed on v5.15-rc1 on ULCB+KF
Date: Wed, 24 Nov 2021 14:53:04 +0200	[thread overview]
Message-ID: <YZ41sPmt5VSLr9Y5@pendragon.ideasonboard.com> (raw)
In-Reply-To: <87ilxc1ibv.wl-kuninori.morimoto.gx@renesas.com>

Hello Morimoto-san,

Until I can get my ULCB to boot to test this here, I'll try to help you
debug the problem.

On Mon, Nov 01, 2021 at 03:49:24PM +0900, Kuninori Morimoto wrote:
> 
> Hi Laurent, again
> 
> About this topic, v5.15 was released, but it still
> has "No soundcards" issue.
> There is no dw-hdmi, thus no soundcards
> 
> 	...
> 	[    1.431196] printk: console [ttySC0] enabled
> =>	[    1.442432] rcar-du feb00000.display: failed to initialize DRM/KMS (-6)
> 	[    1.481179] loop: module loaded
> 	...
> 	[    9.568307] ALSA device list:
> =>	[    9.571446]   No soundcards found.
> 	...

Do you get any error message from the dw-hdmi driver ? In particular,
I'd like to know if the dw_hdmi_parse_dt() function fails. There are
error messages in all error paths but the last one, the following patch
may help debugging the problem.

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 54d8fdad395f..8be3a1042ede 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -3209,10 +3209,14 @@ static int dw_hdmi_parse_dt(struct dw_hdmi *hdmi)
 	}

 	hdmi->next_bridge = of_drm_find_bridge(remote);
-	of_node_put(remote);
-	if (!hdmi->next_bridge)
+	if (!hdmi->next_bridge) {
+		dev_err(hdmi->dev, "no bridge found for port@%u (%pOF)\n",
+			hdmi->plat_data->output_port, remote);
+		of_node_put(remote);
 		return -EPROBE_DEFER;
+	}

+	of_node_put(remote);
 	return 0;
 }

Is the CONFIG_DRM_DISPLAY_CONNECTOR option enabled in your kernel ?

> I re-start works for me if I reverted this patch
> 
> 	--------------------------------
> 	commit d0f44e0dac29aca3f85d238dfbcd2e52450b38dc
> 	Author: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 	Date:   Mon May 25 07:05:26 2020 +0300
> 
> 	    drm: rcar-du: dw-hdmi: Set output port number
> 
> 	    Report the DT output port number in dw_hdmi_plat_data to connect to the
> 	    next bridge in the dw-hdmi driver.
> 
> 	    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> 	    Tested-by: Kieran Bingham <kieran.bingham@ideasonboard.com> # On V3U
> 	    Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> 	--------------------------------
> 
> 	...
> 	[    1.431130] printk: console [ttySC0] enabled
> =>	[    1.442219] rcar-du feb00000.display: failed to initialize DRM/KMS (-6)
> =>	[    1.451050] rcar-dw-hdmi fead0000.hdmi: Detected HDMI TX controller v2.01a with HDCP (DWC HDMI 2.0 TX PHY)
> =>	[    1.461560] rcar-dw-hdmi fead0000.hdmi: registered DesignWare HDMI I2C bus driver
> 	[    1.501043] loop: module loaded
> 	...
> 	[    9.180464] ALSA device list:
> =>	[    9.183519]   #0: rcar-sound
> 	...

-- 
Regards,

Laurent Pinchart

  parent reply	other threads:[~2021-11-24 14:27 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-06  3:05 HDMI isn't probed on v5.15-rc1 on ULCB+KF Kuninori Morimoto
2021-10-07  3:52 ` Laurent Pinchart
2021-10-07  4:50   ` Kuninori Morimoto
2021-10-07  5:08     ` Laurent Pinchart
2021-10-07  5:12       ` Kuninori Morimoto
2021-11-01  6:49         ` Kuninori Morimoto
2021-11-11  0:35           ` Kuninori Morimoto
2021-11-24 12:43             ` Laurent Pinchart
2021-11-24 12:53           ` Laurent Pinchart [this message]
2021-10-07  7:24     ` Geert Uytterhoeven
2021-11-02 13:01       ` Kieran Bingham
     [not found]         ` <87bl302598.wl-kuninori.morimoto.gx@renesas.com>
2021-11-04  8:20           ` Kieran Bingham
2021-11-24 13:48           ` Laurent Pinchart
2021-11-25  0:23             ` Kuninori Morimoto
2021-12-03  6:35               ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZ41sPmt5VSLr9Y5@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.