All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Suarez <cssk@net-c.es>
To: "Sam Ravnborg" <sam@ravnborg.org>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name
Date: Sun, 14 Nov 2021 18:34:53 +0100	[thread overview]
Message-ID: <YZFIvfY1j0f3pVQt@gineta.localdomain> (raw)
In-Reply-To: <YZAikieq4bwrJ58c@ravnborg.org>

On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote:
> Hi Claudio,
> 
> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote:
> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in
> > drm core programs.
> > 
> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Signed-off-by: Claudio Suarez <cssk@net-c.es>
> 
> While touching all these logging calls, could you convernt them to the
> newer drm_dbg_kms variants?
> DRM_DEBUG_* are all deprecated.
> 

Yes, I can, but it is recommended to do it in a different patch:

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes

C&P:
"Separate your changes
Separate each logical change into a separate patch.
For example, if your changes include both bug fixes and performance enhancements..."


I will study and send a new separate patch with your suggestion.

Best regards,
Claudio Suarez




  reply	other threads:[~2021-11-14 17:35 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-13 19:27 [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name Claudio Suarez
2021-11-13 20:39 ` Sam Ravnborg
2021-11-14 17:34   ` Claudio Suarez [this message]
2021-11-15 10:24     ` Jani Nikula
2021-11-15 19:40       ` Claudio Suarez
2021-11-15 20:17         ` Jani Nikula
2021-11-16 16:55           ` Claudio Suarez
2021-11-18  3:41         ` jim.cromie
2021-11-14 17:22 ` Claudio Suarez
2021-11-14 17:25 ` Claudio Suarez
2021-11-15 10:22 ` Jani Nikula
2021-11-15 10:24   ` Simon Ser
2021-11-15 10:38     ` Jani Nikula
2021-11-15 19:02   ` Claudio Suarez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZFIvfY1j0f3pVQt@gineta.localdomain \
    --to=cssk@net-c.es \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sam@ravnborg.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.