All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Lukas Wunner <lukas@wunner.de>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	kw@linux.com
Subject: Re: [PATCH v1 1/1] PCI: probe: Use pci_find_vsec_capability() when looking for TBT devices
Date: Mon, 15 Nov 2021 12:33:47 +0200	[thread overview]
Message-ID: <YZI3iyo6qM8MnT5f@smile.fi.intel.com> (raw)
In-Reply-To: <20211114062231.GA10937@wunner.de>

On Sun, Nov 14, 2021 at 07:22:31AM +0100, Lukas Wunner wrote:
> On Tue, Nov 09, 2021 at 05:16:04PM +0200, Andy Shevchenko wrote:

...

> > -		/* Is the device part of a Thunderbolt controller? */
> 
> Could you preserve that code comment please so that an uninitiated
> reader knows what the is_thunderbolt flag is about?

Sure!

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2021-11-15 10:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-09 15:16 [PATCH v1 1/1] PCI: probe: Use pci_find_vsec_capability() when looking for TBT devices Andy Shevchenko
2021-11-14  3:31 ` Krzysztof Wilczyński
2021-11-15 10:33   ` Andy Shevchenko
2021-11-15 12:10     ` Krzysztof Wilczyński
2021-11-14  6:22 ` Lukas Wunner
2021-11-15 10:33   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZI3iyo6qM8MnT5f@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.