From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA9F272 for ; Mon, 15 Nov 2021 09:15:41 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2837F9CA; Mon, 15 Nov 2021 10:10:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967417; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnjNnE+BxQubVBzyvt35tp9eSPunAc+NOuowzVjMVfnO6jqLw3nMEngEl53CjbMh0 UYxBQSy9hDC4AXM+j7bivGr1bDYL75caLR3Kpvgip4jQNeMxX1tvkF1//Xh3honHLn XZyCAuT51XsudJZ+zXrp60OeLJ0gprUub8NgbGw0= Date: Mon, 15 Nov 2021 11:09:54 +0200 From: Laurent Pinchart To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-5-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211115085403.360194-5-arnd@kernel.org> Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The slave device is picked through either devicetree or a filter > function, and any remaining out-of-tree drivers would have warned > about this usage since 2015. > > Stop interpreting the field finally so it can be removed from > the interface. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/shdma-base.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 7f72b3f4cd1a..41c6bc650fa3 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -786,14 +786,6 @@ static int shdma_config(struct dma_chan *chan, > if (!config) > return -EINVAL; > > - /* > - * overriding the slave_id through dma_slave_config is deprecated, > - * but possibly some out-of-tree drivers still do it. > - */ > - if (WARN_ON_ONCE(config->slave_id && > - config->slave_id != schan->real_slave_id)) > - schan->real_slave_id = config->slave_id; > - > /* > * We could lock this, but you shouldn't be configuring the > * channel, while using it... -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA8D5C433EF for ; Mon, 15 Nov 2021 09:10:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7604360E0C for ; Mon, 15 Nov 2021 09:10:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7604360E0C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 860AD6EC7D; Mon, 15 Nov 2021 09:10:20 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 788066EC7D for ; Mon, 15 Nov 2021 09:10:19 +0000 (UTC) Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2837F9CA; Mon, 15 Nov 2021 10:10:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967417; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnjNnE+BxQubVBzyvt35tp9eSPunAc+NOuowzVjMVfnO6jqLw3nMEngEl53CjbMh0 UYxBQSy9hDC4AXM+j7bivGr1bDYL75caLR3Kpvgip4jQNeMxX1tvkF1//Xh3honHLn XZyCAuT51XsudJZ+zXrp60OeLJ0gprUub8NgbGw0= Date: Mon, 15 Nov 2021 11:09:54 +0200 From: Laurent Pinchart To: Arnd Bergmann Subject: Re: [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-5-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211115085403.360194-5-arnd@kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, Robert Jarzmik , Chunyan Zhang , linux-staging@lists.linux.dev, Michal Simek , Jon Hunter , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Orson Zhai , Nicolas Saenz Julienne , Arnd Bergmann , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, Mark Brown , linux-rpi-kernel@lists.infradead.org, Jaroslav Kysela , Andy Shevchenko , linux-arm-kernel@lists.infradead.org, Scott Branden , Hyun Kwon , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Laxman Dewangan , Baolin Wang Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The slave device is picked through either devicetree or a filter > function, and any remaining out-of-tree drivers would have warned > about this usage since 2015. > > Stop interpreting the field finally so it can be removed from > the interface. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/shdma-base.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 7f72b3f4cd1a..41c6bc650fa3 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -786,14 +786,6 @@ static int shdma_config(struct dma_chan *chan, > if (!config) > return -EINVAL; > > - /* > - * overriding the slave_id through dma_slave_config is deprecated, > - * but possibly some out-of-tree drivers still do it. > - */ > - if (WARN_ON_ONCE(config->slave_id && > - config->slave_id != schan->real_slave_id)) > - schan->real_slave_id = config->slave_id; > - > /* > * We could lock this, but you shouldn't be configuring the > * channel, while using it... -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827E5C433EF for ; Mon, 15 Nov 2021 09:33:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 476CB61A89 for ; Mon, 15 Nov 2021 09:33:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 476CB61A89 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/klDunr44j1Y3xUg/U20J1Yl2NWyKs0v7vdtSGqE9Fc=; b=oIgqmA0sE/zctO u08WKMR7pLodAKUpcKTw9/0rO01pxGvBaKHlFOH7UWcOaiK4NsVO2F1XKjPJN9+OO6WvcFfHvCf/o H8ra+gRE4n7li45VMIpsCH9P/1tvNjHt6/XHdMiNAEq8uR/dtd+zRm2J39R0ZLzgwkcJbWeLh9xk8 HG2wZZHsFOx3JNnbm7B26iQNLYrey2oyMxZssnf1v+eHdZxkKx40u3z+GvedQ7Kf3iYCurc5KqqPe /Qzi+f/0x8+rZwvDXOHgzGUPfDifPvanlyqFo+JlbsR2xGyH4jTgnthiQeUT5UY978zlK43nzG5rk +B9dzQShIFInZ0ihjLqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmYML-00EwlJ-M2; Mon, 15 Nov 2021 09:33:06 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmY0L-00Er3G-Q7; Mon, 15 Nov 2021 09:10:23 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2837F9CA; Mon, 15 Nov 2021 10:10:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967417; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnjNnE+BxQubVBzyvt35tp9eSPunAc+NOuowzVjMVfnO6jqLw3nMEngEl53CjbMh0 UYxBQSy9hDC4AXM+j7bivGr1bDYL75caLR3Kpvgip4jQNeMxX1tvkF1//Xh3honHLn XZyCAuT51XsudJZ+zXrp60OeLJ0gprUub8NgbGw0= Date: Mon, 15 Nov 2021 11:09:54 +0200 From: Laurent Pinchart To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-5-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211115085403.360194-5-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211115_011022_051103_933E126D X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The slave device is picked through either devicetree or a filter > function, and any remaining out-of-tree drivers would have warned > about this usage since 2015. > > Stop interpreting the field finally so it can be removed from > the interface. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/shdma-base.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 7f72b3f4cd1a..41c6bc650fa3 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -786,14 +786,6 @@ static int shdma_config(struct dma_chan *chan, > if (!config) > return -EINVAL; > > - /* > - * overriding the slave_id through dma_slave_config is deprecated, > - * but possibly some out-of-tree drivers still do it. > - */ > - if (WARN_ON_ONCE(config->slave_id && > - config->slave_id != schan->real_slave_id)) > - schan->real_slave_id = config->slave_id; > - > /* > * We could lock this, but you shouldn't be configuring the > * channel, while using it... -- Regards, Laurent Pinchart ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7F5BC433FE for ; Mon, 15 Nov 2021 09:33:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F2E163237 for ; Mon, 15 Nov 2021 09:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F2E163237 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FQ9x9988ly+gZxLtEvhTjb9VFt9Qqz0Kbx41x5x8LPE=; b=iy9AcD7EVIGC4W NuhvBfM6o3Buv41PbcUB2qGGz071xtwOEI2eczRx7jd0OPCoDXfq3b5An366+HdRutSAd/IywEEbA AysWi60S/prZib1d5DOOVq/JdIgNcoYEd3rNgkqGYh3on0aBOfhRr0nM/iMsxCVh2D0YL4zx+LQcE CBsAr4cdfUXwhpaR4SmnhY9/WXvNwK8iwZ3N3hZ7UL7PyNj5lsJ9y2YZTeMAqjK9FznYwjesYzRCx 9s8q/2tX+BzN19W8DkeCjzzq08dCN6oLpnSF+jVpPDP3BmyFr8LOPu8cw+g4wHeVuhE1cVEqh49LP Cu6WEp+WxVKg26WYVxLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmYKq-00EwL4-Lk; Mon, 15 Nov 2021 09:31:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mmY0L-00Er3G-Q7; Mon, 15 Nov 2021 09:10:23 +0000 Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2837F9CA; Mon, 15 Nov 2021 10:10:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967417; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnjNnE+BxQubVBzyvt35tp9eSPunAc+NOuowzVjMVfnO6jqLw3nMEngEl53CjbMh0 UYxBQSy9hDC4AXM+j7bivGr1bDYL75caLR3Kpvgip4jQNeMxX1tvkF1//Xh3honHLn XZyCAuT51XsudJZ+zXrp60OeLJ0gprUub8NgbGw0= Date: Mon, 15 Nov 2021 11:09:54 +0200 From: Laurent Pinchart To: Arnd Bergmann Cc: Vinod Koul , Arnd Bergmann , Andy Gross , Andy Shevchenko , Baolin Wang , Bjorn Andersson , Chunyan Zhang , Greg Kroah-Hartman , Hyun Kwon , Jaroslav Kysela , Jon Hunter , Lars-Peter Clausen , Laxman Dewangan , Manivannan Sadhasivam , Mark Brown , Michal Simek , Nicolas Saenz Julienne , Orson Zhai , Robert Jarzmik , Scott Branden , Takashi Iwai , Thierry Reding , alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, dmaengine@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org Subject: Re: [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-5-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211115085403.360194-5-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211115_011022_051103_933E126D X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The slave device is picked through either devicetree or a filter > function, and any remaining out-of-tree drivers would have warned > about this usage since 2015. > > Stop interpreting the field finally so it can be removed from > the interface. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/shdma-base.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 7f72b3f4cd1a..41c6bc650fa3 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -786,14 +786,6 @@ static int shdma_config(struct dma_chan *chan, > if (!config) > return -EINVAL; > > - /* > - * overriding the slave_id through dma_slave_config is deprecated, > - * but possibly some out-of-tree drivers still do it. > - */ > - if (WARN_ON_ONCE(config->slave_id && > - config->slave_id != schan->real_slave_id)) > - schan->real_slave_id = config->slave_id; > - > /* > * We could lock this, but you shouldn't be configuring the > * channel, while using it... -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D650EC433F5 for ; Thu, 18 Nov 2021 16:34:01 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43B9B61A58 for ; Thu, 18 Nov 2021 16:33:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 43B9B61A58 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C9BCD17E9; Thu, 18 Nov 2021 17:33:07 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C9BCD17E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1637253237; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=aCAfOjeWLRsX2uB8Wae97LEnoAewCiJnDUox0w8kk7IbVOYT77urAiCiFCYQQAbRN RszhYc7iiC/kOCRdMbDy+FqEE76izmnAIh23MYpolm4cEd9VT85HGaHwIM07PxRmFC axazXt6Jjrl1yC3+CaOvYuin1dvXktUZS71cE7eY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5A8ECF8010B; Thu, 18 Nov 2021 17:33:07 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9279CF8027D; Mon, 15 Nov 2021 10:10:33 +0100 (CET) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 338A8F800FA for ; Mon, 15 Nov 2021 10:10:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 338A8F800FA Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="dnjNnE+B" Received: from pendragon.ideasonboard.com (117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2837F9CA; Mon, 15 Nov 2021 10:10:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1636967417; bh=bs5FwrGJKmZiUyJUhZtsFFkCbThCR2+MNX7sYGLdInI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dnjNnE+BxQubVBzyvt35tp9eSPunAc+NOuowzVjMVfnO6jqLw3nMEngEl53CjbMh0 UYxBQSy9hDC4AXM+j7bivGr1bDYL75caLR3Kpvgip4jQNeMxX1tvkF1//Xh3honHLn XZyCAuT51XsudJZ+zXrp60OeLJ0gprUub8NgbGw0= Date: Mon, 15 Nov 2021 11:09:54 +0200 From: Laurent Pinchart To: Arnd Bergmann Subject: Re: [PATCH 04/11] dmaengine: shdma: remove legacy slave_id parsing Message-ID: References: <20211115085403.360194-1-arnd@kernel.org> <20211115085403.360194-5-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211115085403.360194-5-arnd@kernel.org> X-Mailman-Approved-At: Thu, 18 Nov 2021 17:33:03 +0100 Cc: alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-tegra@vger.kernel.org, Thierry Reding , linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org, Robert Jarzmik , Lars-Peter Clausen , Chunyan Zhang , linux-staging@lists.linux.dev, Michal Simek , Jon Hunter , Andy Gross , bcm-kernel-feedback-list@broadcom.com, linux-serial@vger.kernel.org, Orson Zhai , Nicolas Saenz Julienne , Arnd Bergmann , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, Mark Brown , linux-rpi-kernel@lists.infradead.org, Andy Shevchenko , linux-arm-kernel@lists.infradead.org, Scott Branden , Hyun Kwon , Greg Kroah-Hartman , linux-mmc@vger.kernel.org, Takashi Iwai , linux-kernel@vger.kernel.org, Vinod Koul , Laxman Dewangan , Baolin Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Arnd, Thank you for the patch. On Mon, Nov 15, 2021 at 09:53:56AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > The slave device is picked through either devicetree or a filter > function, and any remaining out-of-tree drivers would have warned > about this usage since 2015. > > Stop interpreting the field finally so it can be removed from > the interface. > > Signed-off-by: Arnd Bergmann Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/shdma-base.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 7f72b3f4cd1a..41c6bc650fa3 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -786,14 +786,6 @@ static int shdma_config(struct dma_chan *chan, > if (!config) > return -EINVAL; > > - /* > - * overriding the slave_id through dma_slave_config is deprecated, > - * but possibly some out-of-tree drivers still do it. > - */ > - if (WARN_ON_ONCE(config->slave_id && > - config->slave_id != schan->real_slave_id)) > - schan->real_slave_id = config->slave_id; > - > /* > * We could lock this, but you shouldn't be configuring the > * channel, while using it... -- Regards, Laurent Pinchart