Re: [PATCH v4 2/3] driver core: Don't call device_remove_properties() from device_del()

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Zhangfei Gao <zhangfei.gao@linaro.org>,
	linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH v4 2/3] driver core: Don't call device_remove_properties() from device_del()
Date: Mon, 15 Nov 2021 16:24:52 +0200	[thread overview]
Message-ID: <YZJttIYTV+wdpJlx@smile.fi.intel.com> (raw)
In-Reply-To: <20211115121001.77041-3-heikki.krogerus@linux.intel.com>

On Mon, Nov 15, 2021 at 03:10:00PM +0300, Heikki Krogerus wrote:
> All the drivers that relied on device_del() to call
> device_remove_properties() have now been converted to either
> use device_create_managed_software_node() instead of
> device_add_properties(), or to register the software node
> completely separately from the device.
> 
> This will make it finally possible to share and reuse the
> software nodes that hold the additional device properties.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  drivers/base/core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index fd034d7424472..a40b6fb1ebb01 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -3582,7 +3582,6 @@ void device_del(struct device *dev)
>  	device_pm_remove(dev);
>  	driver_deferred_probe_del(dev);
>  	device_platform_notify_remove(dev);
> -	device_remove_properties(dev);
>  	device_links_purge(dev);
>  
>  	if (dev->bus)
> -- 
> 2.33.0
> 

-- 
With Best Regards,
Andy Shevchenko