From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CD26C3A589 for ; Mon, 15 Nov 2021 19:40:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D937F61B3F for ; Mon, 15 Nov 2021 19:40:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D937F61B3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=net-c.es Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05C9B6E2D5; Mon, 15 Nov 2021 19:40:27 +0000 (UTC) Received: from msg-4.mailo.com (ip-15.mailobj.net [213.182.54.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20B586E2D5 for ; Mon, 15 Nov 2021 19:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=net-c.es; s=mailo; t=1637005214; bh=DQWfoW6Uy+7g3oQloLB0fs087g2yJkpLOtLI3xn1NyY=; h=X-EA-Auth:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To; b=ey2rHlD1Fmelc8dn5FtI1ZnrsZW+oh12FE4v+Hleiv8SK/1n+WZcKGAHnutVhda50 2CsBPp555xAMx1XREfY1CnXYjlpDGYdQVVpRcQRbNqRlzuPbarJHtjp2A3guQUqczQ 9INOoxyRWvl6ean2SsxTcku5D4JoSiMM3FLd8KpI= Received: by b-2.in.mailobj.net [192.168.90.12] with ESMTP via ip-206.mailobj.net [213.182.55.206] Mon, 15 Nov 2021 20:40:14 +0100 (CET) X-EA-Auth: 3h3b4Irtuev6Yy+Y6tzFLPgHuSL7tz7pGdXiOo328vMfBlJrvfnUxrwBOSqLkQkaVQUeFInRGCJ+HKDhjHylfAk32ajcFQhU Date: Mon, 15 Nov 2021 20:40:12 +0100 From: Claudio Suarez To: Jani Nikula Subject: Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name Message-ID: References: <87fsrx3eed.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87fsrx3eed.fsf@intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Nov 15, 2021 at 12:24:26PM +0200, Jani Nikula wrote: > On Sun, 14 Nov 2021, Claudio Suarez wrote: > > On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote: > >> Hi Claudio, > >> > >> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote: > >> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in > >> > drm core programs. > >> > > >> > Suggested-by: Ville Syrjälä > >> > Signed-off-by: Claudio Suarez > >> > >> While touching all these logging calls, could you convernt them to the > >> newer drm_dbg_kms variants? > >> DRM_DEBUG_* are all deprecated. > >> > > > > Yes, I can, but it is recommended to do it in a different patch: > > > > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes > > > > C&P: > > "Separate your changes > > Separate each logical change into a separate patch. > > For example, if your changes include both bug fixes and performance enhancements..." > > > > > > I will study and send a new separate patch with your suggestion. > > I feel these logging changes are the types of changes where I'd err on > the side of fewer patches than strictly following the above guidelines. To size the problem: - there are about 3434 references to DRM_DEBUG_* in all the drm code, all drivers. - there are 413 references to DRM_DEBUG_* in the drm core code, only 66 of them are related to connectors. - there are 62 references to DRM_ERR* and 7 references to DRM_INFO in the drm core programs. I meant I can make two patches: 1 - this one with the change to CONNECTOR:id:name (29 changes) 2 - a new and bigger patch to change 413 + 62 + 7 references to DRM_{DEBUG,ERR,INFO} in the drm core programs. The second patch will be ready in a few days. Is it a good plan ? or can it be improved ? Best regards, Claudio Suarez.