From: Keith Busch <kbusch@kernel.org>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: Hannes Reinecke <hare@suse.de>, Sagi Grimberg <sagi@grimberg.me>,
Keith Busch <keith.busch@wdc.com>, Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme: honour O_NONBLOCK during resetting
Date: Mon, 15 Nov 2021 19:18:32 -0700 [thread overview]
Message-ID: <YZMU+DUJpsD7uMHY@C02CK6ZVMD6M> (raw)
In-Reply-To: <9c8da771-c5f9-923c-4c03-5d5ac8392ef8@nvidia.com>
On Tue, Nov 16, 2021 at 01:40:04AM +0000, Chaitanya Kulkarni wrote:
> On 11/11/2021 2:59 AM, Hannes Reinecke wrote:
> > When opening a controller device node we should honour the O_NONBLOCK
> > flag to allow the device to be openend even if it's in state 'resetting'
> > or 'connecting'. This allows user-space applications to use a call to 'open'
> > to figure out if the controller is present, even if it's currently
> > undergoing a reset.
> >
> > Signed-off-by: Hannes Reinecke <hare@suse.de>
>
> Will resetting and connecting ever result is deleting the controller due
> to error cases present in that path ?
>
> If yes then application will have handle for something that might
> go away in the future, should allow such a semantic ?
Resets can happen at any time, so they already have to handle it even if the
controller was live when they opened it. Perhaps the open should succeed for
any non-terminal state.
next prev parent reply other threads:[~2021-11-16 2:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-11 10:59 [PATCH] nvme: honour O_NONBLOCK during resetting Hannes Reinecke
2021-11-16 1:40 ` Chaitanya Kulkarni
2021-11-16 2:18 ` Keith Busch [this message]
2021-11-16 6:54 ` Hannes Reinecke
2021-11-16 6:52 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZMU+DUJpsD7uMHY@C02CK6ZVMD6M \
--to=kbusch@kernel.org \
--cc=chaitanyak@nvidia.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=keith.busch@wdc.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.