From: Michal Hocko <mhocko@suse.com>
To: Suren Baghdasaryan <surenb@google.com>
Cc: akpm@linux-foundation.org,
Alexey Alexandrov <aalexand@google.com>,
ccross@google.com, sumit.semwal@linaro.org,
dave.hansen@intel.com, keescook@chromium.org,
willy@infradead.org, kirill.shutemov@linux.intel.com,
vbabka@suse.cz, hannes@cmpxchg.org, corbet@lwn.net,
viro@zeniv.linux.org.uk, rdunlap@infradead.org,
kaleshsingh@google.com, peterx@redhat.com, rppt@kernel.org,
peterz@infradead.org, catalin.marinas@arm.com,
vincenzo.frascino@arm.com, chinwen.chang@mediatek.com,
axelrasmussen@google.com, aarcange@redhat.com, jannh@google.com,
apopple@nvidia.com, jhubbard@nvidia.com, yuzhao@google.com,
will@kernel.org, fenghua.yu@intel.com,
thunder.leizhen@huawei.com, hughd@google.com,
feng.tang@intel.com, jgg@ziepe.ca, guro@fb.com,
tglx@linutronix.de, krisman@collabora.com,
chris.hyser@oracle.com, pcc@google.com, ebiederm@xmission.com,
axboe@kernel.dk, legion@kernel.org, eb@emlix.com,
gorcunov@gmail.com, pavel@ucw.cz, songmuchun@bytedance.com,
viresh.kumar@linaro.org, thomascedeno@google.com,
sashal@kernel.org, cxfcosmos@gmail.com, linux@rasmusvillemoes.dk,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, linux-mm@kvack.org,
kernel-team@android.com
Subject: Re: [PATCH v11 2/3] mm: add a field to store names for private anonymous memory
Date: Tue, 16 Nov 2021 10:51:00 +0100 [thread overview]
Message-ID: <YZN/BMImQqrK4MWm@dhcp22.suse.cz> (raw)
In-Reply-To: <CAJuCfpEJuVyRfjEE-NTsVkdCZyd6P09gHu7c+tbZcipk+73rLA@mail.gmail.com>
On Mon 15-11-21 10:59:20, Suren Baghdasaryan wrote:
[...]
> Hi Andrew,
> I haven't seen any feedback on my patchset for some time now. I think
> I addressed all the questions and comments (please correct me if I
> missed anything).
I believe the strings vs. ids have been mostly hand waved away. The
biggest argument for the former was convenience for developers to have
something human readable. There was no actual proposal about the naming
convention so we are relying on some unwritten rules or knowledge of the
code to be debugged to make human readable string human understandable
ones. I believe this has never been properly resolved except for - this
has been used in Android and working just fine. I am not convinced TBH.
So in the end we are adding a user interface that brings a runtime and
resource overhead that will be hard to change in the future. Reference
counting handles a part of that and that is nice but ids simply do not
have any of that.
> Can it be accepted as is or is there something I should address
> further?
Is the above reason to nack it? No, I do not think so. I just do not
feel like I want to ack it either. Concerns have been expressed and I
have to say that I would like a minimalistic approach much more. Also
extending ids into string is always possible. The other way around is
not possible.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2021-11-16 9:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 21:55 [PATCH v11 1/3] mm: rearrange madvise code to allow for reuse Suren Baghdasaryan
2021-10-19 21:55 ` [PATCH v11 2/3] mm: add a field to store names for private anonymous memory Suren Baghdasaryan
2021-10-19 21:58 ` Suren Baghdasaryan
2021-11-16 5:19 ` Andrew Morton
2021-11-16 6:10 ` Suren Baghdasaryan
2021-10-27 18:35 ` Alexey Alexandrov
2021-10-27 20:01 ` Suren Baghdasaryan
2021-10-28 22:08 ` Suren Baghdasaryan
2021-11-15 18:59 ` Suren Baghdasaryan
2021-11-16 9:51 ` Michal Hocko [this message]
2021-11-16 16:29 ` Suren Baghdasaryan
2021-10-19 21:55 ` [PATCH v11 3/3] mm: add anonymous vma name refcounting Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZN/BMImQqrK4MWm@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=aalexand@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=axboe@kernel.dk \
--cc=axelrasmussen@google.com \
--cc=catalin.marinas@arm.com \
--cc=ccross@google.com \
--cc=chinwen.chang@mediatek.com \
--cc=chris.hyser@oracle.com \
--cc=corbet@lwn.net \
--cc=cxfcosmos@gmail.com \
--cc=dave.hansen@intel.com \
--cc=eb@emlix.com \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gorcunov@gmail.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kaleshsingh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=krisman@collabora.com \
--cc=legion@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pavel@ucw.cz \
--cc=pcc@google.com \
--cc=peterx@redhat.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=sashal@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=sumit.semwal@linaro.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=thomascedeno@google.com \
--cc=thunder.leizhen@huawei.com \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=viresh.kumar@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.