From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F2B5C433F5 for ; Tue, 16 Nov 2021 14:16:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 157B661C15 for ; Tue, 16 Nov 2021 14:16:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237325AbhKPOTH (ORCPT ); Tue, 16 Nov 2021 09:19:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:39566 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237135AbhKPOSh (ORCPT ); Tue, 16 Nov 2021 09:18:37 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D745661C15; Tue, 16 Nov 2021 14:15:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1637072137; bh=ARYZ/KAk+Sx6/zGZBiU8VPwpSlxLHxlxlM4y0Rsa1Lo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hx5Eqn1ufpAwBFR0hl+jBrXdoy+l6JZhrbrqKpU8O8BzrxjhJK81R1Tg2ZypIfNQr D0JSJpCdSZNA73cMsHLwof056uh6mCJ4DLZORD/YVAe8aNFDGzCxxmIIZ5s3dfxLQ6 GAdemop4nd257CerWGEKMgbard0yzz9mHyBKx798= Date: Tue, 16 Nov 2021 15:15:34 +0100 From: Greg Kroah-Hartman To: Andreas Gruenbacher Cc: Sasha Levin , LKML , stable , Mathieu Malaterre , Paul Mackerras , kvm-ppc@vger.kernel.org Subject: Re: [PATCH 5.4 063/355] powerpc/kvm: Fix kvm_use_magic_page Message-ID: References: <20211115165313.549179499@linuxfoundation.org> <20211115165315.847107930@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 16, 2021 at 03:00:19PM +0100, Andreas Gruenbacher wrote: > On Tue, Nov 16, 2021 at 2:57 PM Greg Kroah-Hartman > wrote: > > On Tue, Nov 16, 2021 at 02:54:10PM +0100, Andreas Gruenbacher wrote: > > > On Tue, Nov 16, 2021 at 1:54 AM Sasha Levin wrote: > > > > On Mon, Nov 15, 2021 at 06:47:41PM +0100, Andreas Gruenbacher wrote: > > > > >Greg, > > > > > > > > > >On Mon, Nov 15, 2021 at 6:10 PM Greg Kroah-Hartman > > > > > wrote: > > > > >> From: Andreas Gruenbacher > > > > >> > > > > >> commit 0c8eb2884a42d992c7726539328b7d3568f22143 upstream. > > > > >> > > > > >> When switching from __get_user to fault_in_pages_readable, commit > > > > >> 9f9eae5ce717 broke kvm_use_magic_page: like __get_user, > > > > >> fault_in_pages_readable returns 0 on success. > > > > > > > > > >I've not heard back from the maintainers about this patch so far, so > > > > >it would probably be safer to leave it out of stable for now. > > > > > > > > What do you mean exactly? It's upstream. > > > > > > Mathieu Malaterre broke this test in 2018 (commit 9f9eae5ce717) but > > > that wasn't noticed until now (commit 0c8eb2884a42). This means that > > > this fix probably isn't critical, so I shouldn't be backported. > > > > Then why did you tag it to be explicitly backported to all stable > > kernels newer than 4.18? > > Well, sorry for that. What else do you expect me to do in addition to > pointing out the mistake? Ah, I think we are misunderstanding each other here. I will go drop it, but in the future maybe "hey, I didn't mean to mark this for stable, can you please drop it?" might be a bit more direct and too the point. Otherwise we are all confused here... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Tue, 16 Nov 2021 14:15:34 +0000 Subject: Re: [PATCH 5.4 063/355] powerpc/kvm: Fix kvm_use_magic_page Message-Id: List-Id: References: <20211115165313.549179499@linuxfoundation.org> <20211115165315.847107930@linuxfoundation.org> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Gruenbacher Cc: Sasha Levin , LKML , stable , Mathieu Malaterre , Paul Mackerras , kvm-ppc@vger.kernel.org On Tue, Nov 16, 2021 at 03:00:19PM +0100, Andreas Gruenbacher wrote: > On Tue, Nov 16, 2021 at 2:57 PM Greg Kroah-Hartman > wrote: > > On Tue, Nov 16, 2021 at 02:54:10PM +0100, Andreas Gruenbacher wrote: > > > On Tue, Nov 16, 2021 at 1:54 AM Sasha Levin wrote: > > > > On Mon, Nov 15, 2021 at 06:47:41PM +0100, Andreas Gruenbacher wrote: > > > > >Greg, > > > > > > > > > >On Mon, Nov 15, 2021 at 6:10 PM Greg Kroah-Hartman > > > > > wrote: > > > > >> From: Andreas Gruenbacher > > > > >> > > > > >> commit 0c8eb2884a42d992c7726539328b7d3568f22143 upstream. > > > > >> > > > > >> When switching from __get_user to fault_in_pages_readable, commit > > > > >> 9f9eae5ce717 broke kvm_use_magic_page: like __get_user, > > > > >> fault_in_pages_readable returns 0 on success. > > > > > > > > > >I've not heard back from the maintainers about this patch so far, so > > > > >it would probably be safer to leave it out of stable for now. > > > > > > > > What do you mean exactly? It's upstream. > > > > > > Mathieu Malaterre broke this test in 2018 (commit 9f9eae5ce717) but > > > that wasn't noticed until now (commit 0c8eb2884a42). This means that > > > this fix probably isn't critical, so I shouldn't be backported. > > > > Then why did you tag it to be explicitly backported to all stable > > kernels newer than 4.18? > > Well, sorry for that. What else do you expect me to do in addition to > pointing out the mistake? Ah, I think we are misunderstanding each other here. I will go drop it, but in the future maybe "hey, I didn't mean to mark this for stable, can you please drop it?" might be a bit more direct and too the point. Otherwise we are all confused here... thanks, greg k-h