From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E39CC433F5 for ; Thu, 18 Nov 2021 05:55:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 19BD66126A for ; Thu, 18 Nov 2021 05:55:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 19BD66126A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 28BBB6E9B5; Thu, 18 Nov 2021 05:55:33 +0000 (UTC) Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1E9BB6E9B5 for ; Thu, 18 Nov 2021 05:55:32 +0000 (UTC) Received: by mail-pf1-x432.google.com with SMTP id m14so4876159pfc.9 for ; Wed, 17 Nov 2021 21:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=UHufCLPWyoOczeZ10rpOHREDHnb3KpiCBx3l1fTQm5RvUKFPfoiV3nIdNI1zko70SG /rKe8N7G0c0n05WH2WbNalEhgCbNcRUSas8ntyCf23nZUCkn6i9wCai27/OIwEMEJyOv ThePhBf4AWclUuOtatuS2nfw5iiz775JEIGgnd/uYe4rXrmhZLY9uVjezatexQW9zJlr f/ua1KJym4YKdxaoZO7i5Sm2rmE52E/ZEveHM3ZGMEyCS4qLoJEPYgizR4iGB0ez384E 65/JeZxmXvJ2XZODMZNCnYNZLTvHyi9Vh/6xPx5IAmj5cvI8gu2XavIl9F9ECYt2hs+g UB9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=mtIwJNBPZmsxEU4+QLHfCNdfZ6DRE0yqbKesqzz7gsf6GC5t8+M+51G/5r82Zpw7V+ cuGDkHSYR6P6TMCCQkhpIFc/HRoUeYZasO1ih75vX2YX/77R7LXiQXE2DCDkMDrMAmzh T4NbR9dyiXrhhFJqhRctIzVtzcDCUuMFz1w9gDhjHtkMHuJxJ5ANttkhiFK3Kk0fZYaF 6yaXI17nP4IjY3nBf0UFWMpdQNBNSbdpKbhQpGp40MDm/ZUkCq6pGCPQ/D86o3hD/5H1 DptFsKxcHu+mcZ5RVH+yix5gWn+R5Z4WCNLMPvIpfaOhSsPb2emIEQr1cyeI2TzCyVHh B61A== X-Gm-Message-State: AOAM533OzU0WVnVYEg3yXwSXEnDw/mju9HrbjDzY7vXFGlHPB1td5qkk y8N/7rVxYt2PnKHiqiR9X1FGLw== X-Google-Smtp-Source: ABdhPJw1U92hefuFRAL0GmhDcNMuPQUVRaJ5rI4xhjzGg+pVLc+xkbJYl2Vby+uLLS0FJI1gYbeHXQ== X-Received: by 2002:a05:6a00:23c8:b0:49f:e054:84d7 with SMTP id g8-20020a056a0023c800b0049fe05484d7mr53924075pfc.50.1637214931490; Wed, 17 Nov 2021 21:55:31 -0800 (PST) Received: from google.com ([2401:fa00:1:10:8f8:11d:a96a:74d2]) by smtp.gmail.com with ESMTPSA id u9sm1547277pfi.23.2021.11.17.21.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 21:55:31 -0800 (PST) Date: Thu, 18 Nov 2021 13:55:27 +0800 From: Tzung-Bi Shih To: "jason-jh.lin" Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Message-ID: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117064158.27451-4-jason-jh.lin@mediatek.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , fshao@chromium.org, David Airlie , singo.chang@mediatek.com, Jassi Brar , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, nancy.lin@mediatek.com, linux-mediatek@lists.infradead.org, hsinyi@chromium.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct drm_crtc *crtc) > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > if (mtk_crtc->cmdq_client.chan) { > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc->cmdq_client.chan->mbox->dev); > mbox_free_channel(mtk_crtc->cmdq_client.chan); > mtk_crtc->cmdq_client.chan = NULL; > } [...] > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > } > > if (mtk_crtc->cmdq_client.chan) { > + struct device_link *link; > + > + /* add devlink to cmdq dev to make sure suspend/resume order is correct */ > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan->mbox->dev, > + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS); > + if (!link) { > + dev_err(dev, "Unable to link dev=%s\n", > + dev_name(mtk_crtc->cmdq_client.chan->mbox->dev)); > + } > + If device_link_add() failed, doesn't mtk_drm_crtc_create() need to return an error and exit? OTOH, if device_link_add() failed, won't it bring any side effects to call device_link_remove()? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A1B5C433EF for ; Thu, 18 Nov 2021 05:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 33D8461B3D for ; Thu, 18 Nov 2021 05:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243223AbhKRF6n (ORCPT ); Thu, 18 Nov 2021 00:58:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243222AbhKRF6b (ORCPT ); Thu, 18 Nov 2021 00:58:31 -0500 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D921C061570 for ; Wed, 17 Nov 2021 21:55:32 -0800 (PST) Received: by mail-pg1-x52d.google.com with SMTP id r5so4397794pgi.6 for ; Wed, 17 Nov 2021 21:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=UHufCLPWyoOczeZ10rpOHREDHnb3KpiCBx3l1fTQm5RvUKFPfoiV3nIdNI1zko70SG /rKe8N7G0c0n05WH2WbNalEhgCbNcRUSas8ntyCf23nZUCkn6i9wCai27/OIwEMEJyOv ThePhBf4AWclUuOtatuS2nfw5iiz775JEIGgnd/uYe4rXrmhZLY9uVjezatexQW9zJlr f/ua1KJym4YKdxaoZO7i5Sm2rmE52E/ZEveHM3ZGMEyCS4qLoJEPYgizR4iGB0ez384E 65/JeZxmXvJ2XZODMZNCnYNZLTvHyi9Vh/6xPx5IAmj5cvI8gu2XavIl9F9ECYt2hs+g UB9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=yXErgeSSLxaDILoxxu5UisWJyrrX6jAO6zsSUWCeQvbDKWS5TPv07EGNd4VKzy9zTe yUNiTA36KUNlnCbw9wUG2OuVbsTA4Bu3PjMGEVerxNTFn/PQgX02QEoKYrae7L1q138l 6PLwWsDVX34MCH8xz4Eaxbr7JegQOIcL2TDWlWF3agQEcLiYdLg8j67HYz0wLx8fDxtE Bxcyx2Y6KrItFylQ3x8WlVKM854+3EduJXOad5P/ohe0syGwqyRXy1XZC9u8wazWMftB b3nkx9xQTS6oZepg0dGUCEd5bT9ioEODqNz8LvIZrg4x66kxJvS0f8Yx6wnb4a03k6fz inmA== X-Gm-Message-State: AOAM533t7Q74Uxiqpu5cZYYhZR+oY4lChpJ+NQN0Wz5JczmJ8/+KD4HH Wnx2aWyY7pdAtWxOTyL85GTZqA== X-Google-Smtp-Source: ABdhPJw1U92hefuFRAL0GmhDcNMuPQUVRaJ5rI4xhjzGg+pVLc+xkbJYl2Vby+uLLS0FJI1gYbeHXQ== X-Received: by 2002:a05:6a00:23c8:b0:49f:e054:84d7 with SMTP id g8-20020a056a0023c800b0049fe05484d7mr53924075pfc.50.1637214931490; Wed, 17 Nov 2021 21:55:31 -0800 (PST) Received: from google.com ([2401:fa00:1:10:8f8:11d:a96a:74d2]) by smtp.gmail.com with ESMTPSA id u9sm1547277pfi.23.2021.11.17.21.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 21:55:31 -0800 (PST) Date: Thu, 18 Nov 2021 13:55:27 +0800 From: Tzung-Bi Shih To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , Jassi Brar , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hsinyi@chromium.org, fshao@chromium.org, nancy.lin@mediatek.com, singo.chang@mediatek.com Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Message-ID: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211117064158.27451-4-jason-jh.lin@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct drm_crtc *crtc) > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > if (mtk_crtc->cmdq_client.chan) { > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc->cmdq_client.chan->mbox->dev); > mbox_free_channel(mtk_crtc->cmdq_client.chan); > mtk_crtc->cmdq_client.chan = NULL; > } [...] > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > } > > if (mtk_crtc->cmdq_client.chan) { > + struct device_link *link; > + > + /* add devlink to cmdq dev to make sure suspend/resume order is correct */ > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan->mbox->dev, > + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS); > + if (!link) { > + dev_err(dev, "Unable to link dev=%s\n", > + dev_name(mtk_crtc->cmdq_client.chan->mbox->dev)); > + } > + If device_link_add() failed, doesn't mtk_drm_crtc_create() need to return an error and exit? OTOH, if device_link_add() failed, won't it bring any side effects to call device_link_remove()? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37ACBC433F5 for ; Thu, 18 Nov 2021 05:55:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1D8661B3D for ; Thu, 18 Nov 2021 05:55:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F1D8661B3D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bJS40aJqUNCcBXELt1FVL76sCtQWSudrlGWeFwVm8WQ=; b=nfwTcByGBMs+Mp MtdrjYX6DtLXiI0gV3zOwXQDAwMTl/GaVvYFhZyU3kqn2jucHBpp/JjIhnw3SjvjnaKpW+h46IfzX y3qRoZMPQ5rqLcjt/6YRq93z5NJMDX/NiBOGCpMiJDko/1AzuTJXM/cZATmZgIJAdL03UFTJavvtl xF1hjc/MjwdvnGyPxRHCLXU9/gQzCQNnJABW3RLGzD5ZAqFDqLVUqtkWb82Xr029M6AMa1TvRofs/ oBw3P62RRYS66uVEVz/Htal5umHEfzzROpFhb02FKgo5qfhg49h8b7HFW/AKD0JfM8SrscsK8iddT GVQspDYkIJTQRXEUtsfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnaOd-006wEC-KN; Thu, 18 Nov 2021 05:55:43 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnaOS-006w9c-Qp for linux-mediatek@lists.infradead.org; Thu, 18 Nov 2021 05:55:34 +0000 Received: by mail-pg1-x52c.google.com with SMTP id 200so4412320pga.1 for ; Wed, 17 Nov 2021 21:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=UHufCLPWyoOczeZ10rpOHREDHnb3KpiCBx3l1fTQm5RvUKFPfoiV3nIdNI1zko70SG /rKe8N7G0c0n05WH2WbNalEhgCbNcRUSas8ntyCf23nZUCkn6i9wCai27/OIwEMEJyOv ThePhBf4AWclUuOtatuS2nfw5iiz775JEIGgnd/uYe4rXrmhZLY9uVjezatexQW9zJlr f/ua1KJym4YKdxaoZO7i5Sm2rmE52E/ZEveHM3ZGMEyCS4qLoJEPYgizR4iGB0ez384E 65/JeZxmXvJ2XZODMZNCnYNZLTvHyi9Vh/6xPx5IAmj5cvI8gu2XavIl9F9ECYt2hs+g UB9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=N0WrgKzUwYH4AC8Gphxm9jboQnwsvKevZ+DZlfpLzGrZHdghcYdI3NIvo7mBkMU1WO Z+nuSBt8Lz/plAkYzhQ1vLEXXmHbxUSqVA6n9nrEjaGSXvAaUvmC5xDcl7BJwgaFxCAK Qu+VK9uXeg4yuSsh2mm2m1ZW38G4buqqr+cyrIrgrw4zmC7jOI143cdXLiZ79nczzd90 F0LyWK4NIYrzONci4z08CRoTrF37mK5LFQuYA3rwbVAFUuBC+w4UOhRuIsrA9Vb/bxul sAw87UE8/Fp6zbtHSjcDMi+0+mDDMQoj/YXtN77aL7RG17vvX0eR7z7fMQmH/iClzBj1 K90g== X-Gm-Message-State: AOAM531HmYw8tuwjDHEG/8LhXIJL2OnUC2edwAbF/eLoieAU6uwbJ/Ge CQyBjcBHJmr0pv9qjVorUFjoFg== X-Google-Smtp-Source: ABdhPJw1U92hefuFRAL0GmhDcNMuPQUVRaJ5rI4xhjzGg+pVLc+xkbJYl2Vby+uLLS0FJI1gYbeHXQ== X-Received: by 2002:a05:6a00:23c8:b0:49f:e054:84d7 with SMTP id g8-20020a056a0023c800b0049fe05484d7mr53924075pfc.50.1637214931490; Wed, 17 Nov 2021 21:55:31 -0800 (PST) Received: from google.com ([2401:fa00:1:10:8f8:11d:a96a:74d2]) by smtp.gmail.com with ESMTPSA id u9sm1547277pfi.23.2021.11.17.21.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 21:55:31 -0800 (PST) Date: Thu, 18 Nov 2021 13:55:27 +0800 From: Tzung-Bi Shih To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , Jassi Brar , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hsinyi@chromium.org, fshao@chromium.org, nancy.lin@mediatek.com, singo.chang@mediatek.com Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Message-ID: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211117064158.27451-4-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_215532_937042_0E526C0A X-CRM114-Status: GOOD ( 13.32 ) X-Spam-Score: -15.7 (---------------) X-Spam-Report: Spam detection software, running on the system "bombadil.infradead.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > @@ -158, 6 +159, 7 @@ static void mtk_drm_crtc_destroy(struct drm_crtc *crtc) > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > if ( [...] Content analysis details: (-15.7 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52c listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM white-list -7.5 USER_IN_DEF_SPF_WL From: address is in the default SPF white-list -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.5 ENV_AND_HDR_SPF_MATCH Env and Hdr From used in default SPF WL Match -0.0 DKIMWL_WL_MED DKIMwl.org - Medium trust sender X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct drm_crtc *crtc) > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > if (mtk_crtc->cmdq_client.chan) { > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc->cmdq_client.chan->mbox->dev); > mbox_free_channel(mtk_crtc->cmdq_client.chan); > mtk_crtc->cmdq_client.chan = NULL; > } [...] > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > } > > if (mtk_crtc->cmdq_client.chan) { > + struct device_link *link; > + > + /* add devlink to cmdq dev to make sure suspend/resume order is correct */ > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan->mbox->dev, > + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS); > + if (!link) { > + dev_err(dev, "Unable to link dev=%s\n", > + dev_name(mtk_crtc->cmdq_client.chan->mbox->dev)); > + } > + If device_link_add() failed, doesn't mtk_drm_crtc_create() need to return an error and exit? OTOH, if device_link_add() failed, won't it bring any side effects to call device_link_remove()? _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2CCC433F5 for ; Thu, 18 Nov 2021 05:56:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 75CFC6126A for ; Thu, 18 Nov 2021 05:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 75CFC6126A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pbIzBLd+wCdDSBs0uMhfpSxdhNmNXp7UzDK3RwI9EMA=; b=HMdJYl808mUORJ XEzPDmy3oysJ0kqo3oazOWLkLddgU8oe37ZN05vNe+OaRpPzxyA3OM+XD+dqZhIHqs2zbsAvay1j/ NCccBRnEUXRj+7mffLJuTEigcLxV51nk/MNW80hXcIdjyI3T/40Wn1Vti19s/K+jJkMq1WzwRoxuE uTbvkM0eb4O0fdVSw2a4glqBLwDFYobRRERvwOotAoje6IovrmhyCxPQILU8iBC8wpcyFTLo2ET+0 4pVC/xvijSaQ1Vq1BxNjNHyPA2/qI3GCdDyIrcS6f535LAlodWiGrV+j/Gu35+BZjdutSFnSgv7Jd sybuH3ohIgyN5OB19ykQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnaOf-006wEY-I4; Thu, 18 Nov 2021 05:55:45 +0000 Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnaOS-006w9d-Qj for linux-arm-kernel@lists.infradead.org; Thu, 18 Nov 2021 05:55:34 +0000 Received: by mail-pg1-x52a.google.com with SMTP id s138so4390176pgs.4 for ; Wed, 17 Nov 2021 21:55:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=UHufCLPWyoOczeZ10rpOHREDHnb3KpiCBx3l1fTQm5RvUKFPfoiV3nIdNI1zko70SG /rKe8N7G0c0n05WH2WbNalEhgCbNcRUSas8ntyCf23nZUCkn6i9wCai27/OIwEMEJyOv ThePhBf4AWclUuOtatuS2nfw5iiz775JEIGgnd/uYe4rXrmhZLY9uVjezatexQW9zJlr f/ua1KJym4YKdxaoZO7i5Sm2rmE52E/ZEveHM3ZGMEyCS4qLoJEPYgizR4iGB0ez384E 65/JeZxmXvJ2XZODMZNCnYNZLTvHyi9Vh/6xPx5IAmj5cvI8gu2XavIl9F9ECYt2hs+g UB9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=M6fU9HCOMXaAwWu55zqsqx8GoNSHTp7qVG4HyvmThLM=; b=nFp1zBxT3k8E3yefONFwLN4IrmuyunNqd8xh9+ik7VsZfYBqO7mjSz2y9156Dstec4 eBzVVef4Ndp4GFoVxsFCAwBou6ipQwF27rZeY0OamgBXoMzHtY+v3WpzVfRO4Gxk1/PQ X+3O4PbW6MqHpcMXdRXQGYBG66WV/s9MErcT/DQfrQboJls5P/t4n+/L4HDIYDpS7DaV uD9ou2wSN9IZsHtgikumqkoAwBnW3F1lXEilX/Sdw7kZ2CeEggR/EqPfPzQyUETRo+Qg UNdgrQSThtRljLZMRAcHwcVY+Bcu8G/htoOarTSuzb1rOpEHpmsW+bE5tr6yUTEglJIr gO+A== X-Gm-Message-State: AOAM533wpGcyZcvQDf8RYou0q49rCt8pSBN8pMw6f+fE5lTGIgfBi4lT i819O8HbT1TBoHYoGWbQgZO1lg== X-Google-Smtp-Source: ABdhPJw1U92hefuFRAL0GmhDcNMuPQUVRaJ5rI4xhjzGg+pVLc+xkbJYl2Vby+uLLS0FJI1gYbeHXQ== X-Received: by 2002:a05:6a00:23c8:b0:49f:e054:84d7 with SMTP id g8-20020a056a0023c800b0049fe05484d7mr53924075pfc.50.1637214931490; Wed, 17 Nov 2021 21:55:31 -0800 (PST) Received: from google.com ([2401:fa00:1:10:8f8:11d:a96a:74d2]) by smtp.gmail.com with ESMTPSA id u9sm1547277pfi.23.2021.11.17.21.55.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 21:55:31 -0800 (PST) Date: Thu, 18 Nov 2021 13:55:27 +0800 From: Tzung-Bi Shih To: "jason-jh.lin" Cc: Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , Jassi Brar , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, hsinyi@chromium.org, fshao@chromium.org, nancy.lin@mediatek.com, singo.chang@mediatek.com Subject: Re: [PATCH 3/3] drm/mediatek: add devlink to cmdq dev Message-ID: References: <20211117064158.27451-1-jason-jh.lin@mediatek.com> <20211117064158.27451-4-jason-jh.lin@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211117064158.27451-4-jason-jh.lin@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211117_215532_940036_84623490 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 17, 2021 at 02:41:58PM +0800, jason-jh.lin wrote: > @@ -158,6 +159,7 @@ static void mtk_drm_crtc_destroy(struct drm_crtc *crtc) > mtk_drm_cmdq_pkt_destroy(&mtk_crtc->cmdq_handle); > > if (mtk_crtc->cmdq_client.chan) { > + device_link_remove(mtk_crtc->drm_dev, mtk_crtc->cmdq_client.chan->mbox->dev); > mbox_free_channel(mtk_crtc->cmdq_client.chan); > mtk_crtc->cmdq_client.chan = NULL; > } [...] > @@ -956,6 +959,16 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev, > } > > if (mtk_crtc->cmdq_client.chan) { > + struct device_link *link; > + > + /* add devlink to cmdq dev to make sure suspend/resume order is correct */ > + link = device_link_add(dev, mtk_crtc->cmdq_client.chan->mbox->dev, > + DL_FLAG_PM_RUNTIME | DL_FLAG_STATELESS); > + if (!link) { > + dev_err(dev, "Unable to link dev=%s\n", > + dev_name(mtk_crtc->cmdq_client.chan->mbox->dev)); > + } > + If device_link_add() failed, doesn't mtk_drm_crtc_create() need to return an error and exit? OTOH, if device_link_add() failed, won't it bring any side effects to call device_link_remove()? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel