From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E30A2C433EF for ; Thu, 18 Nov 2021 12:33:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4FF561501 for ; Thu, 18 Nov 2021 12:33:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344727AbhKRMg0 (ORCPT ); Thu, 18 Nov 2021 07:36:26 -0500 Received: from mga04.intel.com ([192.55.52.120]:34122 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344735AbhKRMgW (ORCPT ); Thu, 18 Nov 2021 07:36:22 -0500 X-IronPort-AV: E=McAfee;i="6200,9189,10171"; a="232895585" X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="232895585" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:22 -0800 X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="455312743" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:18 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 34F2C20282; Thu, 18 Nov 2021 14:33:16 +0200 (EET) Date: Thu, 18 Nov 2021 14:33:16 +0200 From: Sakari Ailus To: Jammy Huang Cc: eajames@linux.ibm.com, mchehab@kernel.org, joel@jms.id.au, andrew@aj.id.au, hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format Message-ID: References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-6-jammy_huang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211118074030.685-6-jammy_huang@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jammy, On Thu, Nov 18, 2021 at 03:40:26PM +0800, Jammy Huang wrote: > This introduces support for the Aspeed JPEG format, where the new frame > can refer to previous frame to reduce the amount of compressed data. The > concept is similar to I/P frame of video compression. I will compare the > new frame with previous one to decide which macroblock's data is > changed, and only the changed macroblocks will be compressed. > > This Aspeed JPEG format is used by the video engine on Aspeed platforms, > which is generally adapted for remote KVM. > > Signed-off-by: Jammy Huang > --- > v5: > - no update > v4: > - new > --- > Documentation/media/uapi/v4l/pixfmt-reserved.rst | 12 ++++++++++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 3 files changed, 14 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > index b2cd155e691b..23c05063133d 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > @@ -264,6 +264,18 @@ please make a proposal on the linux-media mailing list. > of tiles, resulting in 32-aligned resolutions for the luminance plane > and 16-aligned resolutions for the chrominance plane (with 2x2 > subsampling). > + * .. _V4L2-PIX-FMT-AJPG: > + > + - ``V4L2_PIX_FMT_AJPG`` > + - 'AJPG' > + - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms, > + which is generally adapted for remote KVM. > + On each frame compression, I will compare the new frame with previous > + one to decide which macroblock's data is changed, and only the changed > + macroblocks will be compressed. > + > + You could reference to chapter 36, Video Engine, of AST2600's datasheet > + for more information. Is this datasheet publicly available? Do you have a URL? -- Regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27618C433F5 for ; Thu, 18 Nov 2021 12:34:53 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B155561A03 for ; Thu, 18 Nov 2021 12:34:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B155561A03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HvzlH1Hw1z3bc4 for ; Thu, 18 Nov 2021 23:34:51 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=linux.intel.com (client-ip=192.55.52.43; helo=mga05.intel.com; envelope-from=sakari.ailus@linux.intel.com; receiver=) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Hvzkm5wd5z2xrl; Thu, 18 Nov 2021 23:34:24 +1100 (AEDT) X-IronPort-AV: E=McAfee;i="6200,9189,10171"; a="320389998" X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="320389998" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:22 -0800 X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="455312743" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:18 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 34F2C20282; Thu, 18 Nov 2021 14:33:16 +0200 (EET) Date: Thu, 18 Nov 2021 14:33:16 +0200 From: Sakari Ailus To: Jammy Huang Subject: Re: [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format Message-ID: References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-6-jammy_huang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211118074030.685-6-jammy_huang@aspeedtech.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org, eajames@linux.ibm.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, hverkuil-cisco@xs4all.nl, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, laurent.pinchart@ideasonboard.com Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Jammy, On Thu, Nov 18, 2021 at 03:40:26PM +0800, Jammy Huang wrote: > This introduces support for the Aspeed JPEG format, where the new frame > can refer to previous frame to reduce the amount of compressed data. The > concept is similar to I/P frame of video compression. I will compare the > new frame with previous one to decide which macroblock's data is > changed, and only the changed macroblocks will be compressed. > > This Aspeed JPEG format is used by the video engine on Aspeed platforms, > which is generally adapted for remote KVM. > > Signed-off-by: Jammy Huang > --- > v5: > - no update > v4: > - new > --- > Documentation/media/uapi/v4l/pixfmt-reserved.rst | 12 ++++++++++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 3 files changed, 14 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > index b2cd155e691b..23c05063133d 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > @@ -264,6 +264,18 @@ please make a proposal on the linux-media mailing list. > of tiles, resulting in 32-aligned resolutions for the luminance plane > and 16-aligned resolutions for the chrominance plane (with 2x2 > subsampling). > + * .. _V4L2-PIX-FMT-AJPG: > + > + - ``V4L2_PIX_FMT_AJPG`` > + - 'AJPG' > + - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms, > + which is generally adapted for remote KVM. > + On each frame compression, I will compare the new frame with previous > + one to decide which macroblock's data is changed, and only the changed > + macroblocks will be compressed. > + > + You could reference to chapter 36, Video Engine, of AST2600's datasheet > + for more information. Is this datasheet publicly available? Do you have a URL? -- Regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BBA8C433EF for ; Thu, 18 Nov 2021 12:34:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4723061A09 for ; Thu, 18 Nov 2021 12:34:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4723061A09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qQkCRMIw17wkF4harK181DupVpHbskXGg7y5FwcV5es=; b=JY91+//XW79a9N rIl/4mnGWzNxRM2kdem2MhM/F68ajSazLZMML1YoHWZAss2/IWrJzzylfuRSFdFeKDtJsgwQXELYk iMR9MPqHhsx0R7lFYVCMhUbeoDGH5NkIj6O2QKPEa6SVULNeVirAMf7V4EbZkS7oCvUa7OMDcq1sX GRYBQliFo8F9ecOlQaTpG+qt8t4mzp88/GzsF+vODdUIamS2l9flkU20iWFsnVJgCfI4Td51UKDbn 7phxIKhxXti3PKKVRf9NvUlC0Se0/qW4rASYhhCRn5qr0Z+da1wPc3kP3LW7V2C74c2SGWDP+sqCE SvH6nJpXVrnQAe8phQoQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mngbX-007l7O-AI; Thu, 18 Nov 2021 12:33:27 +0000 Received: from mga05.intel.com ([192.55.52.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mngbT-007l68-KW for linux-arm-kernel@lists.infradead.org; Thu, 18 Nov 2021 12:33:25 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10171"; a="320389997" X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="320389997" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:22 -0800 X-IronPort-AV: E=Sophos;i="5.87,244,1631602800"; d="scan'208";a="455312743" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Nov 2021 04:33:18 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 34F2C20282; Thu, 18 Nov 2021 14:33:16 +0200 (EET) Date: Thu, 18 Nov 2021 14:33:16 +0200 From: Sakari Ailus To: Jammy Huang Cc: eajames@linux.ibm.com, mchehab@kernel.org, joel@jms.id.au, andrew@aj.id.au, hverkuil-cisco@xs4all.nl, gregkh@linuxfoundation.org, laurent.pinchart@ideasonboard.com, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 05/10] media: v4l: Add definition for the Aspeed JPEG format Message-ID: References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-6-jammy_huang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211118074030.685-6-jammy_huang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_043323_845252_273F22AC X-CRM114-Status: GOOD ( 21.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jammy, On Thu, Nov 18, 2021 at 03:40:26PM +0800, Jammy Huang wrote: > This introduces support for the Aspeed JPEG format, where the new frame > can refer to previous frame to reduce the amount of compressed data. The > concept is similar to I/P frame of video compression. I will compare the > new frame with previous one to decide which macroblock's data is > changed, and only the changed macroblocks will be compressed. > > This Aspeed JPEG format is used by the video engine on Aspeed platforms, > which is generally adapted for remote KVM. > > Signed-off-by: Jammy Huang > --- > v5: > - no update > v4: > - new > --- > Documentation/media/uapi/v4l/pixfmt-reserved.rst | 12 ++++++++++++ > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 3 files changed, 14 insertions(+) > > diff --git a/Documentation/media/uapi/v4l/pixfmt-reserved.rst b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > index b2cd155e691b..23c05063133d 100644 > --- a/Documentation/media/uapi/v4l/pixfmt-reserved.rst > +++ b/Documentation/media/uapi/v4l/pixfmt-reserved.rst > @@ -264,6 +264,18 @@ please make a proposal on the linux-media mailing list. > of tiles, resulting in 32-aligned resolutions for the luminance plane > and 16-aligned resolutions for the chrominance plane (with 2x2 > subsampling). > + * .. _V4L2-PIX-FMT-AJPG: > + > + - ``V4L2_PIX_FMT_AJPG`` > + - 'AJPG' > + - ASPEED JPEG format used by the aspeed-video driver on Aspeed platforms, > + which is generally adapted for remote KVM. > + On each frame compression, I will compare the new frame with previous > + one to decide which macroblock's data is changed, and only the changed > + macroblocks will be compressed. > + > + You could reference to chapter 36, Video Engine, of AST2600's datasheet > + for more information. Is this datasheet publicly available? Do you have a URL? -- Regards, Sakari Ailus _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel