All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
Date: Mon, 22 Nov 2021 18:29:16 +0200	[thread overview]
Message-ID: <YZvFXBhZT68Nj6Uj@ryzen> (raw)
In-Reply-To: <YZb4BClv4fXU65yz@robh.at.kernel.org>

On 21-11-18 19:04:04, Rob Herring wrote:
> On Wed, Nov 10, 2021 at 07:46:55PM +0200, Abel Vesa wrote:
> > Add i.MX8DXL lpuart compatible to the bindings documentation.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index dc1f0e07cbd4..fa8a602ccb22 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -27,6 +27,10 @@ properties:
> >        - items:
> >            - const: fsl,imx8qm-lpuart
> >            - const: fsl,imx8qxp-lpuart
> > +      - items:
> > +          - const: fsl,imx8dxl-lpuart
> > +          - const: fsl,imx8qxp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
> I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the 
> driver, it looks like the difference is clocks.
> 

There are still things to be upstreamed for the fsl-lpuart driver.
Looking at the NXP's tree, 7ulp has some specific fixup that the
8qm doesn't need.

Have a look here:

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/tty/serial/fsl_lpuart.c?h=lf-5.10.y#n3242

> >  
> >    reg:
> >      maxItems: 1
> > -- 
> > 2.31.1
> > 
> >

WARNING: multiple messages have this Message-ID (diff)
From: Abel Vesa <abel.vesa@nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Fabio Estevam <festevam@gmail.com>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
	NXP Linux Team <linux-imx@nxp.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible
Date: Mon, 22 Nov 2021 18:29:16 +0200	[thread overview]
Message-ID: <YZvFXBhZT68Nj6Uj@ryzen> (raw)
In-Reply-To: <YZb4BClv4fXU65yz@robh.at.kernel.org>

On 21-11-18 19:04:04, Rob Herring wrote:
> On Wed, Nov 10, 2021 at 07:46:55PM +0200, Abel Vesa wrote:
> > Add i.MX8DXL lpuart compatible to the bindings documentation.
> > 
> > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/serial/fsl-lpuart.yaml | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > index dc1f0e07cbd4..fa8a602ccb22 100644
> > --- a/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/fsl-lpuart.yaml
> > @@ -27,6 +27,10 @@ properties:
> >        - items:
> >            - const: fsl,imx8qm-lpuart
> >            - const: fsl,imx8qxp-lpuart
> > +      - items:
> > +          - const: fsl,imx8dxl-lpuart
> > +          - const: fsl,imx8qxp-lpuart
> > +          - const: fsl,imx7ulp-lpuart
> 
> I'm confused why 8dxl is compatible with 7ulp, but 8qm is not? From the 
> driver, it looks like the difference is clocks.
> 

There are still things to be upstreamed for the fsl-lpuart driver.
Looking at the NXP's tree, 7ulp has some specific fixup that the
8qm doesn't need.

Have a look here:

https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/tty/serial/fsl_lpuart.c?h=lf-5.10.y#n3242

> >  
> >    reg:
> >      maxItems: 1
> > -- 
> > 2.31.1
> > 
> >

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-11-22 16:29 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10 17:46 [PATCH v4 00/12] arm64: dts: Add i.MX8DXL initial support Abel Vesa
2021-11-10 17:46 ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 01/12] dt-bindings: i2c: imx-lpi2c: Fix i.MX 8QM compatible matching Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-19  0:56   ` Rob Herring
2021-11-19  0:56     ` Rob Herring
2021-11-23  8:52   ` Wolfram Sang
2021-11-23  8:52     ` Wolfram Sang
2021-11-23  8:53     ` Wolfram Sang
2021-11-23  8:53       ` Wolfram Sang
2021-11-10 17:46 ` [PATCH v4 02/12] dt-bindings: serial: fsl-lpuart: " Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-19  1:02   ` Rob Herring
2021-11-19  1:02     ` Rob Herring
2021-11-10 17:46 ` [PATCH v4 03/12] arm64: dts: freescale: Add the top level dtsi support for imx8dxl Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 04/12] arm64: dts: imx8-ss-lsio: Add mu5a mailbox Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 05/12] arm64: dts: freescale: Add adma subsystem dtsi for imx8dxl Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 06/12] arm64: dts: freescale: Add the imx8dxl connectivity subsys dtsi Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 07/12] arm64: dts: freescale: Add ddr subsys dtsi for imx8dxl Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 08/12] arm64: dts: freescale: Add lsio " Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 09/12] arm64: dts: imx8dxl: Add i.MX8DXL evk board support Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 10/12] dt-bindings: fsl: scu: Add i.MX8DXL ocotp binding Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-10 17:46 ` [PATCH v4 11/12] dt-bindings: i2c: imx-lpi2c: Add i.MX8DXL compatible match Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-19  1:02   ` Rob Herring
2021-11-19  1:02     ` Rob Herring
2021-11-29  8:41   ` Wolfram Sang
2021-11-29  8:41     ` Wolfram Sang
2021-11-10 17:46 ` [PATCH v4 12/12] dt-bindings: serial: fsl-lpuart: Add i.MX8DXL compatible Abel Vesa
2021-11-10 17:46   ` Abel Vesa
2021-11-19  1:04   ` Rob Herring
2021-11-19  1:04     ` Rob Herring
2021-11-19  7:17     ` (EXT) " Alexander Stein
2021-11-19  7:17       ` Alexander Stein
2021-11-22 16:45       ` Abel Vesa
2021-11-22 16:45         ` Abel Vesa
2021-11-23  7:30         ` (EXT) " Alexander Stein
2021-11-23  7:30           ` Alexander Stein
2021-11-25 13:19           ` Abel Vesa
2021-11-25 13:19             ` Abel Vesa
2021-11-25 13:23             ` (EXT) " Alexander Stein
2021-11-25 13:23               ` Alexander Stein
2021-11-22 16:29     ` Abel Vesa [this message]
2021-11-22 16:29       ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZvFXBhZT68Nj6Uj@ryzen \
    --to=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.