From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] spi: Fix multi-line comment style
Date: Mon, 22 Nov 2021 19:09:50 +0200 [thread overview]
Message-ID: <YZvO3gxIQ61qNbWJ@smile.fi.intel.com> (raw)
In-Reply-To: <YZu7qWKYbWnmy20q@sirena.org.uk>
On Mon, Nov 22, 2021 at 03:47:53PM +0000, Mark Brown wrote:
> On Fri, Nov 19, 2021 at 07:37:18PM +0200, Andy Shevchenko wrote:
> > /*
> > * Fix multi-line comment style as in this short example. Pay attention
> > * to the capitalization, period and starting line of the text.
> > */
> >
> > While at it, split the (supposedly short) description of couple of functions
> > to summary (short description) and (long) description.
>
> This doesn't apply against current code, please check and resend.
I have merged your for-next branch (is it correct approach) on top of v5.16-rc2
and patches are applied cleanly. Is it something addition I should care about?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-11-22 17:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 17:37 [PATCH v1 1/2] spi: deduplicate spi_match_id() in __spi_register_driver() Andy Shevchenko
2021-11-19 17:37 ` [PATCH v1 2/2] spi: Fix multi-line comment style Andy Shevchenko
2021-11-22 15:47 ` Mark Brown
2021-11-22 17:09 ` Andy Shevchenko [this message]
2021-11-22 17:15 ` Andy Shevchenko
2021-11-23 0:00 ` [PATCH v1 1/2] spi: deduplicate spi_match_id() in __spi_register_driver() Mark Brown
2021-11-23 15:22 ` Jon Hunter
2021-11-23 15:43 ` Andy Shevchenko
2021-11-23 16:51 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZvO3gxIQ61qNbWJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.