From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFAEEC433F5 for ; Tue, 23 Nov 2021 09:47:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234318AbhKWJul (ORCPT ); Tue, 23 Nov 2021 04:50:41 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:59886 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234136AbhKWJuk (ORCPT ); Tue, 23 Nov 2021 04:50:40 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0797BA1B; Tue, 23 Nov 2021 10:47:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637660851; bh=6vADgbssraBLDOIKrkf2AvmyACKPaDSUjAS9OI3rwS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tdu54CA0m5zh7iSTvLL1iDk438RVN2zDGwnKwD0rXHizm4DX4KrttwZts3F5zLPIS JqEiHWI2P1NnRU5RvoJ58La8ZDOHC4p82/qNF+D2hAWl6vvtByinARTDjaB2i+O18+ +nYco/ONNigFh1Q8bCZUvQWJwnzTKSb9QLBJ2V/Y= Date: Tue, 23 Nov 2021 11:47:08 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Adam Ford , arm-soc , Tim Harvey , Schrempf Frieder , linux-media , Adam Ford-BE , cstevens@beaconembedded.com, Jagan Teki , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , Lucas Stach , Peng Fan , devicetree , Linux Kernel Mailing List Subject: Re: (EXT) Re: [PATCH V2 4/5] arm64: dts: imx8mm-beacon: Enable OV5640 Camera Message-ID: References: <20211106155427.753197-1-aford173@gmail.com> <20211106155427.753197-4-aford173@gmail.com> <0c3b4cdd075919ca5cc27c56e792f510e3b76cd7.camel@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <0c3b4cdd075919ca5cc27c56e792f510e3b76cd7.camel@ew.tq-group.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, On Tue, Nov 23, 2021 at 08:38:47AM +0100, Alexander Stein wrote: > Am Dienstag, dem 23.11.2021 um 02:15 +0200 schrieb Laurent Pinchart: > > On Sun, Nov 21, 2021 at 09:07:26PM -0600, Adam Ford wrote: > > > On Sun, Nov 21, 2021 at 5:18 PM Laurent Pinchart wrote: > > > > On Sat, Nov 06, 2021 at 10:54:26AM -0500, Adam Ford wrote: > > > > > The baseboard has support for a TDNext 5640 Camera which > > > > > uses an OV5640 connected to a 2-lane CSI2 interface. > > > > > > > > > > With the CSI and mipi_csi2 drivers pointing to an OV5640 camera, the media > > > > > pipeline can be configured with the following: > > > > > > > > > > media-ctl --links "'ov5640 1-003c':0->'imx7-mipi-csis.0':0[1]" > > > > > > > > > > The camera and various nodes in the pipeline can be configured for UYVY: > > > > > media-ctl -v -V "'ov5640 1-003c':0 [fmt:UYVY8_1X16/640x480 field:none]" > > > > > media-ctl -v -V "'csi':0 [fmt:UYVY8_1X16/640x480 field:none]" > > > > > > > > > > Signed-off-by: Adam Ford > > > > > > > > As the ov5640 is on an add-on module, would a DT overlay be better ? > > > > > > At least for the Beacon / LogicPD boards, I would prefer to avoid the > > > overlays. We have an i.M6Q and an OMAP3 board with cameras enabled in > > > our development kit device trees. If the cameras are not connected, > > > they just display a message that the cameras are not communicating and > > > move on. I'm OK with that. > > > > You know the board better than I do, so I won't push against this, but I > > still think it may not lead to the best user experience, especially if a > > user wanted to connect a different sensor to the development board. > > I see the advantages of overlays compared to "stacked" .dts files. But > is there any general supported interface how to actually apply an overlay? > Documentation/devicetree/overlay-notes.rst > states of_overlay_fdt_apply() but there is only exactly one user in- > kernel (rcar-du). Is it expected that the bootloader like u-boot shall > apply the .dtbo files? I believe the boot loader is expected to apply overlays nowadays, yes. That's my personal workflow. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E16DC433EF for ; Tue, 23 Nov 2021 09:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kni5Z6FBUkhciXoC46g4MwVQ/Fj5OCnUvq/WJvm45DU=; b=20w6OOetQRFBCX RSEPryvPG9/V5HiPpsr0n4snaOF95LhwsPs3D/N3Kf5J8uRPTg+3jKR81UKMZmp7Xm0OGNBIo96YD 2Qh+gVnE7XcDU3Z5iqFVaiz6Rhoc8GPYlJoEsbdXnXdVVM9w+bmcqrqAw7Oeq5A0wPC8vO8qzApPr djtZ6AquHNubwXDq0XDVl4ctDcBcSeLP7tWofqiEnoJJh43zUnDYObAJ2nMeM84nbZxFFx2tU2Aiy iYmkQhB2U+0dObYsZdCaKCUG9ii1msGTVEedxdrXXAEEMZbvlNCQvx15j0U2hKWk8zjCbjOugFesI 1aNOmMcOHudy59cfJ+sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpSOo-001Xfb-0v; Tue, 23 Nov 2021 09:47:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mpSOj-001Xdz-LQ for linux-arm-kernel@lists.infradead.org; Tue, 23 Nov 2021 09:47:35 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0797BA1B; Tue, 23 Nov 2021 10:47:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1637660851; bh=6vADgbssraBLDOIKrkf2AvmyACKPaDSUjAS9OI3rwS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tdu54CA0m5zh7iSTvLL1iDk438RVN2zDGwnKwD0rXHizm4DX4KrttwZts3F5zLPIS JqEiHWI2P1NnRU5RvoJ58La8ZDOHC4p82/qNF+D2hAWl6vvtByinARTDjaB2i+O18+ +nYco/ONNigFh1Q8bCZUvQWJwnzTKSb9QLBJ2V/Y= Date: Tue, 23 Nov 2021 11:47:08 +0200 From: Laurent Pinchart To: Alexander Stein Cc: Adam Ford , arm-soc , Tim Harvey , Schrempf Frieder , linux-media , Adam Ford-BE , cstevens@beaconembedded.com, Jagan Teki , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Catalin Marinas , Will Deacon , Lucas Stach , Peng Fan , devicetree , Linux Kernel Mailing List Subject: Re: (EXT) Re: [PATCH V2 4/5] arm64: dts: imx8mm-beacon: Enable OV5640 Camera Message-ID: References: <20211106155427.753197-1-aford173@gmail.com> <20211106155427.753197-4-aford173@gmail.com> <0c3b4cdd075919ca5cc27c56e792f510e3b76cd7.camel@ew.tq-group.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0c3b4cdd075919ca5cc27c56e792f510e3b76cd7.camel@ew.tq-group.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211123_014733_884924_1DBCA924 X-CRM114-Status: GOOD ( 27.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Alexander, On Tue, Nov 23, 2021 at 08:38:47AM +0100, Alexander Stein wrote: > Am Dienstag, dem 23.11.2021 um 02:15 +0200 schrieb Laurent Pinchart: > > On Sun, Nov 21, 2021 at 09:07:26PM -0600, Adam Ford wrote: > > > On Sun, Nov 21, 2021 at 5:18 PM Laurent Pinchart wrote: > > > > On Sat, Nov 06, 2021 at 10:54:26AM -0500, Adam Ford wrote: > > > > > The baseboard has support for a TDNext 5640 Camera which > > > > > uses an OV5640 connected to a 2-lane CSI2 interface. > > > > > > > > > > With the CSI and mipi_csi2 drivers pointing to an OV5640 camera, the media > > > > > pipeline can be configured with the following: > > > > > > > > > > media-ctl --links "'ov5640 1-003c':0->'imx7-mipi-csis.0':0[1]" > > > > > > > > > > The camera and various nodes in the pipeline can be configured for UYVY: > > > > > media-ctl -v -V "'ov5640 1-003c':0 [fmt:UYVY8_1X16/640x480 field:none]" > > > > > media-ctl -v -V "'csi':0 [fmt:UYVY8_1X16/640x480 field:none]" > > > > > > > > > > Signed-off-by: Adam Ford > > > > > > > > As the ov5640 is on an add-on module, would a DT overlay be better ? > > > > > > At least for the Beacon / LogicPD boards, I would prefer to avoid the > > > overlays. We have an i.M6Q and an OMAP3 board with cameras enabled in > > > our development kit device trees. If the cameras are not connected, > > > they just display a message that the cameras are not communicating and > > > move on. I'm OK with that. > > > > You know the board better than I do, so I won't push against this, but I > > still think it may not lead to the best user experience, especially if a > > user wanted to connect a different sensor to the development board. > > I see the advantages of overlays compared to "stacked" .dts files. But > is there any general supported interface how to actually apply an overlay? > Documentation/devicetree/overlay-notes.rst > states of_overlay_fdt_apply() but there is only exactly one user in- > kernel (rcar-du). Is it expected that the bootloader like u-boot shall > apply the .dtbo files? I believe the boot loader is expected to apply overlays nowadays, yes. That's my personal workflow. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel