From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2738BC433EF for ; Tue, 7 Dec 2021 16:44:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230316AbhLGQru (ORCPT ); Tue, 7 Dec 2021 11:47:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbhLGQru (ORCPT ); Tue, 7 Dec 2021 11:47:50 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2595C061574 for ; Tue, 7 Dec 2021 08:44:19 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F70F556; Tue, 7 Dec 2021 17:44:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1638895457; bh=bWd6lEiREDRAZ+PDNC285hxwR6IPlUo4UOngm3Ag1Rc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vvf11SNig+AISPQZgOWs4IVJVw8w4TpobVC0ZeGsWIY6m8GlycE1D4l6/3VnWV9oq gFUKidx6WLphcY54U5GvBnBTwVLSV6CJhVO3luz1H6a5UBbLh0AA6La3p1DOZ7ggP0 8cgL0CEbfHmt+fv/ye1dW2eHxwDV68MEBvMhUzjQ= Date: Tue, 7 Dec 2021 18:43:48 +0200 From: Laurent Pinchart To: Marek Vasut Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Jernej Skrabec , Jonas Karlman , Neil Armstrong , Rob Herring , Sam Ravnborg , devicetree@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support Message-ID: References: <20211127032405.283435-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211127032405.283435-1-marex@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Marek, Thank you for the patch. On Sat, Nov 27, 2021 at 04:24:02AM +0100, Marek Vasut wrote: > The TC358767/TC358867/TC9595 are all capable of operating in multiple > modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Document support for the > DPI output port, which can now be connected both as input and output. > > Signed-off-by: Marek Vasut > Cc: Andrzej Hajda > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/bridge/toshiba,tc358767.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > index f1541cc05297..5cfda6f2ba69 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > @@ -61,8 +61,8 @@ properties: > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: | > - DPI input port. The remote endpoint phandle should be a > - reference to a valid DPI output endpoint node > + DPI input/output port. The remote endpoint phandle should be a > + reference to a valid DPI output or input endpoint node. I assume the mode of operation (input or output) will be fixed for a given hardware design. Isn't this something that should be recorded in DT ? It would simplify configuration of the device in the driver. > > port@2: > $ref: /schemas/graph.yaml#/properties/port > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B808EC433F5 for ; Tue, 7 Dec 2021 16:44:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CE60C7BB71; Tue, 7 Dec 2021 16:44:21 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 715B3737F6 for ; Tue, 7 Dec 2021 16:44:19 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F70F556; Tue, 7 Dec 2021 17:44:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1638895457; bh=bWd6lEiREDRAZ+PDNC285hxwR6IPlUo4UOngm3Ag1Rc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vvf11SNig+AISPQZgOWs4IVJVw8w4TpobVC0ZeGsWIY6m8GlycE1D4l6/3VnWV9oq gFUKidx6WLphcY54U5GvBnBTwVLSV6CJhVO3luz1H6a5UBbLh0AA6La3p1DOZ7ggP0 8cgL0CEbfHmt+fv/ye1dW2eHxwDV68MEBvMhUzjQ= Date: Tue, 7 Dec 2021 18:43:48 +0200 From: Laurent Pinchart To: Marek Vasut Subject: Re: [PATCH 1/4] dt-bindings: display: bridge: tc358867: Document DPI output support Message-ID: References: <20211127032405.283435-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211127032405.283435-1-marex@denx.de> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Jernej Skrabec , Neil Armstrong , Jonas Karlman , dri-devel@lists.freedesktop.org, Andrzej Hajda , Rob Herring , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Marek, Thank you for the patch. On Sat, Nov 27, 2021 at 04:24:02AM +0100, Marek Vasut wrote: > The TC358767/TC358867/TC9595 are all capable of operating in multiple > modes, DPI-to-(e)DP, DSI-to-(e)DP, DSI-to-DPI. Document support for the > DPI output port, which can now be connected both as input and output. > > Signed-off-by: Marek Vasut > Cc: Andrzej Hajda > Cc: Jernej Skrabec > Cc: Jonas Karlman > Cc: Laurent Pinchart > Cc: Neil Armstrong > Cc: Rob Herring > Cc: Sam Ravnborg > Cc: devicetree@vger.kernel.org > To: dri-devel@lists.freedesktop.org > --- > .../devicetree/bindings/display/bridge/toshiba,tc358767.yaml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > index f1541cc05297..5cfda6f2ba69 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358767.yaml > @@ -61,8 +61,8 @@ properties: > port@1: > $ref: /schemas/graph.yaml#/properties/port > description: | > - DPI input port. The remote endpoint phandle should be a > - reference to a valid DPI output endpoint node > + DPI input/output port. The remote endpoint phandle should be a > + reference to a valid DPI output or input endpoint node. I assume the mode of operation (input or output) will be fixed for a given hardware design. Isn't this something that should be recorded in DT ? It would simplify configuration of the device in the driver. > > port@2: > $ref: /schemas/graph.yaml#/properties/port > -- Regards, Laurent Pinchart