From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C00BC433F5 for ; Tue, 7 Dec 2021 10:51:19 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id B67B53C31F2 for ; Tue, 7 Dec 2021 11:51:16 +0100 (CET) Received: from in-4.smtp.seeweb.it (in-4.smtp.seeweb.it [217.194.8.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D40323C0F60 for ; Tue, 7 Dec 2021 11:51:07 +0100 (CET) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-4.smtp.seeweb.it (Postfix) with ESMTPS id 406DB1000A0E for ; Tue, 7 Dec 2021 11:51:06 +0100 (CET) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4D6881FD2F; Tue, 7 Dec 2021 10:51:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1638874266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=woAYj8a6ni1+2u/e/lwtKrd+JALazksYsuO4dqSciwY=; b=FRnqkWu8WwE4BoLi9rTCHrhVt6oa/yamL1oGLTDPL+kNWx7SPhznX5VXz2VOoS7OS4JTT5 sweoshornBP6uuKUHxkGSnZUPsxUQMsw4rZZ3xuykQjwy9XkMGf4Zo4m7ABBisnKyjSOFr TRwsFdjpUB7G/l/JcaioUWp0N9DmPfY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1638874266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=woAYj8a6ni1+2u/e/lwtKrd+JALazksYsuO4dqSciwY=; b=siP8SCYkxfLxMxP2WvXP5sF9LXCb3xxlIuyGlPyIhYSHnZopSRuF17lfNDQvemJ5KWX9qq Z97JMnVRYbEAAuDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3751213A1F; Tue, 7 Dec 2021 10:51:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SmnfC5o8r2EXewAAMHmgww (envelope-from ); Tue, 07 Dec 2021 10:51:06 +0000 Date: Tue, 7 Dec 2021 11:52:22 +0100 From: Cyril Hrubis To: Yang Xu Message-ID: References: <1638864483-2446-1-git-send-email-xuyang2018.jy@fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1638864483-2446-1-git-send-email-xuyang2018.jy@fujitsu.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-4.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH v2 1/2] library: add cmd check handler in needs_cmds X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Hi! > diff --git a/lib/tst_test.c b/lib/tst_test.c > index a79275722..7cca209ab 100644 > --- a/lib/tst_test.c > +++ b/lib/tst_test.c I would rather put the version parsing code to a different source file than tst_test.c just because the tst_test.c is long enough already. What I did suggest for v1 is that the entry point function i.e. tst_check_cmd() now wouldn't get exported as a prototype to the tests by being defined in a header included in the tst_test.h header. We already have include/tst_private.h that is expected to be used for function prototypes that are not supposed to be available to the test code. Other than this the code looks good. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp