From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: ti: Add missing ti,k3-sci-common.yaml reference
Date: Tue, 7 Dec 2021 09:40:43 +0100 [thread overview]
Message-ID: <Ya8eC9UkwMZaNozs@orome.fritz.box> (raw)
In-Reply-To: <20211206174226.2298135-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1907 bytes --]
On Mon, Dec 06, 2021 at 11:42:26AM -0600, Rob Herring wrote:
> The TI k3-bcdma and k3-pktdma both use 'ti,sci' and 'ti,sci-dev-id'
> properties defined in ti,k3-sci-common.yaml. When 'unevaluatedProperties'
> support is enabled, a the follow warning is generated:
s/a the following/the following/
Otherwise looks good:
Reviewed-by: Thierry Reding <treding@nvidia.com>
One question below...
>
> Documentation/devicetree/bindings/dma/ti/k3-bcdma.example.dt.yaml: dma-controller@485c0100: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)
> Documentation/devicetree/bindings/dma/ti/k3-pktdma.example.dt.yaml: dma-controller@485c0000: Unevaluated properties are not allowed ('ti,sci', 'ti,sci-dev-id' were unexpected)
>
> Add a reference to ti,k3-sci-common.yaml to fix this.
>
> Cc: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: dmaengine@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml | 1 +
> Documentation/devicetree/bindings/dma/ti/k3-pktdma.yaml | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> index df29d59d13a8..08627d91e607 100644
> --- a/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/ti/k3-bcdma.yaml
> @@ -30,6 +30,7 @@ description: |
>
> allOf:
> - $ref: /schemas/dma/dma-controller.yaml#
> + - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
Out of curiosity: is the # at the end necessary, or do you just use it
as a convention? I've seen a mix of both and there also seems to be a
healthy mix of quoted and unquoted paths. Do we want to settle on one
going forward or do we not care enough?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-12-07 8:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 17:42 [PATCH] dt-bindings: dma: ti: Add missing ti,k3-sci-common.yaml reference Rob Herring
2021-12-07 8:40 ` Thierry Reding [this message]
2021-12-07 14:17 ` Rob Herring
2021-12-13 6:06 ` Vinod Koul
2021-12-13 6:07 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ya8eC9UkwMZaNozs@orome.fritz.box \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.