Re: [PATCH 2/2] ghes_edac: refactor error status fields decoding

From: Robert Richter <rric@kernel.org>
To: Shuai Xue <xueshuai@linux.alibaba.com>
Cc: mchehab@kernel.org, bp@alien8.de, tony.luck@intel.com,
	james.morse@arm.com, ardb@kernel.org, linux-edac@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org,
	zhangliguang@linux.alibaba.com, zhuo.song@linux.alibaba.com
Subject: Re: [PATCH 2/2] ghes_edac: refactor error status fields decoding
Date: Tue, 7 Dec 2021 12:47:17 +0100	[thread overview]
Message-ID: <Ya9JxfyXYYNtLoSf@rric.localdomain> (raw)
In-Reply-To: <20211207031905.61906-3-xueshuai@linux.alibaba.com>

On 07.12.21 11:19:05, Shuai Xue wrote:

> @@ -285,6 +285,48 @@ int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg)
>  	return n;
>  }
>  
> +const char *cper_mem_err_status_str(u64 status)

[...]

Same here, add an EXPORT_SYMBOL_GPL for the function.

> --- a/include/linux/cper.h
> +++ b/include/linux/cper.h
> @@ -568,7 +568,8 @@ void cper_print_proc_arm(const char *pfx,
>  			 const struct cper_sec_proc_arm *proc);
>  void cper_print_proc_ia(const char *pfx,
>  			const struct cper_sec_proc_ia *proc);
> -int cper_mem_err_location(struct cper_mem_err_compact *mem, char *msg);
> -int cper_dimm_err_location(struct cper_mem_err_compact *mem, char *msg);
> +int cper_mem_err_location(const struct cper_mem_err_compact *mem, char *msg);
> +int cper_dimm_err_location(const struct cper_mem_err_compact *mem, char *msg);

Do we really need that 'const' here?

> +const char *cper_mem_err_status_str(u64 status);

The function i/f is different compared to the others, though the
purpose is the same. Let's use same style:

 int cper_mem_err_status(const struct cper_mem_err_compact *mem, char *msg);

-Robert