From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDAE972
	for <llvm@lists.linux.dev>; Fri, 26 Nov 2021 20:16:31 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5B959C9305B;
	Fri, 26 Nov 2021 20:16:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=k20201202; t=1637957791;
	bh=D43dJxH63xJnkFSZ3x1saj+JMV8TNEEF45D6HTba0io=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=tGBct4B5ez1IrJQl1a4ZtyZJ88pmVIy3QqSYazWf1vt+q59xPQX+E5AAEEgCQvjKM
	 L7r9CLS8pPwMFBvSUwUvncNzfrGClskuMmP/9TLbFJIGX42PWiHFjV6Zp1dpX0cCci
	 NeQr3oitQATqi2jhtI7IbErUBBtU/NO74i26U3g8HW1888IoDZNGPHqkG8eNv92Y9E
	 0RIbLS2tDAEzqdIZj07j+I7mBYs4xX5nUOh2QYnaq63f8UlKpVQV7qkK5tsIccDFOf
	 DmmqGq1TT+ipmZ7ty8TeM9Fj+b8Tk7M+bgx/rAihTjstfwEomXRm3iZYjJJ3rIt9hr
	 2GjMglxuz9JFw==
Date: Fri, 26 Nov 2021 13:16:25 -0700
From: Nathan Chancellor <nathan@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
	Malcolm Priestley <tvboxspy@gmail.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	llvm@lists.linux.dev
Subject: Re: [PATCH 11/20] media: lmedm04: don't ignore errors when setting a
 filter
Message-ID: <YaFAmTnfcoBi447U@archlinux-ax161>
References: <cover.1637781097.git.mchehab+huawei@kernel.org>
 <7da947b5433ecdd9cf1f2a50f4ae5cbc493dc844.1637781097.git.mchehab+huawei@kernel.org>
Precedence: bulk
X-Mailing-List: llvm@lists.linux.dev
List-Id: <llvm.lists.linux.dev>
List-Subscribe: <mailto:llvm+subscribe@lists.linux.dev>
List-Unsubscribe: <mailto:llvm+unsubscribe@lists.linux.dev>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7da947b5433ecdd9cf1f2a50f4ae5cbc493dc844.1637781097.git.mchehab+huawei@kernel.org>

On Wed, Nov 24, 2021 at 08:13:14PM +0100, Mauro Carvalho Chehab wrote:
> Solves a clang warning
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/
> 
>  drivers/media/usb/dvb-usb-v2/lmedm04.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> index fe4d886442a4..8a34e6c0d6a6 100644
> --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
> +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> @@ -423,6 +423,9 @@ static int lme2510_pid_filter_ctrl(struct dvb_usb_adapter *adap, int onoff)
>  
>  	mutex_unlock(&d->i2c_mutex);
>  
> +	if (ret)
> +		return -EREMOTEIO;
> +
>  	return 0;
>  }
>  
> -- 
> 2.33.1
> 
>