All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Cc: linuxarm@huawei.com, mauro.chehab@huawei.com,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 19/20] media: cobalt: drop an unused variable
Date: Fri, 26 Nov 2021 13:29:37 -0700	[thread overview]
Message-ID: <YaFDsZrPOO5gshoi@archlinux-ax161> (raw)
In-Reply-To: <ed14f3d4d03fbeb8d42d1bc6ffcb4d49ee18a8d2.1637781097.git.mchehab+huawei@kernel.org>

On Wed, Nov 24, 2021 at 08:13:22PM +0100, Mauro Carvalho Chehab wrote:
> The clock_control value is read but never actually used. Based on
> a comment at the code, it has to be reset at the function.
> 
> So, drop the variable that stores its value.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> 
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/20] at: https://lore.kernel.org/all/cover.1637781097.git.mchehab+huawei@kernel.org/
> 
>  drivers/media/pci/cobalt/cobalt-cpld.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/media/pci/cobalt/cobalt-cpld.c b/drivers/media/pci/cobalt/cobalt-cpld.c
> index 3d8026483ac3..fad882459d23 100644
> --- a/drivers/media/pci/cobalt/cobalt-cpld.c
> +++ b/drivers/media/pci/cobalt/cobalt-cpld.c
> @@ -236,7 +236,6 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out)
>  	u8 n1, hsdiv;
>  	u8 regs[6];
>  	int found = 0;
> -	u16 clock_ctrl;
>  	int retries = 3;
>  
>  	for (i = 0; i < ARRAY_SIZE(multipliers); i++) {
> @@ -260,9 +259,7 @@ bool cobalt_cpld_set_freq(struct cobalt *cobalt, unsigned f_out)
>  	hsdiv = multipliers[i_best].hsdiv - 4;
>  	rfreq = div_u64(dco << 28, f_xtal);
>  
> -	clock_ctrl = cpld_read(cobalt, SI570_CLOCK_CTRL);
> -	clock_ctrl |= S01755_REG_CLOCK_CTRL_BITMAP_CLKHSMA_FPGA_CTRL;
> -	clock_ctrl |= S01755_REG_CLOCK_CTRL_BITMAP_CLKHSMA_EN;
> +	cpld_read(cobalt, SI570_CLOCK_CTRL);
>  
>  	regs[0] = (hsdiv << 5) | (n1 >> 2);
>  	regs[1] = ((n1 & 0x3) << 6) | (rfreq >> 32);
> -- 
> 2.33.1
> 
> 

  reply	other threads:[~2021-11-26 20:38 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 19:13 [PATCH 00/20] Solve the remaining issues with clang and W=1 on media Mauro Carvalho Chehab
2021-11-24 19:13 ` Mauro Carvalho Chehab
2021-11-24 19:13 ` Mauro Carvalho Chehab
2021-11-24 19:13 ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 01/20] media: adv7842: get rid of two unused functions Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 18:54   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 02/20] media: saa7134-go7007: get rid of to_state() function Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 18:55   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 03/20] media: davinci: get rid of an unused function Mauro Carvalho Chehab
2021-11-26 18:56   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 04/20] media: drxd: drop offset var from DownloadMicrocode() Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 18:57   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 05/20] media: drxk: drop operation_mode from set_dvbt() Mauro Carvalho Chehab
2021-11-26 19:02   ` Nathan Chancellor
2021-11-29  8:33     ` [PATCH v2 " Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 06/20] media: m88ds3103: drop reg11 calculus from m88ds3103b_select_mclk() Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 19:40   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 07/20] media: si21xx: report eventual errors at set_frontend Mauro Carvalho Chehab
2021-11-26 19:45   ` Nathan Chancellor
2021-11-29  8:40     ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 08/20] media: solo6x10: add _maybe_unused to currently unused functions Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-25 21:18   ` Ismael Luceno
2021-11-26 19:58   ` Nathan Chancellor
2021-11-29  8:44     ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 09/20] media: si470x: fix printk warnings with clang Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 20:13   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 10/20] media: radio-si476x: drop a container_of() abstraction macro Mauro Carvalho Chehab
2021-11-26 20:14   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 11/20] media: lmedm04: don't ignore errors when setting a filter Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 20:16   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 12/20] media: au0828-i2c: drop a duplicated function Mauro Carvalho Chehab
2021-11-26 20:22   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 13/20] media: adv7604 add _maybe_unused to currently unused functions Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 14/20] media: adv7511: drop " Mauro Carvalho Chehab
2021-11-26 20:27   ` Nathan Chancellor
2021-11-24 19:13 ` [PATCH 15/20] media: imx290: mark read reg function as __maybe_unused Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 16/20] media: davinci: vpbe_osd: " Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:13 ` [PATCH 17/20] media: qcom: camss: " Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-25 10:58   ` Robert Foss
2021-11-24 19:13 ` [PATCH 18/20] media: mtk-mdp: address a clang warning Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-24 19:21   ` Arnd Bergmann
2021-11-24 19:21     ` Arnd Bergmann
2021-11-24 19:21     ` Arnd Bergmann
2021-11-24 19:13 ` [PATCH 19/20] media: cobalt: drop an unused variable Mauro Carvalho Chehab
2021-11-26 20:29   ` Nathan Chancellor [this message]
2021-11-24 19:13 ` [PATCH 20/20] media: mxl5005s: drop some dead code Mauro Carvalho Chehab
2021-11-24 19:13   ` Mauro Carvalho Chehab
2021-11-26 20:30   ` Nathan Chancellor
2021-11-24 19:23 ` [PATCH 00/20] Solve the remaining issues with clang and W=1 on media Arnd Bergmann
2021-11-24 19:23   ` Arnd Bergmann
2021-11-24 19:23   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaFDsZrPOO5gshoi@archlinux-ax161 \
    --to=nathan@kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=mauro.chehab@huawei.com \
    --cc=mchehab+huawei@kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.