Re: [PATCH v1 0/2] Cosmetic changes to erofs-utils

[Gao Xiang <hsiangkao@linux.alibaba.com>]

Hi Kelvin,

On Mon, Nov 29, 2021 at 07:01:53PM -0800, Kelvin Zhang wrote:
> The following patches make erofs-utils more C++ friendly. It does not
> perform any refactoring, instead it simply added extern "C" keywords so
> that C++ code can call into EROFS.
> 
> Kelvin Zhang (2):
>   Add android build target to build erofs as library

Thanks for your patches.

Once we discussed earlier, Android.bp is not a part of erofs-utils
since I couldn't maintain it without Android build environment.
Android build environment is somewhat hard for me to keep up
with....

I think Android.bp can be resolved when upgrading AOSP erofs-utils
code base.

>   Make erofs-utils more C++ friendly

At glance, it looks good to me, I will test later in the evening.

Btw, how about adding "erofs-utils:" prefix to each patch. It will be
easier for me to apply these...

Thanks,
Gao Xiang

> 
>  Android.bp                     | 38 +++++++++++++++++++++++++++++++---
>  include/erofs/blobchunk.h      | 10 +++++++++
>  include/erofs/block_list.h     | 10 +++++++++
>  include/erofs/cache.h          |  9 ++++++++
>  include/erofs/compress.h       |  9 ++++++++
>  include/erofs/compress_hints.h | 10 +++++++++
>  include/erofs/config.h         | 20 ++++++++----------
>  include/erofs/decompress.h     |  9 ++++++++
>  include/erofs/defs.h           | 20 ++++++++++++++++++
>  include/erofs/err.h            |  9 ++++++++
>  include/erofs/exclude.h        | 10 +++++++++
>  include/erofs/flex-array.h     |  9 ++++++++
>  include/erofs/hashmap.h        |  9 ++++++++
>  include/erofs/hashtable.h      |  9 ++++++++
>  include/erofs/inode.h          |  9 ++++++++
>  include/erofs/internal.h       |  9 ++++++++
>  include/erofs/io.h             | 11 ++++++++++
>  include/erofs/list.h           | 10 +++++++++
>  include/erofs/print.h          |  9 ++++++++
>  include/erofs/trace.h          |  9 ++++++++
>  include/erofs/xattr.h          |  9 ++++++++
>  include/erofs_fs.h             |  9 ++++++++
>  lib/config.c                   | 12 +++++++++++
>  lib/inode.c                    |  7 +++++++
>  lib/xattr.c                    | 12 +++++++++++
>  mkfs/main.c                    |  7 +++++++
>  26 files changed, 280 insertions(+), 14 deletions(-)
> 
> -- 
> 2.34.0.rc2.393.gf8c9666880-goog