All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-api@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-mmc@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs
Date: Mon, 29 Nov 2021 23:40:13 -0800	[thread overview]
Message-ID: <YaXVXU77yvKUyVwg@sol.localdomain> (raw)
In-Reply-To: <8745aed7-d4b6-eb8d-60ad-f4d768d62a62@suse.de>

On Tue, Nov 30, 2021 at 07:49:54AM +0100, Hannes Reinecke wrote:
> >    - "modes" is a sub-subdirectory, since there may be multiple supported
> >      crypto modes, and sysfs is supposed to have one value per file.
> > 
> Why do you have a sub-directory here?
> From what I can see, that subdirectory just contains the supported modes, so
> wouldn't it be easier to create individual files like 'mode_<modename>'
> instead of a subdirectory?

It is a group of attributes, so it makes sense to group them together rather
than put them all in the parent directory alongside other attributes.  It also
allows the use of proper names like "AES-256-XTS" rather than weird names like
"mode_AES-256-XTS" or "mode_aes_256_xts".

- Eric

  reply	other threads:[~2021-11-30  7:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-30  4:03 [PATCH v2 0/3] block: show crypto capabilities in sysfs Eric Biggers
2021-11-30  4:03 ` [PATCH v2 1/3] block: simplify calling convention of elv_unregister_queue() Eric Biggers
2021-11-30  6:44   ` Hannes Reinecke
2021-11-30  4:03 ` [PATCH v2 2/3] block: don't delete queue kobject before its children Eric Biggers
2021-11-30  6:45   ` Hannes Reinecke
2021-11-30  7:09   ` Greg Kroah-Hartman
2021-11-30  4:03 ` [PATCH v2 3/3] blk-crypto: show crypto capabilities in sysfs Eric Biggers
2021-11-30  6:49   ` Hannes Reinecke
2021-11-30  7:40     ` Eric Biggers [this message]
2021-12-01  6:45       ` Hannes Reinecke
2021-11-30  7:13   ` Greg Kroah-Hartman
2021-11-30  7:31     ` Eric Biggers
2021-11-30  7:49       ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YaXVXU77yvKUyVwg@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hare@suse.de \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.