From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D00EC433EF for ; Tue, 30 Nov 2021 15:30:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RJqLV43GFRuIhZR5eaj8mZ/MDz3vE9o9+56aqGIo5YE=; b=JdCKXptbQYYViF f3N499huMndA75UjkieIXP4rNh8USGOyVeD8UN9iP4rVMNQDxUrdvHLg0nfHSuYdCz7o6deZg2e/d 83XyjMaxTz39KRqdlLAYpXRg1kuS8hD1XqHoQ4oVKOnL5wyULJdM5GpDUHoa1mb5JRbVRJPa+6B1d hxeuQ8dKivR5HIr4sa7xEr6Mdmhw2G84rdnkkIhvQaShu608BLH3GXJJW/EHugzWrvQHBm7fjAhq5 gvzmLyn4uKUd81bxIVq5gVJY+Sz/1iruyi5FBk7KYUIcBOdVvQE+AzIi4djtvHgBCJXKzmZ9bSt/+ nLgWVT5oSGNDw/6Sj5Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms53X-005tUI-1K; Tue, 30 Nov 2021 15:28:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ms4oY-005omu-Js for linux-arm-kernel@lists.infradead.org; Tue, 30 Nov 2021 15:13:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/8gHhP2BnGI3vqudawDw/cV7KIgs6gzYFMRut6/J9QA=; b=H6grOkiRg/XRBMKPO9olt5aesY VMTPSOSVQI8vbZDJObcTuUzg259vCFZ4dcCLTYM5HFmuQtq8TUi8J4MLQerzn77IjJuhBQYvN1UXF QcMqUuRb7f9tH5AkJl/VHPmVLGo9QGIMtTJVfZ0TBO9lzYPB/HC4hlegRfJSVQ17UxuDzlSjj8oYE 2SbBvKeL+4GEQipNTSgYc9BynqmtMtruiyv2e58VEjsv3xLX5CpzOgaSKf5WS1sZrdWSfM/MbxodO e5AtlOhxQxfnjDTdrKFaDl8NRMWCgwB2T8t1IfP2TO2e1KqCMJAttdY1kNMimR65yedAlNOc8ou8K th8w1XRw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:55988) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ms4oB-00074E-Dj; Tue, 30 Nov 2021 15:12:39 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1ms4o7-00079A-UY; Tue, 30 Nov 2021 15:12:35 +0000 Date: Tue, 30 Nov 2021 15:12:35 +0000 From: "Russell King (Oracle)" To: Ard Biesheuvel Cc: linux-arm-kernel@lists.infradead.org, Nicolas Pitre , Arnd Bergmann , Kees Cook , Keith Packard , Linus Walleij , Nick Desaulniers , Tony Lindgren Subject: Re: [PATCH v2 09/12] ARM: percpu: add SMP_ON_UP support Message-ID: References: <20211130125901.3054-1-ardb@kernel.org> <20211130125901.3054-10-ardb@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211130125901.3054-10-ardb@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_071302_709242_781AB765 X-CRM114-Status: GOOD ( 13.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 30, 2021 at 01:58:58PM +0100, Ard Biesheuvel wrote: > diff --git a/arch/arm/include/asm/percpu.h b/arch/arm/include/asm/percpu.h > index e2fcb3cfd3de..ff8f0829e041 100644 > --- a/arch/arm/include/asm/percpu.h > +++ b/arch/arm/include/asm/percpu.h > @@ -5,15 +5,22 @@ > #ifndef _ASM_ARM_PERCPU_H_ > #define _ASM_ARM_PERCPU_H_ > > +#include > + > register unsigned long current_stack_pointer asm ("sp"); > > /* > * Same as asm-generic/percpu.h, except that we store the per cpu offset > * in the TPIDRPRW. TPIDRPRW only exists on V6K and V7 > */ > -#if defined(CONFIG_SMP) && !defined(CONFIG_CPU_V6) > +#ifdef CONFIG_SMP > +extern unsigned int smp_on_up; I would much rather we kept this hidden from global view by placing it inside the set_my_cpu_offset() body. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel