From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Marek Behún" <kabel@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net
Subject: Re: [PATCH net 6/6] net: dsa: mv88e6xxx: Link in pcs_get_state() if AN is bypassed
Date: Tue, 30 Nov 2021 16:22:18 +0000 [thread overview]
Message-ID: <YaZPutgAUbd4eUqN@shell.armlinux.org.uk> (raw)
In-Reply-To: <20211130171859.6deeb17d@thinkpad>
On Tue, Nov 30, 2021 at 05:18:59PM +0100, Marek Behún wrote:
> On Tue, 30 Nov 2021 16:15:50 +0000
> "Russell King (Oracle)" <linux@armlinux.org.uk> wrote:
>
> > On Tue, Nov 30, 2021 at 05:09:11PM +0100, Marek Behún wrote:
> > > Seems that BMSR_ANEGCAPABLE is set even if AN is disabled in BMCR.
> >
> > Hmm, that behaviour goes against 22.2.4.2.10:
> >
> > A PHY shall return a value of zero in bit 1.5 if Auto-Negotiation is
> > disabled by clearing bit 0.12. A PHY shall also return a value of zero
> > in bit 1.5 if it lacks the ability to perform Auto-Negotiation.
> >
> > > I was under the impression that
> > > state->an_complete
> > > should only be set to true if AN is enabled.
> >
> > Yes - however as you've stated, the PHY doesn't follow 802.3 behaviour
> > so I guess we should make the emulation appear compliant by fixing it
> > like this.
>
> OK, I will use BMCR_ANENABLE and add a comment explaining that we can't
> use BMSR_ANEGCAPABLE because the PHY violates standard. Would that be
> okay?
Yes, thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2021-11-30 16:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 19:58 [PATCH net 0/6] mv88e6xxx fixes (mainly 88E6393X family) Marek Behún
2021-11-29 19:58 ` [PATCH net 1/6] net: dsa: mv88e6xxx: Fix application of erratum 4.8 for 88E6393X Marek Behún
2021-11-29 19:58 ` [PATCH net 2/6] net: dsa: mv88e6xxx: Drop unnecessary check in mv88e6393x_serdes_erratum_4_6() Marek Behún
2021-11-29 19:58 ` [PATCH net 3/6] net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver Marek Behún
2021-11-29 23:06 ` Russell King (Oracle)
2021-11-30 0:13 ` Marek Behún
2021-11-29 19:58 ` [PATCH net 4/6] net: dsa: mv88e6xxx: Add fix for erratum 5.2 of 88E6393X family Marek Behún
2021-11-29 19:58 ` [PATCH net 5/6] net: dsa: mv88e6xxx: Fix inband AN for 2500base-x on " Marek Behún
2021-11-29 19:58 ` [PATCH net 6/6] net: dsa: mv88e6xxx: Link in pcs_get_state() if AN is bypassed Marek Behún
2021-11-29 23:14 ` Russell King (Oracle)
2021-11-30 0:18 ` Marek Behún
2021-11-30 16:09 ` Marek Behún
2021-11-30 16:15 ` Russell King (Oracle)
2021-11-30 16:18 ` Marek Behún
2021-11-30 16:22 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaZPutgAUbd4eUqN@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.