From: Matthias Kaehlcke <mka@chromium.org>
To: Rajendra Nayak <quic_rjendra@quicinc.com>
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
robh+dt@kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dianders@chromium.org, kgodara@codeaurora.org,
Kshitiz Godara <kgodara1@codeaurora.org>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support
Date: Tue, 30 Nov 2021 12:03:30 -0800 [thread overview]
Message-ID: <YaaDkiFp54mLAbJH@google.com> (raw)
In-Reply-To: <1638185497-26477-5-git-send-email-quic_rjendra@quicinc.com>
On Mon, Nov 29, 2021 at 05:01:37PM +0530, Rajendra Nayak wrote:
> From: Kshitiz Godara <kgodara1@codeaurora.org>
>
> Add Touchscreen and touchpad hid-over-i2c node for the sc7280 CRD board
>
> Signed-off-by: Kshitiz Godara <kgodara1@codeaurora.org>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/sc7280-crd.dts | 61 +++++++++++++++++++++++++++++++++
> 1 file changed, 61 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> index 1e3e2f3..fcfb14d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> @@ -23,6 +23,47 @@
> };
> };
>
> +ap_tp_i2c: &i2c0 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + trackpad: trackpad@15 {
> + compatible = "hid-over-i2c";
> + reg = <0x15>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&tp_int_odl>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <7 IRQ_TYPE_EDGE_FALLING>;
> +
> + post-power-on-delay-ms = <20>;
> + hid-descr-addr = <0x0001>;
> + vdd-supply = <&vreg_l18b_1p8>;
> +
> + wakeup-source;
> + };
> +};
> +
> +ap_ts_pen_1v8: &i2c13 {
> + status = "okay";
> + clock-frequency = <400000>;
> +
> + ap_ts: touchscreen@5c {
> + compatible = "hid-over-i2c";
> + reg = <0x5C>;
nit: the convention seems to be to use lowercase characters for hex numbers.
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2021-11-30 20:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 11:31 [PATCH v2 0/4] arm64: dts: qcom: Add support for the sc7280 CRD board Rajendra Nayak
2021-11-29 11:31 ` [PATCH v2 1/4] dt-bindings: arm: qcom: Document qcom,sc7280-crd board Rajendra Nayak
2021-11-29 18:08 ` Matthias Kaehlcke
2021-11-29 11:31 ` [PATCH v2 2/4] arm64: dts: qcom: sc7280-crd: Add device tree files for CRD Rajendra Nayak
2021-11-29 18:45 ` Matthias Kaehlcke
2021-11-29 11:31 ` [PATCH v2 3/4] arm64: dts: qcom: sc7280: Define EC and H1 nodes for IDP/CRD Rajendra Nayak
2021-11-30 19:35 ` Matthias Kaehlcke
2021-11-29 11:31 ` [PATCH v2 4/4] arm64: dts: qcom: sc7280-crd: Add Touchscreen and touchpad support Rajendra Nayak
2021-11-30 20:03 ` Matthias Kaehlcke [this message]
2021-12-01 15:13 ` [PATCH v2 0/4] arm64: dts: qcom: Add support for the sc7280 CRD board Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YaaDkiFp54mLAbJH@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=kgodara1@codeaurora.org \
--cc=kgodara@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_rjendra@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.