From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4E2AC433F5 for ; Tue, 30 Nov 2021 22:05:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344398AbhK3WIu (ORCPT ); Tue, 30 Nov 2021 17:08:50 -0500 Received: from mail-ot1-f43.google.com ([209.85.210.43]:41931 "EHLO mail-ot1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229837AbhK3WIs (ORCPT ); Tue, 30 Nov 2021 17:08:48 -0500 Received: by mail-ot1-f43.google.com with SMTP id n17-20020a9d64d1000000b00579cf677301so32245627otl.8; Tue, 30 Nov 2021 14:05:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=17xD67r1Po50dKFrN6zPSs2unPvmO1WfBjCX12oxOdY=; b=1Sy3TOka/6xcf7Du2aw1fD7G70c5zY8hC9HihFZW4XCAtzINQOqc9i0MBirAFDEibD 2ukB/xeUhkimHO+lGsh8AFN9ZFIM8+LNn7Kj29PF7NM3z17nAFfr5xzDiDBEiLOQIr77 VZ+7q2WDIa01FE13F9zBy8rT6UPJGRX9LikoHbKi6Mr6iShEyi5RNGxATTkJ8LWKgM01 uBlYAoZ8Xlze9D9CzAkXxY6eEGHqyJcjsceWdj6sXwUSCNQ4oQo9Jayme10jmTwPM/0e jFTVLVnadS5Ql5JXc6TWXdFoo9qFgz9Z+N8+IohtkL7xAItyQ0d62NcIw9HVwzZH/dPZ EvuQ== X-Gm-Message-State: AOAM533gPSQIbuFYrjE6lh6S1XrJ9mn46Eg7IfO/1ESBLB5uJ7kC8xaV 0JxNTRwGWXyRUjVjFJy2vQ== X-Google-Smtp-Source: ABdhPJyj4IRd5mFpSXJj1d5bjNj+dfT6nlMA5FsUuzkeuwrS0n3omP/gEosMzBWySdeTy8h7PGCUyw== X-Received: by 2002:a9d:7855:: with SMTP id c21mr1891595otm.167.1638309928423; Tue, 30 Nov 2021 14:05:28 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id m12sm3348035ots.59.2021.11.30.14.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 14:05:27 -0800 (PST) Received: (nullmailer pid 3093201 invoked by uid 1000); Tue, 30 Nov 2021 22:05:25 -0000 Date: Tue, 30 Nov 2021 16:05:25 -0600 From: Rob Herring To: Zhen Lei Cc: Vivek Goyal , Chen Zhou , Frank Rowand , linux-doc@vger.kernel.org, Ingo Molnar , devicetree@vger.kernel.org, Catalin Marinas , Eric Biederman , Feng Zhou , "H . Peter Anvin" , Jonathan Corbet , Rob Herring , linux-kernel@vger.kernel.org, Borislav Petkov , x86@kernel.org, Randy Dunlap , Baoquan He , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kefeng Wang , Will Deacon , Dave Young , Thomas Gleixner Subject: Re: [PATCH v16 09/11] of: fdt: Aggregate the processing of "linux,usable-memory-range" Message-ID: References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-10-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123124646.1995-10-thunder.leizhen@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 23 Nov 2021 20:46:44 +0800, Zhen Lei wrote: > Currently, we parse the "linux,usable-memory-range" property in > early_init_dt_scan_chosen(), to obtain the specified memory range of the > crash kernel. We then reserve the required memory after > early_init_dt_scan_memory() has identified all available physical memory. > Because the two pieces of code are separated far, the readability and > maintainability are reduced. So bring them together. > > Suggested-by: Rob Herring > Signed-off-by: Zhen Lei > --- > drivers/of/fdt.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86B0EC433EF for ; Tue, 30 Nov 2021 22:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G0HP3453LDzczdroTIbap2E5ygNNJ1VT9yCbAl9oyNE=; b=n2vmjPc1lxwqLo Q40yffejEmyKTUVzuj1Wftg+C75M22Bc28HlWEsPbNCZFmbTjuPxpbc66H0FGWlDBULUrDUvbn4YV E0xkWYEQY5yrgy0RP2uCHPjtEORili+YOzM1eSyy8puPwTZyQ58h2+YyXhCrp2WhfJOHRBQ59bH+8 JljRNP5b4grBKMLadoXqsG+IoxWN/85A/EW1YzWdDliY27Qcaj9AjS6aU3eW4tmcDaK6ftayNotoJ yckb7DeqR6xZWrzEsYWp1d7e/r0d2vA3gbdFgJY4ca/u9h5uRXuqNUA09IHM9Mwattuwh7BQPDe8a hg6vFF7vNlSJCvCpNc0Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msBGe-006u8o-8o; Tue, 30 Nov 2021 22:06:28 +0000 Received: from mail-ot1-f54.google.com ([209.85.210.54]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msBFh-006tny-Pn; Tue, 30 Nov 2021 22:05:31 +0000 Received: by mail-ot1-f54.google.com with SMTP id h19-20020a9d3e53000000b0056547b797b2so32269608otg.4; Tue, 30 Nov 2021 14:05:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=17xD67r1Po50dKFrN6zPSs2unPvmO1WfBjCX12oxOdY=; b=oDSGZWe46YI7r+aHovoutpnOQU19b8ulIftaRaGdWJ0BzoYuAewxPnoz5ZngxMxMX9 PcumurrqrGV7UFXiQZM5hSaIt00ND2U1bF/f+fR2IrsqmLbd93M6az8jQ2Z6BFfha4z7 hvdpqOqLnX8gApUdX+z/D/f2ZHk6A8kbW4fp9BQL2XrP5WXI8Fmufw9Zxv85t70+A0rt OlLADVUYrDJT9TTqfmAnmBnNbTzIdOrNmyVPfRbKR2FvhoMEYKYkrACXkfhRaNigTPMs SWCeHXW3thyOycaGUmkwjm1mwtLzsxjqQL45DGKk2sfMOVVKBzz3LNNRR4M9h4DkYgUI A2zw== X-Gm-Message-State: AOAM531um5EUzJJStIE65g+gx21a99B4RoCBpTRYwtxLt+r4k28o1HNa GRpeFXFFzQXCtL/7zwgI7w== X-Google-Smtp-Source: ABdhPJyj4IRd5mFpSXJj1d5bjNj+dfT6nlMA5FsUuzkeuwrS0n3omP/gEosMzBWySdeTy8h7PGCUyw== X-Received: by 2002:a9d:7855:: with SMTP id c21mr1891595otm.167.1638309928423; Tue, 30 Nov 2021 14:05:28 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id m12sm3348035ots.59.2021.11.30.14.05.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Nov 2021 14:05:27 -0800 (PST) Received: (nullmailer pid 3093201 invoked by uid 1000); Tue, 30 Nov 2021 22:05:25 -0000 Date: Tue, 30 Nov 2021 16:05:25 -0600 From: Rob Herring To: Zhen Lei Cc: Vivek Goyal , Chen Zhou , Frank Rowand , linux-doc@vger.kernel.org, Ingo Molnar , devicetree@vger.kernel.org, Catalin Marinas , Eric Biederman , Feng Zhou , "H . Peter Anvin" , Jonathan Corbet , Rob Herring , linux-kernel@vger.kernel.org, Borislav Petkov , x86@kernel.org, Randy Dunlap , Baoquan He , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kefeng Wang , Will Deacon , Dave Young , Thomas Gleixner Subject: Re: [PATCH v16 09/11] of: fdt: Aggregate the processing of "linux,usable-memory-range" Message-ID: References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-10-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211123124646.1995-10-thunder.leizhen@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_140529_912679_C10938EB X-CRM114-Status: GOOD ( 12.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 23 Nov 2021 20:46:44 +0800, Zhen Lei wrote: > Currently, we parse the "linux,usable-memory-range" property in > early_init_dt_scan_chosen(), to obtain the specified memory range of the > crash kernel. We then reserve the required memory after > early_init_dt_scan_memory() has identified all available physical memory. > Because the two pieces of code are separated far, the readability and > maintainability are reduced. So bring them together. > > Suggested-by: Rob Herring > Signed-off-by: Zhen Lei > --- > drivers/of/fdt.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 30 Nov 2021 16:05:25 -0600 From: Rob Herring Subject: Re: [PATCH v16 09/11] of: fdt: Aggregate the processing of "linux,usable-memory-range" Message-ID: References: <20211123124646.1995-1-thunder.leizhen@huawei.com> <20211123124646.1995-10-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211123124646.1995-10-thunder.leizhen@huawei.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Zhen Lei Cc: Vivek Goyal , Chen Zhou , Frank Rowand , linux-doc@vger.kernel.org, Ingo Molnar , devicetree@vger.kernel.org, Catalin Marinas , Eric Biederman , Feng Zhou , "H . Peter Anvin" , Jonathan Corbet , Rob Herring , linux-kernel@vger.kernel.org, Borislav Petkov , x86@kernel.org, Randy Dunlap , Baoquan He , kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Kefeng Wang , Will Deacon , Dave Young , Thomas Gleixner On Tue, 23 Nov 2021 20:46:44 +0800, Zhen Lei wrote: > Currently, we parse the "linux,usable-memory-range" property in > early_init_dt_scan_chosen(), to obtain the specified memory range of the > crash kernel. We then reserve the required memory after > early_init_dt_scan_memory() has identified all available physical memory. > Because the two pieces of code are separated far, the readability and > maintainability are reduced. So bring them together. > > Suggested-by: Rob Herring > Signed-off-by: Zhen Lei > --- > drivers/of/fdt.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > Reviewed-by: Rob Herring _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec