From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A882C433F5 for ; Wed, 1 Dec 2021 18:23:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352327AbhLAS1Q (ORCPT ); Wed, 1 Dec 2021 13:27:16 -0500 Received: from foss.arm.com ([217.140.110.172]:44186 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237744AbhLAS1P (ORCPT ); Wed, 1 Dec 2021 13:27:15 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EEE2150C; Wed, 1 Dec 2021 10:23:54 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.65.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6AF9E3F766; Wed, 1 Dec 2021 10:23:52 -0800 (PST) Date: Wed, 1 Dec 2021 18:23:49 +0000 From: Mark Rutland To: Thomas Gleixner Cc: Steven Rostedt , Nicolas Saenz Julienne , linux-kernel , linux-arm-kernel , rcu@vger.kernel.org, Peter Zijlstra , paulmck@kernel.org, mtosatti , frederic , Jonathan Corbet Subject: Re: [PATCH] Documentation: Fill the gaps about entry/noinstr constraints Message-ID: References: <8719ad46cc29a2c5d7baac3c35770e5460ab8d5c.camel@redhat.com> <875ys9dacq.ffs@tglx> <20211130091356.7336e277@gandalf.local.home> <878rx5b7i5.ffs@tglx> <87v9088a5q.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v9088a5q.ffs@tglx> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 01, 2021 at 07:14:41PM +0100, Thomas Gleixner wrote: > Mark, > > On Wed, Dec 01 2021 at 10:56, Mark Rutland wrote: > > On Tue, Nov 30, 2021 at 11:31:30PM +0100, Thomas Gleixner wrote: > >> --- > >> Documentation/core-api/entry.rst | 268 +++++++++++++++++++++++++++++++++++++++ > >> Documentation/core-api/index.rst | 8 + > >> kernel/entry/common.c | 1 > > > > I think the change to kernel/entry/common.c got included by accident? > > That's what I get from doing such things 30 minutes before midnight... Ah, I had debugged it down to: nobikeshed void do_rst(struct tglx *tglx); { aargh_rst_enter(tglx); documentation_begin(); invoke_editor(tglx); documentation_end(); } ... where I think we forgot the: enter_from_sleep_mode(tglx); ... exit_to_sleep_mode(tglx); Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52EE1C433EF for ; Wed, 1 Dec 2021 18:25:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kIpJyeOlqHFJ5bjAGl9+KYVGxVXKLyn1uEpfjO4ckdw=; b=YFkk73jM/6CHND Wj5u4Xra3wTKNcRIItTSB8iWqIGOnaSnXEYrqicQ+ygaO7MOypBEOziZQ1nR6ApaAi6GPkhLAolkI bz7oyqgF4371NTbyI5IeEVlm2nUj/v1bsx58jzt8RGCRmQtfFkr98/0xTg58qUQWoYmAo6wtQSLOQ BjhYZ5pnpf9jPOWTk8nTi9S/sVUvnqhGWgr9UERKorJ2TRdNve6dSQwfLhUh07YH45j9cMhN6FRa9 EEWFwzvAajT+Xx84CfXMECr+tFseqw07RyxpLw3k7nXbfpkDY3ipg/uPCss2C2s9Iuzj6xEFyCUNu nsJ2g6vbDBEhpQGcxn9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msUHW-009l9r-9Z; Wed, 01 Dec 2021 18:24:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msUGp-009kqN-7p for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 18:23:58 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2EEE2150C; Wed, 1 Dec 2021 10:23:54 -0800 (PST) Received: from FVFF77S0Q05N (unknown [10.57.65.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6AF9E3F766; Wed, 1 Dec 2021 10:23:52 -0800 (PST) Date: Wed, 1 Dec 2021 18:23:49 +0000 From: Mark Rutland To: Thomas Gleixner Cc: Steven Rostedt , Nicolas Saenz Julienne , linux-kernel , linux-arm-kernel , rcu@vger.kernel.org, Peter Zijlstra , paulmck@kernel.org, mtosatti , frederic , Jonathan Corbet Subject: Re: [PATCH] Documentation: Fill the gaps about entry/noinstr constraints Message-ID: References: <8719ad46cc29a2c5d7baac3c35770e5460ab8d5c.camel@redhat.com> <875ys9dacq.ffs@tglx> <20211130091356.7336e277@gandalf.local.home> <878rx5b7i5.ffs@tglx> <87v9088a5q.ffs@tglx> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87v9088a5q.ffs@tglx> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_102355_428124_AFAC97FE X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 01, 2021 at 07:14:41PM +0100, Thomas Gleixner wrote: > Mark, > > On Wed, Dec 01 2021 at 10:56, Mark Rutland wrote: > > On Tue, Nov 30, 2021 at 11:31:30PM +0100, Thomas Gleixner wrote: > >> --- > >> Documentation/core-api/entry.rst | 268 +++++++++++++++++++++++++++++++++++++++ > >> Documentation/core-api/index.rst | 8 + > >> kernel/entry/common.c | 1 > > > > I think the change to kernel/entry/common.c got included by accident? > > That's what I get from doing such things 30 minutes before midnight... Ah, I had debugged it down to: nobikeshed void do_rst(struct tglx *tglx); { aargh_rst_enter(tglx); documentation_begin(); invoke_editor(tglx); documentation_end(); } ... where I think we forgot the: enter_from_sleep_mode(tglx); ... exit_to_sleep_mode(tglx); Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel